kc3-lang/angle/src/compiler/translator/tree_ops/ForcePrecisionQualifier.cpp

• Show log

  Commit

• Hash : daeac238
  Author :
  Date : 2021-05-08T22:09:38
  

  Translator: Ensure structs and blocks are uniquely defined
  
  A new AST validation is added to ensure that the same TStructure or
  TInterfaceBlock is not redundantly defined.  This helps with SPIR-V
  generation by allowing the id to be used as key in a hash map that looks
  up the corresponding SPIR-V type id.
  
  A bug is fixed where the Vulkan driver uniform declaration created two
  identical declarations for ANGLEDepthRangeParams.
  
  A number of other bugs are also fixed in this change, where if a
  variable declaration is eliminated (for example due to constant folding,
  or inactive interface variable removal) and it contained a struct
  specifier, the struct declaration was also removed.  OutputGLSLBase had
  a hack where structs were declared on first encounter, which was
  incorrect as the scope of the declaration could change.  Those bugs are
  fixed and this hack is removed.
  
  Bug: angleproject:2733
  Bug: angleproject:4889
  Bug: angleproject:5936
  Change-Id: I8e13748c0bf552ae8b052249282769a1f0775603
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2881942
  Reviewed-by: Charlie Lao <cclao@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/tree_ops/ForcePrecisionQualifier.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "compiler/translator/tree_ops/ForcePrecisionQualifier.h"
  #include "angle_gl.h"
  #include "common/debug.h"
  #include "compiler/translator/Compiler.h"
  #include "compiler/translator/tree_util/IntermTraverse.h"
  #include "compiler/translator/util.h"
  
  namespace sh
  {
  
  namespace
  {
  class TPrecisionTraverser : public TIntermTraverser
  {
    public:
      TPrecisionTraverser(TSymbolTable *symbolTable);
  
    protected:
      bool visitDeclaration(Visit visit, TIntermDeclaration *node) override;
  
      void overwriteVariablePrecision(TType *type) const;
  };
  
  TPrecisionTraverser::TPrecisionTraverser(TSymbolTable *symbolTable)
      : TIntermTraverser(true, true, true, symbolTable)
  {}
  
  void TPrecisionTraverser::overwriteVariablePrecision(TType *type) const
  {
      if (type->getPrecision() == EbpHigh)
      {
          type->setPrecision(EbpMedium);
      }
  }
  
  bool TPrecisionTraverser::visitDeclaration(Visit visit, TIntermDeclaration *node)
  {
      // Variable declaration.
      if (visit == PreVisit)
      {
          const TIntermSequence &sequence = *(node->getSequence());
          TIntermTyped *variable          = sequence.front()->getAsTyped();
          const TType &type               = variable->getType();
          TQualifier qualifier            = variable->getQualifier();
  
          // Don't modify uniform since it might be shared between vertex and fragment shader
          if (qualifier == EvqUniform)
          {
              return true;
          }
  
          // Visit the struct.
          if (type.isStructSpecifier())
          {
              const TStructure *structure = type.getStruct();
              const TFieldList &fields    = structure->fields();
              for (size_t i = 0; i < fields.size(); ++i)
              {
                  const TField *field    = fields[i];
                  const TType *fieldType = field->type();
                  overwriteVariablePrecision((TType *)fieldType);
              }
          }
          else if (type.getBasicType() == EbtInterfaceBlock)
          {
              const TInterfaceBlock *interfaceBlock = type.getInterfaceBlock();
              const TFieldList &fields              = interfaceBlock->fields();
              for (const TField *field : fields)
              {
                  const TType *fieldType = field->type();
                  overwriteVariablePrecision((TType *)fieldType);
              }
          }
          else
          {
              overwriteVariablePrecision((TType *)&type);
          }
      }
      return true;
  }
  }  // namespace
  
  bool ForceShaderPrecisionToMediump(TIntermNode *root, TSymbolTable *symbolTable, GLenum shaderType)
  {
      if (shaderType != GL_FRAGMENT_SHADER)
      {
          return true;
      }
  
      TPrecisionTraverser traverser(symbolTable);
      root->traverse(&traverser);
      return true;
  }
  
  }  // namespace sh
  

Download