kc3-lang/angle/src/libANGLE/Device.cpp

• Show log

  Commit

• Hash : cfb430c8
  Author :
  Date : 2025-02-10T13:19:05
  

  Remove angle::ErrorStream helper
  
  Most uses of the helper either use just the code or a fixed string,
  which compiles to a few instructions. Using this helper adds 200+ bytes
  of assembly to each use, due to the unneeded instantiation of
  ostringstream which allocates a buffer etc. The combined effect of this
  CL on an Android perf build is ~12KB (0.2%) reduction in size.
  
  The cases where the message is actually formatted are converted to an
  explicit use of ostringstream. Removing the helper so that the new code
  is explicit about the intent to use ostringstream, or an alternative way
  to format the message.
  
  Discovered accidentally while looking into size reduction due to
  __builtin_unreachable()
  
  Semi-automated code change, risk of copy-paste mistakes should be
  minimal.
  
  Bug: angleproject:394129077
  Change-Id: I47c2642d750d31416b08a1cfa435d5463c294e35
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6250078
  Commit-Queue: Roman Lavrov <romanl@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  

Download

• src/libANGLE/Device.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // Device.cpp: Implements the egl::Device class, representing the abstract
  // device. Implements EGLDevice.
  
  #include "libANGLE/Device.h"
  
  #include <iterator>
  
  #include <EGL/eglext.h>
  #include <platform/PlatformMethods.h>
  
  #include "anglebase/no_destructor.h"
  #include "common/debug.h"
  #include "common/platform.h"
  #include "libANGLE/renderer/DeviceImpl.h"
  
  #if defined(ANGLE_ENABLE_D3D11)
  #    include "libANGLE/renderer/d3d/d3d11/Device11.h"
  #endif
  
  namespace egl
  {
  
  template <typename T>
  static std::string GenerateExtensionsString(const T &extensions)
  {
      std::vector<std::string> extensionsVector = extensions.getStrings();
  
      std::ostringstream stream;
      std::copy(extensionsVector.begin(), extensionsVector.end(),
                std::ostream_iterator<std::string>(stream, " "));
      return stream.str();
  }
  
  typedef std::set<egl::Device *> DeviceSet;
  static DeviceSet *GetDeviceSet()
  {
      static angle::base::NoDestructor<DeviceSet> devices;
      return devices.get();
  }
  
  // Static factory methods
  egl::Error Device::CreateDevice(EGLint deviceType, void *nativeDevice, Device **outDevice)
  {
      *outDevice = nullptr;
  
      std::unique_ptr<rx::DeviceImpl> newDeviceImpl;
  
  #if defined(ANGLE_ENABLE_D3D11)
      if (deviceType == EGL_D3D11_DEVICE_ANGLE)
      {
          newDeviceImpl.reset(new rx::Device11(nativeDevice));
      }
  #endif
  
      // Note that creating an EGL device from inputted D3D9 parameters isn't currently supported
  
      if (newDeviceImpl == nullptr)
      {
          return egl::Error(EGL_BAD_ATTRIBUTE);
      }
  
      ANGLE_TRY(newDeviceImpl->initialize());
      *outDevice = new Device(nullptr, newDeviceImpl.release());
  
      return NoError();
  }
  
  bool Device::IsValidDevice(const Device *device)
  {
      const DeviceSet *deviceSet = GetDeviceSet();
      return deviceSet->find(const_cast<Device *>(device)) != deviceSet->end();
  }
  
  Device::Device(Display *owningDisplay, rx::DeviceImpl *impl)
      : mLabel(nullptr), mOwningDisplay(owningDisplay), mImplementation(impl)
  {
      ASSERT(GetDeviceSet()->find(this) == GetDeviceSet()->end());
      GetDeviceSet()->insert(this);
      initDeviceExtensions();
  }
  
  Device::~Device()
  {
      ASSERT(GetDeviceSet()->find(this) != GetDeviceSet()->end());
      GetDeviceSet()->erase(this);
  }
  
  void Device::setLabel(EGLLabelKHR label)
  {
      mLabel = label;
  }
  
  EGLLabelKHR Device::getLabel() const
  {
      return mLabel;
  }
  
  Error Device::getAttribute(EGLint attribute, EGLAttrib *value)
  {
      void *nativeAttribute = nullptr;
      egl::Error error =
          getImplementation()->getAttribute(getOwningDisplay(), attribute, &nativeAttribute);
      *value = reinterpret_cast<EGLAttrib>(nativeAttribute);
      return error;
  }
  
  void Device::initDeviceExtensions()
  {
      mImplementation->generateExtensions(&mDeviceExtensions);
      mDeviceExtensionString = GenerateExtensionsString(mDeviceExtensions);
  }
  
  const DeviceExtensions &Device::getExtensions() const
  {
      return mDeviceExtensions;
  }
  
  const std::string &Device::getExtensionString() const
  {
      return mDeviceExtensionString;
  }
  
  const std::string &Device::getDeviceString(EGLint name)
  {
      if (mDeviceStrings.find(name) == mDeviceStrings.end())
      {
          mDeviceStrings.emplace(name, mImplementation.get()->getDeviceString(name));
      }
  
      return mDeviceStrings.find(name)->second;
  }
  }  // namespace egl
  

Download