kc3-lang/angle/include/platform/Feature.h

• Show log

  Commit

• Hash : 9592b970
  Author :
  Date : 2025-02-21T12:33:57
  

  Move LogFeatureStatus() into overrideFeatures()
  
  Both overrideFeatures() and LogFeatureStatus() a looping through the
  overridden features the same way, with one applying the feature override
  and the other logging the feature being overridden.
  
  Rather than looping twice, build up the feature override log string
  concurrently in overrideFeatures() and return the string, which can be
  logged (or not).
  
  Bug: b/372694741
  Change-Id: I70b06792046fe80057f45cefaf18bdd3d05f1f21
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288657
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Cody Northrop <cnorthrop@google.com>
  Commit-Queue: Tim Van Patten <timvp@google.com>
  

Download

• include/platform/Feature.h

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // Feature.h: Definition of structs to hold feature/workaround information.
  //
  
  #ifndef ANGLE_PLATFORM_FEATURE_H_
  #define ANGLE_PLATFORM_FEATURE_H_
  
  #include <map>
  #include <string>
  #include <vector>
  
  #define ANGLE_FEATURE_CONDITION(set, feature, cond)           \
      do                                                        \
      {                                                         \
          if (!(set)->feature.hasOverride)                      \
          {                                                     \
              (set)->feature.enabled   = cond;                  \
          }                                                     \
      } while (0)
  
  namespace angle
  {
  
  enum class FeatureCategory
  {
      FrontendFeatures,
      FrontendWorkarounds,
      OpenGLWorkarounds,
      OpenGLFeatures,
      D3DWorkarounds,
      VulkanFeatures,
      VulkanWorkarounds,
      VulkanAppWorkarounds,
      MetalFeatures,
      MetalWorkarounds,
  };
  
  constexpr char kFeatureCategoryFrontendWorkarounds[]  = "Frontend workarounds";
  constexpr char kFeatureCategoryFrontendFeatures[]     = "Frontend features";
  constexpr char kFeatureCategoryOpenGLWorkarounds[]    = "OpenGL workarounds";
  constexpr char kFeatureCategoryOpenGLFeatures[]       = "OpenGL features";
  constexpr char kFeatureCategoryD3DWorkarounds[]       = "D3D workarounds";
  constexpr char kFeatureCategoryVulkanAppWorkarounds[] = "Vulkan app workarounds";
  constexpr char kFeatureCategoryVulkanWorkarounds[]    = "Vulkan workarounds";
  constexpr char kFeatureCategoryVulkanFeatures[]       = "Vulkan features";
  constexpr char kFeatureCategoryMetalFeatures[]        = "Metal features";
  constexpr char kFeatureCategoryMetalWorkarounds[]     = "Metal workarounds";
  constexpr char kFeatureCategoryUnknown[]              = "Unknown";
  
  inline const char *FeatureCategoryToString(const FeatureCategory &fc)
  {
      switch (fc)
      {
          case FeatureCategory::FrontendFeatures:
              return kFeatureCategoryFrontendFeatures;
              break;
  
          case FeatureCategory::FrontendWorkarounds:
              return kFeatureCategoryFrontendWorkarounds;
              break;
  
          case FeatureCategory::OpenGLWorkarounds:
              return kFeatureCategoryOpenGLWorkarounds;
              break;
  
          case FeatureCategory::OpenGLFeatures:
              return kFeatureCategoryOpenGLFeatures;
              break;
  
          case FeatureCategory::D3DWorkarounds:
              return kFeatureCategoryD3DWorkarounds;
              break;
  
          case FeatureCategory::VulkanFeatures:
              return kFeatureCategoryVulkanFeatures;
              break;
  
          case FeatureCategory::VulkanWorkarounds:
              return kFeatureCategoryVulkanWorkarounds;
              break;
  
          case FeatureCategory::VulkanAppWorkarounds:
              return kFeatureCategoryVulkanAppWorkarounds;
              break;
  
          case FeatureCategory::MetalFeatures:
              return kFeatureCategoryMetalFeatures;
              break;
  
          case FeatureCategory::MetalWorkarounds:
              return kFeatureCategoryMetalWorkarounds;
              break;
  
          default:
              return kFeatureCategoryUnknown;
              break;
      }
  }
  
  constexpr char kFeatureStatusEnabled[]  = "enabled";
  constexpr char kFeatureStatusDisabled[] = "disabled";
  
  inline const char *FeatureStatusToString(const bool &status)
  {
      if (status)
      {
          return kFeatureStatusEnabled;
      }
      return kFeatureStatusDisabled;
  }
  
  struct FeatureInfo;
  
  using FeatureMap  = std::map<std::string, FeatureInfo *>;
  using FeatureList = std::vector<const FeatureInfo *>;
  
  struct FeatureInfo
  {
      FeatureInfo(const FeatureInfo &other);
      FeatureInfo(const char *name, const FeatureCategory &category, FeatureMap *const mapPtr);
      ~FeatureInfo();
  
      void applyOverride(bool state);
  
      // The name of the workaround
      const char *const name;
  
      // The category that the workaround belongs to. Eg. "Vulkan workarounds"
      const FeatureCategory category;
  
      // Whether the workaround is enabled or not. Determined by heuristics like vendor ID and
      // version, but may be overriden to any value.
      bool enabled = false;
  
      // Whether this feature has an override applied to it, and the condition to
      // enable it should not be checked.
      bool hasOverride = false;
  };
  
  inline FeatureInfo::FeatureInfo(const FeatureInfo &other) = default;
  inline FeatureInfo::FeatureInfo(const char *name,
                                  const FeatureCategory &category,
                                  FeatureMap *const mapPtr)
      : name(name), category(category), enabled(false)
  {
      if (mapPtr != nullptr)
      {
          (*mapPtr)[std::string(name)] = this;
      }
  }
  
  inline FeatureInfo::~FeatureInfo() = default;
  
  struct FeatureSetBase
  {
    public:
      FeatureSetBase();
      ~FeatureSetBase();
  
    private:
      // Non-copyable
      FeatureSetBase(const FeatureSetBase &other)            = delete;
      FeatureSetBase &operator=(const FeatureSetBase &other) = delete;
  
    protected:
      FeatureMap members = FeatureMap();
  
    public:
      void reset();
      std::string overrideFeatures(const std::vector<std::string> &featureNames, bool enabled);
      void populateFeatureList(FeatureList *features) const;
  
      const FeatureMap &getFeatures() const { return members; }
  };
  
  inline FeatureSetBase::FeatureSetBase()  = default;
  inline FeatureSetBase::~FeatureSetBase() = default;
  
  }  // namespace angle
  
  #endif  // ANGLE_PLATFORM_WORKAROUND_H_
  

Download