kc3-lang/angle/src/libANGLE/renderer/null/SurfaceNULL.h

• Show log

  Commit

• Hash : 3cfc0ce2
  Author :
  Date : 2025-03-24T07:41:33
  

  Revert "Vulkan:Dont use Subject/Observer for SwapchainImageChanged"
  
  This reverts commit 48103cb2f2b292cb50cc5a29546b358b2e47fd29.
  
  Reason for revert: assert fails
  https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-test/7085/overview
  I 22:27:33.697   77.533s _RunTestsOnDevice(17221FDF6000A4)  [ RUN      ] EGLAndroidAutoRefreshTest.SwapCPUThrottling/ES3_Vulkan_NoFixture
  INFO:root:ERR: SurfaceVk.cpp:3165 (getCurrentFramebuffer): 	! Assert failed in getCurrentFramebuffer (../../src/libANGLE/renderer/vulkan/SurfaceVk.cpp:3165): mAcquireOperation.state == ImageAcquireState::Ready
  
  Original change's description:
  > Vulkan:Dont use Subject/Observer for SwapchainImageChanged
  >
  > Because we do deferred ANI (VkAcquireNextImage) call until image is
  > needed, we need a way to force Context to go through
  > FramebufferVk::syncState call (FramebufferVk::syncState calls
  > WindowSurfaceVk::getAttachmentRenderTarget, which end up calling ANI.
  > Right now we uses subject/observer mechanism, by sending
  > angle::SubjectMessage::SwapchainImageChanged to all observers of
  > WindowSurfaceVk. In this case it is egl::Surface. Then eglSurface
  > redirects this message to its observers, which are all gl::Framebuffer's
  > attachments: color, depth, stencil. Even though only color attachment
  > needs to be notified, but because we don't have a separate list of
  > observers, depth/stencil attachment also receive the notification and
  > they early out. Then gl::Framebuffer sets
  > DIRTY_BIT_COLOR_BUFFER_CONTENTS_0 dirty bit and send the
  > angle::SubjectMessage::DirtyBitsFlagged to Context, which dirty DrawFBO
  > and ReadFBO and dirty cached state. Note that this is specific for swap
  > image changed case, there is no surface property change (surface
  > property change will still trigger the subject/observer message with
  > SubjectMessage::SubjectChanged message, but this occurs rarely). This
  > gets worse for apps that uses multiple contexts, for the example
  > pokemon_masters_ex has three contexts, each context has its own default
  > frame buffer that attach to the same surface, and we never remove
  > non-current context from the observer list. This end up with
  > egl::Surface has 12 observers and for every frame, it loop over the list
  > of 12 observers and send message (virtual function call) to each of
  > them. Color attachment also ends up sending two messages to Context, one
  > for Read FBO and another for Draw FBO. There are total 21 virtual
  > function calls. Even for single context usage, you have 6 virtual
  > function calls, for every frame.
  >
  > EGL spec says "an EGLSurface must be current on only one thread at a
  > time", any other context must call EGLMakeCurrent in order to use this
  > surface, which will add all necessary dirty bits at that time. So we
  > really only need to notify current context. In this CL,
  > SwapchainImageChanged no longer uses subject/observer mechanism, so this
  > message is removed.
  >
  > This CL still uses subject/observer mechanism to send DirtyBitsFlagged
  > from Framebuffer back to context. We could call setDrawFramebufferDirty
  > and setReadFramebufferDirty directly, but that will require to remove
  > the "const" decoration out of gl::Context which generates too much code
  > diff, so onStateChange(angle::SubjectMessage::DirtyBitsFlagged) is still
  > used.
  >
  > Bug: angleproject:400711938
  > Change-Id: I61354516fd0aa307714b7abd30c6b6e45ff7b496
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6319893
  > Commit-Queue: Charlie Lao <cclao@google.com>
  > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  > Reviewed-by: Yuxin Hu <yuxinhu@google.com>
  
  Bug: angleproject:400711938
  Change-Id: Ib7899d1ac63a1f86af0953a1d25922578c470fc9
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6387755
  Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
  

Download

• src/libANGLE/renderer/null/SurfaceNULL.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // SurfaceNULL.h:
  //    Defines the class interface for SurfaceNULL, implementing SurfaceImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_NULL_SURFACENULL_H_
  #define LIBANGLE_RENDERER_NULL_SURFACENULL_H_
  
  #include "libANGLE/renderer/SurfaceImpl.h"
  
  namespace rx
  {
  
  class SurfaceNULL : public SurfaceImpl
  {
    public:
      SurfaceNULL(const egl::SurfaceState &surfaceState);
      ~SurfaceNULL() override;
  
      egl::Error initialize(const egl::Display *display) override;
      egl::Error swap(const gl::Context *context) override;
      egl::Error postSubBuffer(const gl::Context *context,
                               EGLint x,
                               EGLint y,
                               EGLint width,
                               EGLint height) override;
      egl::Error querySurfacePointerANGLE(EGLint attribute, void **value) override;
      egl::Error bindTexImage(const gl::Context *context,
                              gl::Texture *texture,
                              EGLint buffer) override;
      egl::Error releaseTexImage(const gl::Context *context, EGLint buffer) override;
      egl::Error getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc) override;
      egl::Error getMscRate(EGLint *numerator, EGLint *denominator) override;
      void setSwapInterval(const egl::Display *display, EGLint interval) override;
  
      // width and height can change with client window resizing
      EGLint getWidth() const override;
      EGLint getHeight() const override;
  
      EGLint isPostSubBufferSupported() const override;
      EGLint getSwapBehavior() const override;
  
      angle::Result initializeContents(const gl::Context *context,
                                       GLenum binding,
                                       const gl::ImageIndex &imageIndex) override;
  
      egl::Error attachToFramebuffer(const gl::Context *context,
                                     gl::Framebuffer *framebuffer) override;
      egl::Error detachFromFramebuffer(const gl::Context *context,
                                       gl::Framebuffer *framebuffer) override;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_NULL_SURFACENULL_H_
  

Download