-
Show log
Commit
-
Hash : 928c5016
Author :
Date : 2022-08-04T12:28:12
Vulkan: Fix garbage collection vs outside-RP-only flush In https://chromium-review.googlesource.com/c/angle/angle/+/3379231, an optimization was implemented such that the excessive recorded texture uploads would get flushed early and submitted. This caused a use-after-free bug in the following situation: * Draw with pipeline A * Delete A <--- this puts A in the Context garbage list * Upload a lot of data At this point, the flush threshold could pass and the commands recorded outside of the render pass up to this point would be submitted. Associated with this submission was the current garbage, including pipeline A. However, the render pass that uses pipeline A is still not submitted. Now if after some time the render pass is still open, but the "completed commands" are checked (another set of uploads causing another submission, a query status check, etc), the garbage can be cleaned up. When the render pass closes next and is submitted, the implementation attempts to use the pipeline, which is already deleted. In this change, outside-render-pass-only submissions no longer reference the current garbage. This has the side effect that the temporary buffers used for uploading texture data won't be released early. A future optimization may want to separate the garbage list in ContextVk to render pass and outside render pass garbage. Bug: chromium:1337538 Change-Id: I4d31edc53916785d44420f4d6b4b2578ca3996e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812555 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
-
Files
- ActiveTextureCacheTest.cpp
- AtomicCounterBufferTest.cpp
- AttributeLayoutTest.cpp
- BPTCCompressedTextureTest.cpp
- BindGeneratesResourceTest.cpp
- BindUniformLocationTest.cpp
- BlendFuncExtendedTest.cpp
- BlendIntegerTest.cpp
- BlendMinMaxTest.cpp
- BlendPackedTest.cpp
- BlitFramebufferANGLETest.cpp
- BufferDataTest.cpp
- BuiltinVariableTest.cpp
- ClearTest.cpp
- ClientArraysTest.cpp
- ClipDistanceTest.cpp
- ColorMaskTest.cpp
- CompressedTextureFormatsTest.cpp
- ComputeShaderTest.cpp
- ContextLostTest.cpp
- ContextNoErrorTest.cpp
- CopyCompressedTextureTest.cpp
- CopyTexImageTest.cpp
- CopyTexture3DTest.cpp
- CopyTextureTest.cpp
- CubeMapTextureTest.cpp
- D3D11EmulatedIndexedBufferTest.cpp
- D3D11FormatTablesTest.cpp
- D3D11InputLayoutCacheTest.cpp
- D3DImageFormatConversionTest.cpp
- D3DTextureTest.cpp
- DXT1CompressedTextureTest.cpp
- DXTSRGBCompressedTextureTest.cpp
- DXTSRGBCompressedTextureTestData.inl
- DebugMarkerTest.cpp
- DebugTest.cpp
- DepthStencilFormatsTest.cpp
- DepthStencilTest.cpp
- DesktopGLSLTest.cpp
- DifferentStencilMasksTest.cpp
- DiscardFramebufferEXTTest.cpp
- DrawBaseVertexBaseInstanceTest.cpp
- DrawBaseVertexVariantsTest.cpp
- DrawBuffersTest.cpp
- DrawElementsTest.cpp
- ETCTextureTest.cpp
- ErrorMessages.cpp
- ExternalBufferTest.cpp
- ExternalWrapTest.cpp
- FenceSyncTests.cpp
- FloatingPointSurfaceTest.cpp
- FormatPrintTest.cpp
- FragDepthTest.cpp
- FramebufferFetchTest.cpp
- FramebufferMixedSamplesTest.cpp
- FramebufferMultiviewTest.cpp
- FramebufferRenderMipmapTest.cpp
- FramebufferTest.cpp
- GLSLTest.cpp
- GeometryShaderTest.cpp
- GetImageTest.cpp
- GetTexLevelParameterTest.cpp
- ImageTest.cpp
- ImageTestMetal.mm
- IncompleteTextureTest.cpp
- IndexBufferOffsetTest.cpp
- IndexedPointsTest.cpp
- InstancingTest.cpp
- KTXCompressedTextureTest.cpp
- LineLoopTest.cpp
- LinkAndRelinkTest.cpp
- MatrixTest.cpp
- MaxTextureSizeTest.cpp
- MemoryBarrierTest.cpp
- MemoryObjectTest.cpp
- MemorySizeTest.cpp
- MipmapTest.cpp
- MultiDrawTest.cpp
- MultisampleCompatibilityTest.cpp
- MultisampleTest.cpp
- MultisampledRenderToTextureTest.cpp
- MultithreadingTest.cpp
- MultiviewDrawTest.cpp
- ObjectAllocationTest.cpp
- OcclusionQueriesTest.cpp
- PBOExtensionTest.cpp
- PackUnpackTest.cpp
- ParallelShaderCompileTest.cpp
- PbufferTest.cpp
- PixelLocalStorageTest.cpp
- PixmapTest.cpp
- PointSpritesTest.cpp
- ProgramBinaryTest.cpp
- ProgramInterfaceTest.cpp
- ProgramParameterTest.cpp
- ProgramPipelineTest.cpp
- ProvokingVertexTest.cpp
- QueryObjectValidation.cpp
- ReadOnlyFeedbackLoopTest.cpp
- ReadPixelsTest.cpp
- RenderbufferMultisampleTest.cpp
- RendererTest.cpp
- RequestExtensionTest.cpp
- RobustBufferAccessBehaviorTest.cpp
- RobustClientMemoryTest.cpp
- RobustFragmentShaderOutputTest.cpp
- RobustResourceInitTest.cpp
- S3TCTextureSizesTest.cpp
- SRGBFramebufferTest.cpp
- SRGBTextureTest.cpp
- SamplersTest.cpp
- SemaphoreTest.cpp
- ShaderInterpTest.cpp
- ShaderNonConstGlobalInitializerTest.cpp
- ShaderStorageBufferTest.cpp
- ShadingRateQcomTest.cpp
- SimpleOperationTest.cpp
- SixteenBppTextureTest.cpp
- StateChangeTest.cpp
- SwizzleTest.cpp
- SyncQueriesTest.cpp
- TextureExternalUpdateTest.cpp
- TextureFilteringHintTest.cpp
- TextureMultisampleTest.cpp
- TextureRectangleTest.cpp
- TextureTest.cpp
- TextureUploadFormatTest.cpp
- TimerQueriesTest.cpp
- TransformFeedbackTest.cpp
- UniformBufferTest.cpp
- UniformTest.cpp
- UnpackAlignmentTest.cpp
- UnpackRowLength.cpp
- VertexAttributeTest.cpp
- ViewportTest.cpp
- VulkanDescriptorSetTest.cpp
- VulkanExternalImageTest.cpp
- VulkanFormatTablesTest.cpp
- VulkanFramebufferTest.cpp
- VulkanImageTest.cpp
- VulkanMultithreadingTest.cpp
- VulkanPerformanceCounterTest.cpp
- VulkanUniformUpdatesTest.cpp
- WEBGLVideoTextureTest.cpp
- WebGLCompatibilityTest.cpp
- WebGLCompressedTextureAvailabilityTest.cpp
- WebGLFramebufferTest.cpp
- WebGLReadOutsideFramebufferTest.cpp
- gles1/
- media/
