kc3-lang/angle/src/libANGLE/VertexArray.h

• Show log

  Commit

• Hash : 52b09c2f
  Author :
  Date : 2016-04-11T14:12:31
  

  Re-re-land "D3D11: Implement dirty bits for VertexArray11.""
  
  Translated attributes are now stored in the VertexArray11 in a cache,
  and only updated when dirty bits change. Currently dynamic attributes
  must be re-translated every call, so these are stored in a list and
  processed repeatedly.
  
  This skips doing a lot of the VertexDataManager work for vertex
  attributes that don't change between draw calls.
  
  Current value attributes, which correspond to disabled attributes that
  the program will pulls vertex data from, are owned by the Context, so
  these need to be handled outside of the VertexArray11.
  
  Further changes will be necessary to reduce the redundant work we do in
  the InputLayoutCache. We shouldn't need to re-check the cache if
  nothing relevant changed.
  
  This give about a 23% performance improvement on the draw call
  benchmark on my machine.
  
  Re-land with a fix for the start vertex offset.
  
  Re-re-land with a fix for using XFB with deleted buffers.
  
  BUG=angleproject:1327
  
  Change-Id: I0fba49515375c149bbf54d933f8d1f747fbb8158
  Reviewed-on: https://chromium-review.googlesource.com/338003
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/VertexArray.h

• //
  // Copyright (c) 2013 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // This class contains prototypes for representing GLES 3 Vertex Array Objects:
  //
  //   The buffer objects that are to be used by the vertex stage of the GL are collected
  //   together to form a vertex array object. All state related to the definition of data used
  //   by the vertex processor is encapsulated in a vertex array object.
  //
  
  #ifndef LIBANGLE_VERTEXARRAY_H_
  #define LIBANGLE_VERTEXARRAY_H_
  
  #include "libANGLE/RefCountObject.h"
  #include "libANGLE/Constants.h"
  #include "libANGLE/Debug.h"
  #include "libANGLE/State.h"
  #include "libANGLE/VertexAttribute.h"
  
  #include <vector>
  
  namespace rx
  {
  class ImplFactory;
  class VertexArrayImpl;
  }
  
  namespace gl
  {
  class Buffer;
  
  class VertexArray final : public LabeledObject
  {
    public:
      VertexArray(rx::ImplFactory *factory, GLuint id, size_t maxAttribs);
      ~VertexArray();
  
      GLuint id() const;
  
      void setLabel(const std::string &label) override;
      const std::string &getLabel() const override;
  
      const VertexAttribute &getVertexAttribute(size_t attributeIndex) const;
  
      void detachBuffer(GLuint bufferName);
      void setVertexAttribDivisor(size_t index, GLuint divisor);
      void enableAttribute(size_t attributeIndex, bool enabledState);
      void setAttributeState(size_t attributeIndex, gl::Buffer *boundBuffer, GLint size, GLenum type,
                             bool normalized, bool pureInteger, GLsizei stride, const void *pointer);
  
      void setElementArrayBuffer(Buffer *buffer);
  
      const BindingPointer<Buffer> &getElementArrayBuffer() const { return mData.getElementArrayBuffer(); }
      size_t getMaxAttribs() const { return mData.getVertexAttributes().size(); }
      const std::vector<VertexAttribute> &getVertexAttributes() const { return mData.getVertexAttributes(); }
  
      rx::VertexArrayImpl *getImplementation() { return mVertexArray; }
      const rx::VertexArrayImpl *getImplementation() const { return mVertexArray; }
  
      size_t getMaxEnabledAttribute() const { return mData.getMaxEnabledAttribute(); }
  
      class Data final : public angle::NonCopyable
      {
        public:
          explicit Data(size_t maxAttribs);
          ~Data();
  
          const std::string &getLabel() const { return mLabel; }
  
          const BindingPointer<Buffer> &getElementArrayBuffer() const { return mElementArrayBuffer; }
          size_t getMaxAttribs() const { return mVertexAttributes.size(); }
          size_t getMaxEnabledAttribute() const { return mMaxEnabledAttribute; }
          const std::vector<VertexAttribute> &getVertexAttributes() const { return mVertexAttributes; }
          const VertexAttribute &getVertexAttribute(size_t index) const
          {
              return mVertexAttributes[index];
          }
  
        private:
          friend class VertexArray;
          std::string mLabel;
          std::vector<VertexAttribute> mVertexAttributes;
          BindingPointer<Buffer> mElementArrayBuffer;
          size_t mMaxEnabledAttribute;
      };
  
      enum DirtyBitType
      {
          DIRTY_BIT_ELEMENT_ARRAY_BUFFER,
  
          // Reserve bits for enabled flags
          DIRTY_BIT_ATTRIB_0_ENABLED,
          DIRTY_BIT_ATTRIB_MAX_ENABLED = DIRTY_BIT_ATTRIB_0_ENABLED + gl::MAX_VERTEX_ATTRIBS,
  
          // Reserve bits for attrib pointers
          DIRTY_BIT_ATTRIB_0_POINTER   = DIRTY_BIT_ATTRIB_MAX_ENABLED,
          DIRTY_BIT_ATTRIB_MAX_POINTER = DIRTY_BIT_ATTRIB_0_POINTER + gl::MAX_VERTEX_ATTRIBS,
  
          // Reserve bits for divisors
          DIRTY_BIT_ATTRIB_0_DIVISOR   = DIRTY_BIT_ATTRIB_MAX_POINTER,
          DIRTY_BIT_ATTRIB_MAX_DIVISOR = DIRTY_BIT_ATTRIB_0_DIVISOR + gl::MAX_VERTEX_ATTRIBS,
  
          DIRTY_BIT_UNKNOWN = DIRTY_BIT_ATTRIB_MAX_DIVISOR,
          DIRTY_BIT_MAX     = DIRTY_BIT_UNKNOWN,
      };
  
      typedef std::bitset<DIRTY_BIT_MAX> DirtyBits;
  
      void syncImplState();
      bool hasAnyDirtyBit() const { return mDirtyBits.any(); }
  
    private:
      GLuint mId;
  
      Data mData;
      DirtyBits mDirtyBits;
  
      rx::VertexArrayImpl *mVertexArray;
  };
  
  }
  
  #endif // LIBANGLE_VERTEXARRAY_H_
  

Download