kc3-lang/angle/src/compiler/translator/tree_ops/vulkan/RemoveInactiveInterfaceVariables.h

• Show log

  Commit

• Hash : daeac238
  Author :
  Date : 2021-05-08T22:09:38
  

  Translator: Ensure structs and blocks are uniquely defined
  
  A new AST validation is added to ensure that the same TStructure or
  TInterfaceBlock is not redundantly defined.  This helps with SPIR-V
  generation by allowing the id to be used as key in a hash map that looks
  up the corresponding SPIR-V type id.
  
  A bug is fixed where the Vulkan driver uniform declaration created two
  identical declarations for ANGLEDepthRangeParams.
  
  A number of other bugs are also fixed in this change, where if a
  variable declaration is eliminated (for example due to constant folding,
  or inactive interface variable removal) and it contained a struct
  specifier, the struct declaration was also removed.  OutputGLSLBase had
  a hack where structs were declared on first encounter, which was
  incorrect as the scope of the declaration could change.  Those bugs are
  fixed and this hack is removed.
  
  Bug: angleproject:2733
  Bug: angleproject:4889
  Bug: angleproject:5936
  Change-Id: I8e13748c0bf552ae8b052249282769a1f0775603
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2881942
  Reviewed-by: Charlie Lao <cclao@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/tree_ops/vulkan/RemoveInactiveInterfaceVariables.h

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // RemoveInactiveInterfaceVariables.h:
  //  Drop shader interface variable declarations for those that are inactive.  This step needs to be
  //  done after CollectVariables.  This avoids having to emulate them (e.g. atomic counters for
  //  Vulkan) or remove them in glslang wrapper (again, for Vulkan).
  //
  //  Shouldn't be run for the GL backend, as it queries shader interface variables from GL itself,
  //  instead of relying on what was gathered during CollectVariables.
  //
  
  #ifndef COMPILER_TRANSLATOR_TREEOPS_VULKAN_REMOVEINACTIVEVARIABLES_H_
  #define COMPILER_TRANSLATOR_TREEOPS_VULKAN_REMOVEINACTIVEVARIABLES_H_
  
  #include "common/angleutils.h"
  
  namespace sh
  {
  
  struct InterfaceBlock;
  struct ShaderVariable;
  class TCompiler;
  class TIntermBlock;
  class TSymbolTable;
  
  ANGLE_NO_DISCARD bool RemoveInactiveInterfaceVariables(
      TCompiler *compiler,
      TIntermBlock *root,
      TSymbolTable *symbolTable,
      const std::vector<sh::ShaderVariable> &attributes,
      const std::vector<sh::ShaderVariable> &inputVaryings,
      const std::vector<sh::ShaderVariable> &outputVariables,
      const std::vector<sh::ShaderVariable> &uniforms,
      const std::vector<sh::InterfaceBlock> &interfaceBlocks);
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_TREEOPS_VULKAN_REMOVEINACTIVEVARIABLES_H_
  

Download