Hash :
e41cbdb5
Author :
Date :
2025-02-26T17:51:06
Complete the implementation of GL_EXT_buffer_storage Currently, glBufferStorageEXT doesn't set buffer usage to DYNAMIC_DRAW. Also, validation of glGetBufferParameter* misses check for GL_BUFFER_IMMUTABLE_STORAGE_EXT and GL_BUFFER_STORAGE_FLAGS_EXT. This patch fixes these issues. Also, an end2end test is added. Bug: angleproject:399689628 Change-Id: Iecf6bd921f4fff849a5f059adf40043d08edfb7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6312515 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
//
// Copyright 2020 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// BufferImpl.cpp: Implementation methods rx::BufferImpl class.
#include "libANGLE/renderer/BufferImpl.h"
namespace rx
{
angle::Result BufferImpl::getSubData(const gl::Context *context,
GLintptr offset,
GLsizeiptr size,
void *outData)
{
UNREACHABLE();
return angle::Result::Stop;
}
angle::Result BufferImpl::setDataWithUsageFlags(const gl::Context *context,
gl::BufferBinding target,
GLeglClientBufferEXT clientBuffer,
const void *data,
size_t size,
gl::BufferUsage usage,
GLbitfield flags,
gl::BufferStorage bufferStorage)
{
return setData(context, target, data, size, usage);
}
angle::Result BufferImpl::onLabelUpdate(const gl::Context *context)
{
return angle::Result::Continue;
}
} // namespace rx