kc3-lang/angle/src/libANGLE/renderer/DisplayImpl.cpp

• Show log

  Commit

• Hash : cfb430c8
  Author :
  Date : 2025-02-10T13:19:05
  

  Remove angle::ErrorStream helper
  
  Most uses of the helper either use just the code or a fixed string,
  which compiles to a few instructions. Using this helper adds 200+ bytes
  of assembly to each use, due to the unneeded instantiation of
  ostringstream which allocates a buffer etc. The combined effect of this
  CL on an Android perf build is ~12KB (0.2%) reduction in size.
  
  The cases where the message is actually formatted are converted to an
  explicit use of ostringstream. Removing the helper so that the new code
  is explicit about the intent to use ostringstream, or an alternative way
  to format the message.
  
  Discovered accidentally while looking into size reduction due to
  __builtin_unreachable()
  
  Semi-automated code change, risk of copy-paste mistakes should be
  minimal.
  
  Bug: angleproject:394129077
  Change-Id: I47c2642d750d31416b08a1cfa435d5463c294e35
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6250078
  Commit-Queue: Roman Lavrov <romanl@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  

Download

• src/libANGLE/renderer/DisplayImpl.cpp

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // DisplayImpl.cpp: Implementation methods of egl::Display
  
  #include "libANGLE/renderer/DisplayImpl.h"
  
  #include "libANGLE/Display.h"
  #include "libANGLE/Surface.h"
  #include "libANGLE/renderer/DeviceImpl.h"
  
  namespace rx
  {
  namespace
  {
  // For back-ends that do not implement EGLDevice.
  class MockDevice : public DeviceImpl
  {
    public:
      MockDevice() = default;
      egl::Error initialize() override { return egl::NoError(); }
      egl::Error getAttribute(const egl::Display *display, EGLint attribute, void **outValue) override
      {
          UNREACHABLE();
          return egl::Error(EGL_BAD_ATTRIBUTE);
      }
      void generateExtensions(egl::DeviceExtensions *outExtensions) const override
      {
          *outExtensions = egl::DeviceExtensions();
      }
  };
  }  // anonymous namespace
  
  DisplayImpl::DisplayImpl(const egl::DisplayState &state)
      : mState(state), mExtensionsInitialized(false), mCapsInitialized(false), mBlobCache(nullptr)
  {}
  
  DisplayImpl::~DisplayImpl()
  {
      ASSERT(mState.surfaceMap.empty());
  }
  
  egl::Error DisplayImpl::prepareForCall()
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::releaseThread()
  {
      return egl::NoError();
  }
  
  const egl::DisplayExtensions &DisplayImpl::getExtensions() const
  {
      if (!mExtensionsInitialized)
      {
          generateExtensions(&mExtensions);
          mExtensionsInitialized = true;
      }
  
      return mExtensions;
  }
  
  egl::Error DisplayImpl::handleGPUSwitch()
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::forceGPUSwitch(EGLint gpuIDHigh, EGLint gpuIDLow)
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::waitUntilWorkScheduled()
  {
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::validateClientBuffer(const egl::Config *configuration,
                                               EGLenum buftype,
                                               EGLClientBuffer clientBuffer,
                                               const egl::AttributeMap &attribs) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY, "DisplayImpl::validateClientBuffer unimplemented.");
  }
  
  egl::Error DisplayImpl::validateImageClientBuffer(const gl::Context *context,
                                                    EGLenum target,
                                                    EGLClientBuffer clientBuffer,
                                                    const egl::AttributeMap &attribs) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY, "DisplayImpl::validateImageClientBuffer unimplemented.");
  }
  
  egl::Error DisplayImpl::validatePixmap(const egl::Config *config,
                                         EGLNativePixmapType pixmap,
                                         const egl::AttributeMap &attributes) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY, "DisplayImpl::valdiatePixmap unimplemented.");
  }
  
  const egl::Caps &DisplayImpl::getCaps() const
  {
      if (!mCapsInitialized)
      {
          generateCaps(&mCaps);
          mCapsInitialized = true;
      }
  
      return mCaps;
  }
  
  DeviceImpl *DisplayImpl::createDevice()
  {
      return new MockDevice();
  }
  
  angle::NativeWindowSystem DisplayImpl::getWindowSystem() const
  {
      return angle::NativeWindowSystem::Other;
  }
  
  bool DisplayImpl::supportsDmaBufFormat(EGLint format) const
  {
      UNREACHABLE();
      return false;
  }
  
  egl::Error DisplayImpl::queryDmaBufFormats(EGLint max_formats, EGLint *formats, EGLint *num_formats)
  {
      UNREACHABLE();
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::queryDmaBufModifiers(EGLint format,
                                               EGLint max_modifiers,
                                               EGLuint64KHR *modifiers,
                                               EGLBoolean *external_only,
                                               EGLint *num_modifiers)
  {
      UNREACHABLE();
      return egl::NoError();
  }
  
  egl::Error DisplayImpl::querySupportedCompressionRates(const egl::Config *configuration,
                                                         const egl::AttributeMap &attributes,
                                                         EGLint *rates,
                                                         EGLint rate_size,
                                                         EGLint *num_rates) const
  {
      UNREACHABLE();
      return egl::NoError();
  }
  }  // namespace rx
  

Download