kc3-lang/angle/src/libANGLE/Framebuffer.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : Geoff Lang
  Date : 2015-08-11 11:48:03
  Hash : a15472a3
  Message : Fix bugs with drawbuffer state. * IsAttachmentEnabled was checking the wrong draw buffer state. Instead of checking that drawbuffer[colorAttachment] is in use, it should have been scanning for a drawbuffer state that points to colorAttachment. * Allow for maxDrawBuffer != maxColorAttachments. Tested by the GL backend on some systems that don't have the draw buffers extension. Fixed by updating the helpers and adding a new getDrawBuffer helper. BUG=angleproject:1121 Change-Id: Idd1b0a9ec4a3f944d332c708364408bf5d59e1fd Reviewed-on: https://chromium-review.googlesource.com/292740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Tryjob-Request: Geoff Lang <geofflang@chromium.org> Tested-by: Geoff Lang <geofflang@chromium.org>

• src/libANGLE/Framebuffer.h

• //
  // Copyright (c) 2002-2013 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // Framebuffer.h: Defines the gl::Framebuffer class. Implements GL framebuffer
  // objects and related functionality. [OpenGL ES 2.0.24] section 4.4 page 105.
  
  #ifndef LIBANGLE_FRAMEBUFFER_H_
  #define LIBANGLE_FRAMEBUFFER_H_
  
  #include <vector>
  
  #include "common/angleutils.h"
  #include "libANGLE/Constants.h"
  #include "libANGLE/Debug.h"
  #include "libANGLE/Error.h"
  #include "libANGLE/FramebufferAttachment.h"
  #include "libANGLE/RefCountObject.h"
  
  namespace rx
  {
  class ImplFactory;
  class FramebufferImpl;
  class RenderbufferImpl;
  class SurfaceImpl;
  }
  
  namespace egl
  {
  class Surface;
  }
  
  namespace gl
  {
  class Context;
  class Renderbuffer;
  class State;
  class Texture;
  class TextureCapsMap;
  struct Caps;
  struct Data;
  struct Extensions;
  struct ImageIndex;
  struct Rectangle;
  
  class Framebuffer final : public LabeledObject
  {
    public:
  
      class Data final : angle::NonCopyable
      {
        public:
          explicit Data();
          explicit Data(const Caps &caps);
          ~Data();
  
          const std::string &getLabel();
  
          const FramebufferAttachment *getReadAttachment() const;
          const FramebufferAttachment *getFirstColorAttachment() const;
          const FramebufferAttachment *getDepthOrStencilAttachment() const;
          const FramebufferAttachment *getColorAttachment(size_t colorAttachment) const;
          const FramebufferAttachment *getDepthAttachment() const;
          const FramebufferAttachment *getStencilAttachment() const;
          const FramebufferAttachment *getDepthStencilAttachment() const;
  
          const std::vector<GLenum> &getDrawBufferStates() const { return mDrawBufferStates; }
          GLenum getReadBufferState() const { return mReadBufferState; }
          const std::vector<FramebufferAttachment> &getColorAttachments() const { return mColorAttachments; }
  
          bool attachmentsHaveSameDimensions() const;
  
        private:
          friend class Framebuffer;
  
          std::string mLabel;
  
          std::vector<FramebufferAttachment> mColorAttachments;
          FramebufferAttachment mDepthAttachment;
          FramebufferAttachment mStencilAttachment;
  
          std::vector<GLenum> mDrawBufferStates;
          GLenum mReadBufferState;
      };
  
      Framebuffer(const Caps &caps, rx::ImplFactory *factory, GLuint id);
      Framebuffer(rx::SurfaceImpl *surface);
      virtual ~Framebuffer();
  
      void setLabel(const std::string &label) override;
      const std::string &getLabel() const override;
  
      const rx::FramebufferImpl *getImplementation() const { return mImpl; }
      rx::FramebufferImpl *getImplementation() { return mImpl; }
  
      GLuint id() const { return mId; }
  
      void setAttachment(GLenum type,
                         GLenum binding,
                         const ImageIndex &textureIndex,
                         FramebufferAttachmentObject *resource);
      void resetAttachment(GLenum binding);
  
      void detachTexture(GLuint texture);
      void detachRenderbuffer(GLuint renderbuffer);
  
      const FramebufferAttachment *getColorbuffer(size_t colorAttachment) const;
      const FramebufferAttachment *getDepthbuffer() const;
      const FramebufferAttachment *getStencilbuffer() const;
      const FramebufferAttachment *getDepthStencilBuffer() const;
      const FramebufferAttachment *getDepthOrStencilbuffer() const;
      const FramebufferAttachment *getReadColorbuffer() const;
      GLenum getReadColorbufferType() const;
      const FramebufferAttachment *getFirstColorbuffer() const;
  
      const FramebufferAttachment *getAttachment(GLenum attachment) const;
  
      size_t getDrawbufferStateCount() const;
      GLenum getDrawBufferState(size_t drawBuffer) const;
      void setDrawBuffers(size_t count, const GLenum *buffers);
      const FramebufferAttachment *getDrawBuffer(size_t drawBuffer) const;
      bool hasEnabledDrawBuffer() const;
  
      GLenum getReadBufferState() const;
      void setReadBuffer(GLenum buffer);
  
      size_t getNumColorBuffers() const;
      bool hasDepth() const;
      bool hasStencil() const;
      int getSamples(const gl::Data &data) const;
      bool usingExtendedDrawBuffers() const;
  
      GLenum checkStatus(const gl::Data &data) const;
      bool hasValidDepthStencil() const;
  
      Error discard(size_t count, const GLenum *attachments);
      Error invalidate(size_t count, const GLenum *attachments);
      Error invalidateSub(size_t count, const GLenum *attachments, const gl::Rectangle &area);
  
      Error clear(const gl::Data &data, GLbitfield mask);
      Error clearBufferfv(const gl::Data &data,
                          GLenum buffer,
                          GLint drawbuffer,
                          const GLfloat *values);
      Error clearBufferuiv(const gl::Data &data,
                           GLenum buffer,
                           GLint drawbuffer,
                           const GLuint *values);
      Error clearBufferiv(const gl::Data &data, GLenum buffer, GLint drawbuffer, const GLint *values);
      Error clearBufferfi(const gl::Data &data,
                          GLenum buffer,
                          GLint drawbuffer,
                          GLfloat depth,
                          GLint stencil);
  
      GLenum getImplementationColorReadFormat() const;
      GLenum getImplementationColorReadType() const;
      Error readPixels(const gl::State &state,
                       const gl::Rectangle &area,
                       GLenum format,
                       GLenum type,
                       GLvoid *pixels) const;
  
      Error blit(const State &state,
                 const Rectangle &sourceArea,
                 const Rectangle &destArea,
                 GLbitfield mask,
                 GLenum filter,
                 const Framebuffer *sourceFramebuffer);
  
      enum DirtyBitType
      {
          DIRTY_BIT_COLOR_ATTACHMENT_0,
          DIRTY_BIT_COLOR_ATTACHMENT_MAX =
              DIRTY_BIT_COLOR_ATTACHMENT_0 + gl::IMPLEMENTATION_MAX_FRAMEBUFFER_ATTACHMENTS,
          DIRTY_BIT_DEPTH_ATTACHMENT = DIRTY_BIT_COLOR_ATTACHMENT_MAX,
          DIRTY_BIT_STENCIL_ATTACHMENT,
          DIRTY_BIT_DRAW_BUFFERS,
          DIRTY_BIT_READ_BUFFER,
          DIRTY_BIT_UNKNOWN,
          DIRTY_BIT_MAX = DIRTY_BIT_UNKNOWN,
      };
  
      typedef std::bitset<DIRTY_BIT_MAX> DirtyBits;
      bool hasAnyDirtyBit() const { return mDirtyBits.any(); }
  
      void syncState() const;
  
    protected:
      void detachResourceById(GLenum resourceType, GLuint resourceId);
  
      Data mData;
      rx::FramebufferImpl *mImpl;
      GLuint mId;
  
      // TODO(jmadill): See if we can make this non-mutable.
      mutable DirtyBits mDirtyBits;
  };
  
  }
  
  #endif   // LIBANGLE_FRAMEBUFFER_H_