Edit

kc3-lang/angle/src/libANGLE/Image.h

Branch :

  • Show log

    Commit

  • Author : Jamie Madill
    Date : 2017-10-03 09:01:44
    Hash : 05b35b21
    Message : D3D11: Lazy robust resource init. This patch moves the robust resource init logic to the GL front-end. Instead of initializing texture resources immediately on creation in D3D11, it defers the clear until before a draw call in some cases, or skips the update if we can determine if a texture (or other resource) has been fully initialized. Currently lazy init is only implemented for Textures, Renderbuffers, and Surfaces. Various places where lazy resource init is triggered: * Framebuffer operations (Draw, Blit, CopyTexImage, Clear, ReadPixels) * Texture operations (SubImage, GenerateMipmap, CopyTexImage) Some efficiency gains remain to be implemented, such as when a SubImage call fills the entire object. Similarly for Blit, and a few other operations. In these cases we can skip lazy init as an optimization. Edge cases with EGLImage are mostly untested. BUG=angleproject:2107 Change-Id: I2bf3a69b1eae0d4feeb5b17daca23451f1037be8 Reviewed-on: https://chromium-review.googlesource.com/576058 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

  • src/libANGLE/Image.h
  • //
    // Copyright (c) 2015 The ANGLE Project Authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.
    //
    
    // Image.h: Defines the egl::Image class representing the EGLimage object.
    
    #ifndef LIBANGLE_IMAGE_H_
    #define LIBANGLE_IMAGE_H_
    
    #include "common/angleutils.h"
    #include "libANGLE/AttributeMap.h"
    #include "libANGLE/Error.h"
    #include "libANGLE/FramebufferAttachment.h"
    #include "libANGLE/RefCountObject.h"
    #include "libANGLE/formatutils.h"
    
    #include <set>
    
    namespace rx
    {
    class EGLImplFactory;
    class ImageImpl;
    }
    
    namespace egl
    {
    class Image;
    
    // Only currently Renderbuffers and Textures can be bound with images. This makes the relationship
    // explicit, and also ensures that an image sibling can determine if it's been initialized or not,
    // which is important for the robust resource init extension with Textures and EGLImages.
    class ImageSibling : public gl::RefCountObject, public gl::FramebufferAttachmentObject
    {
      public:
        ImageSibling(GLuint id);
        virtual ~ImageSibling();
    
        bool isEGLImageTarget() const;
        gl::InitState sourceEGLImageInitState() const;
        void setSourceEGLImageInitState(gl::InitState initState) const;
    
      protected:
        // Set the image target of this sibling
        void setTargetImage(const gl::Context *context, egl::Image *imageTarget);
    
        // Orphan all EGL image sources and targets
        gl::Error orphanImages(const gl::Context *context);
    
      private:
        friend class Image;
    
        // Called from Image only to add a new source image
        void addImageSource(egl::Image *imageSource);
    
        // Called from Image only to remove a source image when the Image is being deleted
        void removeImageSource(egl::Image *imageSource);
    
        std::set<Image *> mSourcesOf;
        gl::BindingPointer<Image> mTargetOf;
    };
    
    struct ImageState : private angle::NonCopyable
    {
        ImageState(EGLenum target, ImageSibling *buffer, const AttributeMap &attribs);
    
        gl::ImageIndex imageIndex;
        gl::BindingPointer<ImageSibling> source;
        std::set<ImageSibling *> targets;
    };
    
    class Image final : public gl::RefCountObject
    {
      public:
        Image(rx::EGLImplFactory *factory,
              EGLenum target,
              ImageSibling *buffer,
              const AttributeMap &attribs);
    
        gl::Error onDestroy(const gl::Context *context) override;
        ~Image();
    
        const gl::Format &getFormat() const;
        size_t getWidth() const;
        size_t getHeight() const;
        size_t getSamples() const;
    
        Error initialize();
    
        rx::ImageImpl *getImplementation() const;
    
        bool orphaned() const;
        gl::InitState sourceInitState() const;
        void setInitState(gl::InitState initState);
    
      private:
        friend class ImageSibling;
    
        // Called from ImageSibling only notify the image that a new target sibling exists for state
        // tracking.
        void addTargetSibling(ImageSibling *sibling);
    
        // Called from ImageSibling only to notify the image that a sibling (source or target) has
        // been respecified and state tracking should be updated.
        gl::Error orphanSibling(const gl::Context *context, ImageSibling *sibling);
    
        ImageState mState;
        rx::ImageImpl *mImplementation;
        bool mOrphanedAndNeedsInit;
    };
    }  // namespace egl
    
    #endif  // LIBANGLE_IMAGE_H_