kc3-lang/angle/src/libANGLE

Diff

• Show log

  Commit

• Hash : afaa1287
  Author :
  Date : 2021-10-26T19:29:44
  

  Vulkan: Don't submit XFB queries when XFB is inactive
  
  Consider the following GL commands:
  
    glBeginQuery(GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN)
    glBeginTransformFeedback()
    glDrawArrays()
    glPauseTransformFeedback()
    glDrawArrays()
    glResumeTransformFeedback()
    glDrawArrays()
    glEndTransformFeedback()
    glEndQuery(GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN)
  
  The renderpass is broken for each of the draw calls, leading to
  pauseRenderPassQueriesIfActive() and resumeRenderPassQueriesIfActive()
  being called when the RP is stopped/started. This leads ANGLE to
  generate 3 TransformFeedbackPrimitivesWritten queries when looping
  through the "active" queries, since no consideration is made for XFB
  actually being active/unpaused.
  
  ARM doesn't support the TransformFeedbackPrimitivesWritten query when
  XFB is disabled. Instead, the query is never completed and the results
  are never available. It could probably be argued that this is an ARM
  bug, and they should just output '0' if XFB isn't active during the
  query.
  
  Regardless, ANGLE shouldn't be issuing the queries when XFB is no
  active, since it's wasteful.
  
  Bug: angleproject:6622
  Test: dEQP.GLES3/functional_transform_feedback*
  Test: TransformFeedbackTest.TransformFeedbackQueryPausedDrawThenResume
  Change-Id: I380fb60405d7f538b802bb0df72bf609f0bc58e9
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3246532
  Reviewed-by: Charlie Lao <cclao@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Tim Van Patten <timvp@google.com>
  

• Files

• AttributeMap.cpp
• AttributeMap.h
• BinaryStream.h
• BinaryStream_unittest.cpp
• BlobCache.cpp
• BlobCache.h
• BlobCache_unittest.cpp
• Buffer.cpp
• Buffer.h
• CLBitField.h
• CLBuffer.cpp
• CLBuffer.h
• CLCommandQueue.cpp
• CLCommandQueue.h
• CLContext.cpp
• CLContext.h
• CLDevice.cpp
• CLDevice.h
• CLEvent.cpp
• CLEvent.h
• CLImage.cpp
• CLImage.h
• CLKernel.cpp
• CLKernel.h
• CLMemory.cpp
• CLMemory.h
• CLObject.cpp
• CLObject.h
• CLPlatform.cpp
• CLPlatform.h
• CLProgram.cpp
• CLProgram.h
• CLRefPointer.h
• CLSampler.cpp
• CLSampler.h
• CLtypes.h
• Caps.cpp
• Caps.h
• Compiler.cpp
• Compiler.h
• Config.cpp
• Config.h
• Config_unittest.cpp
• Constants.h
• Context.cpp
• Context.h
• Context.inl.h
• Context_gl.cpp
• Context_gl_1_autogen.h
• Context_gl_2_autogen.h
• Context_gl_3_autogen.h
• Context_gl_4_autogen.h
• Context_gles_1_0.cpp
• Context_gles_1_0_autogen.h
• Context_gles_2_0_autogen.h
• Context_gles_3_0_autogen.h
• Context_gles_3_1_autogen.h
• Context_gles_3_2_autogen.h
• Context_gles_ext_autogen.h
• Debug.cpp
• Debug.h
• Device.cpp
• Device.h
• Display.cpp
• Display.h
• EGLSync.cpp
• EGLSync.h
• Error.cpp
• Error.h
• Error.inc
• ErrorStrings.h
• Fence.cpp
• Fence.h
• Fence_unittest.cpp
• Framebuffer.cpp
• Framebuffer.h
• FramebufferAttachment.cpp
• FramebufferAttachment.h
• GLES1Renderer.cpp
• GLES1Renderer.h
• GLES1Shaders.inc
• GLES1State.cpp
• GLES1State.h
• HandleAllocator.cpp
• HandleAllocator.h
• HandleAllocator_unittest.cpp
• Image.cpp
• Image.h
• ImageIndex.cpp
• ImageIndex.h
• ImageIndexIterator_unittest.cpp
• Image_unittest.cpp
• IndexRangeCache.cpp
• IndexRangeCache.h
• InfoLog.h
• LoggingAnnotator.cpp
• LoggingAnnotator.h
• MemoryObject.cpp
• MemoryObject.h
• MemoryProgramCache.cpp
• MemoryProgramCache.h
• Observer.cpp
• Observer.h
• Observer_unittest.cpp
• Overlay.cpp
• Overlay.h
• OverlayWidgets.cpp
• OverlayWidgets.h
• Overlay_autogen.cpp
• Overlay_autogen.h
• Overlay_font_autogen.cpp
• Overlay_font_autogen.h
• Platform.cpp
• Program.cpp
• Program.h
• ProgramExecutable.cpp
• ProgramExecutable.h
• ProgramLinkedResources.cpp
• ProgramLinkedResources.h
• ProgramPipeline.cpp
• ProgramPipeline.h
• Program_unittest.cpp
• Query.cpp
• Query.h
• RefCountObject.h
• Renderbuffer.cpp
• Renderbuffer.h
• ResourceManager.cpp
• ResourceManager.h
• ResourceManager_unittest.cpp
• ResourceMap.h
• ResourceMap_unittest.cpp
• Sampler.cpp
• Sampler.h
• Semaphore.cpp
• Semaphore.h
• Shader.cpp
• Shader.h
• SizedMRUCache.h
• SizedMRUCache_unittest.cpp
• State.cpp
• State.h
• Stream.cpp
• Stream.h
• Surface.cpp
• Surface.h
• Surface_unittest.cpp
• Texture.cpp
• Texture.h
• Thread.cpp
• Thread.h
• TransformFeedback.cpp
• TransformFeedback.h
• TransformFeedback_unittest.cpp
• Uniform.cpp
• Uniform.h
• VaryingPacking.cpp
• VaryingPacking.h
• VaryingPacking_unittest.cpp
• Version.h
• Version.inc
• VertexArray.cpp
• VertexArray.h
• VertexArray_unittest.cpp
• VertexAttribute.cpp
• VertexAttribute.h
• VertexAttribute.inc
• WorkerThread.cpp
• WorkerThread.h
• WorkerThread_unittest.cpp
• angletypes.cpp
• angletypes.h
• angletypes.inc
• angletypes_unittest.cpp
• capture/
• cl_utils.cpp
• cl_utils.h
• entry_points_utils.h
• es3_copy_conversion_formats.json
• es3_copy_conversion_table_autogen.cpp
• es3_format_type_combinations.json
• features.h
• format_map_autogen.cpp
• format_map_data.json
• format_map_desktop.cpp
• formatutils.cpp
• formatutils.h
• gen_copy_conversion_table.py
• gen_extensions.py
• gen_format_map.py
• gen_overlay_fonts.py
• gen_overlay_widgets.py
• gles_extensions_autogen.cpp
• gles_extensions_autogen.h
• histogram_macros.h
• overlay/
• overlay_widgets.json
• queryconversions.cpp
• queryconversions.h
• queryutils.cpp
• queryutils.h
• renderer/
• trace.h
• validationCL.cpp
• validationCL.h
• validationCL_autogen.h
• validationEGL.cpp
• validationEGL.h
• validationEGL_autogen.h
• validationES.cpp
• validationES.h
• validationES1.cpp
• validationES1.h
• validationES1_autogen.h
• validationES2.cpp
• validationES2.h
• validationES2_autogen.h
• validationES3.cpp
• validationES3.h
• validationES31.cpp
• validationES31.h
• validationES31_autogen.h
• validationES32.cpp
• validationES32.h
• validationES32_autogen.h
• validationES3_autogen.h
• validationESEXT.cpp
• validationESEXT.h
• validationESEXT_autogen.h
• validationGL1.cpp
• validationGL11_autogen.h
• validationGL12_autogen.h
• validationGL13_autogen.h
• validationGL14_autogen.h
• validationGL15_autogen.h
• validationGL1_autogen.h
• validationGL2.cpp
• validationGL21_autogen.h
• validationGL2_autogen.h
• validationGL3.cpp
• validationGL31_autogen.h
• validationGL32_autogen.h
• validationGL33_autogen.h
• validationGL3_autogen.h
• validationGL4.cpp
• validationGL41_autogen.h
• validationGL42_autogen.h
• validationGL43_autogen.h
• validationGL44_autogen.h
• validationGL45_autogen.h
• validationGL46_autogen.h
• validationGL4_autogen.h

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags