-
Show log
Commit
-
Hash : afaa1287
Author :
Date : 2021-10-26T19:29:44
Vulkan: Don't submit XFB queries when XFB is inactive Consider the following GL commands: glBeginQuery(GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN) glBeginTransformFeedback() glDrawArrays() glPauseTransformFeedback() glDrawArrays() glResumeTransformFeedback() glDrawArrays() glEndTransformFeedback() glEndQuery(GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN) The renderpass is broken for each of the draw calls, leading to pauseRenderPassQueriesIfActive() and resumeRenderPassQueriesIfActive() being called when the RP is stopped/started. This leads ANGLE to generate 3 TransformFeedbackPrimitivesWritten queries when looping through the "active" queries, since no consideration is made for XFB actually being active/unpaused. ARM doesn't support the TransformFeedbackPrimitivesWritten query when XFB is disabled. Instead, the query is never completed and the results are never available. It could probably be argued that this is an ARM bug, and they should just output '0' if XFB isn't active during the query. Regardless, ANGLE shouldn't be issuing the queries when XFB is no active, since it's wasteful. Bug: angleproject:6622 Test: dEQP.GLES3/functional_transform_feedback* Test: TransformFeedbackTest.TransformFeedbackQueryPausedDrawThenResume Change-Id: I380fb60405d7f538b802bb0df72bf609f0bc58e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3246532 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Files
- BufferImpl.cpp
- BufferImpl.h
- BufferImpl_mock.h
- CLCommandQueueImpl.cpp
- CLCommandQueueImpl.h
- CLContextImpl.cpp
- CLContextImpl.h
- CLDeviceImpl.cpp
- CLDeviceImpl.h
- CLEventImpl.cpp
- CLEventImpl.h
- CLExtensions.cpp
- CLExtensions.h
- CLKernelImpl.cpp
- CLKernelImpl.h
- CLMemoryImpl.cpp
- CLMemoryImpl.h
- CLPlatformImpl.cpp
- CLPlatformImpl.h
- CLProgramImpl.cpp
- CLProgramImpl.h
- CLSamplerImpl.cpp
- CLSamplerImpl.h
- CLtypes.h
- CompilerImpl.h
- ContextImpl.cpp
- ContextImpl.h
- DeviceImpl.cpp
- DeviceImpl.h
- DisplayImpl.cpp
- DisplayImpl.h
- EGLImplFactory.h
- EGLReusableSync.cpp
- EGLReusableSync.h
- EGLSyncImpl.cpp
- EGLSyncImpl.h
- FenceNVImpl.h
- Format.h
- FormatID_autogen.h
- Format_table_autogen.cpp
- FramebufferAttachmentObjectImpl.h
- FramebufferImpl.h
- FramebufferImpl_mock.h
- GLImplFactory.h
- ImageImpl.h
- ImageImpl_mock.h
- MemoryObjectImpl.h
- OverlayImpl.h
- ProgramImpl.h
- ProgramImpl_mock.h
- ProgramPipelineImpl.cpp
- ProgramPipelineImpl.h
- QueryImpl.cpp
- QueryImpl.h
- README.md
- RenderTargetCache.h
- RenderbufferImpl.h
- RenderbufferImpl_mock.h
- SamplerImpl.h
- SemaphoreImpl.h
- ShaderImpl.cpp
- ShaderImpl.h
- StreamProducerImpl.h
- SurfaceImpl.cpp
- SurfaceImpl.h
- SyncImpl.h
- TextureImpl.cpp
- TextureImpl.h
- TextureImpl_mock.h
- TransformFeedbackImpl.h
- TransformFeedbackImpl_mock.h
- VertexArrayImpl.h
- angle_format.py
- angle_format_data.json
- angle_format_map.json
- cl/
- copyvertex.h
- copyvertex.inc.h
- d3d/
- d3d_format.cpp
- d3d_format.h
- driver_utils.cpp
- driver_utils.h
- driver_utils_ios.mm
- driver_utils_mac.mm
- dxgi_format_data.json
- dxgi_format_map.h
- dxgi_format_map_autogen.cpp
- dxgi_support_data.json
- dxgi_support_table.h
- dxgi_support_table_autogen.cpp
- gen_angle_format_table.py
- gen_dxgi_format_table.py
- gen_dxgi_support_tables.py
- gen_load_functions_table.py
- gen_load_texture_border_functions_table.py
- gl/
- glslang_wrapper_utils.cpp
- glslang_wrapper_utils.h
- load_functions_data.json
- load_functions_table.h
- load_functions_table_autogen.cpp
- load_texture_border_functions_data.json
- load_texture_border_functions_table.h
- load_texture_border_functions_table_autogen.cpp
- metal/
- null/
- renderer_utils.cpp
- renderer_utils.h
- serial_utils.h
- serial_utils_unittest.cpp
- vulkan/
-
README.md
-
ANGLE back-ends
This folder contains shared back-end-specific implementation files. The classes and types in
rendererare not specified by GLES. They instead are common to all the various ANGLE implementations.See
renderer_utils.hfor various cross back-end utilties.ANGLE Formats
The ANGLE format class,
angle::Format, works as a union between GLES and all the various back-end formats. It can represent any type of format in ANGLE. e.g. Formats in Vulkan that don’t exist in GLES, or DXGI formats that don’t exist in GLES, or Windows/Android surface configs that don’t exist anywhere else.The
glInternalFormatmember ofangle::Formatrepresents the “closest” GL format for an ANGLE format. For formats that don’t exist in GLES this will not be exactly what the format represents.The back-ends also define their own format tables. See the Vulkan Format table docs and the [D3D11 format table docs][D23D11FormatDocs].
DXGI Format Info
DXGI formats are used in both the GL and D3D11 back-end. Therefore the generated info table lives in this common shared location.
The DXGI info table is generated by
gen_dxgi_format_table.pyand sources data fromdxgi_format_data.json. The main purpose of the table is to convert from a DXGI format to an ANGLE format, where the ANGLE format should have all the necessary information.