kc3-lang/angle/src/libANGLE/renderer

• Show log

  Commit

• Hash : 8bae2565
  Author :
  Date : 2025-08-22T14:38:23
  

  Vulkan: Improve VertexArrayVk::syncState
  
  VertexArrayVk::syncState often time shows up the biggest single API in
  simpleperf. For example, in tower_of_fantasy it is 7.9% of all CPU time
  in libANGLE. This function also uses macros which made it hard to debug.
  This CL removes the usage of macros which makes code much easier to
  handle. The other real problem is that we are repeatedly calling
  syncDirtyAttrib() function for disabled attributes. This CL breaks the
  dirty bits into bindingDirtyBits and bufferDataDiryBits and
  attribDirtyBits. Only attribDirtyBits will end up doing the actual state
  sync. All other dirty bits will just turn them into attribDirtyBits.
  Also disabled attributes will be looped separately. This simplification
  makes it impossible to have duplicate state syncs since we only call
  sync*Attrib at the end of function.  By splitting syncDirtyAttrib into
  syncDirtyEnabledAttrib/syncDirtyDIsabledAttrib/syncNeedsConversionAttrib,
  we also moved the if check from syncDirtyAttrib (which is called within
  for loop) to syncState.
  
  With this CL, simpleperf shows this function has reduced from 7.9% to
  5.9%.
  
  Bug: b/439073246
  Change-Id: I99b5ff0b34a5992e31541d2e9cd81ff5c9dda716
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876527
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
  Commit-Queue: Charlie Lao <cclao@google.com>
  

• Files

• BufferImpl.cpp
• BufferImpl.h
• BufferImpl_mock.h
• CLCommandQueueImpl.cpp
• CLCommandQueueImpl.h
• CLContextImpl.cpp
• CLContextImpl.h
• CLDeviceImpl.cpp
• CLDeviceImpl.h
• CLEventImpl.cpp
• CLEventImpl.h
• CLExtensions.cpp
• CLExtensions.h
• CLKernelImpl.cpp
• CLKernelImpl.h
• CLMemoryImpl.cpp
• CLMemoryImpl.h
• CLPlatformImpl.cpp
• CLPlatformImpl.h
• CLProgramImpl.cpp
• CLProgramImpl.h
• CLSamplerImpl.cpp
• CLSamplerImpl.h
• CompilerImpl.h
• ContextImpl.cpp
• ContextImpl.h
• DeviceImpl.cpp
• DeviceImpl.h
• DisplayImpl.cpp
• DisplayImpl.h
• EGLImplFactory.h
• EGLReusableSync.cpp
• EGLReusableSync.h
• EGLSyncImpl.cpp
• EGLSyncImpl.h
• FenceNVImpl.h
• Format.h
• FormatID_autogen.h
• Format_table_autogen.cpp
• FramebufferAttachmentObjectImpl.h
• FramebufferImpl.cpp
• FramebufferImpl.h
• FramebufferImpl_mock.h
• GLImplFactory.h
• ImageImpl.cpp
• ImageImpl.h
• ImageImpl_mock.h
• MemoryObjectImpl.h
• OverlayImpl.h
• ProgramExecutableImpl.h
• ProgramImpl.cpp
• ProgramImpl.h
• ProgramImpl_mock.h
• ProgramPipelineImpl.cpp
• ProgramPipelineImpl.h
• QueryImpl.cpp
• QueryImpl.h
• README.md
• RenderTargetCache.h
• RenderbufferImpl.cpp
• RenderbufferImpl.h
• RenderbufferImpl_mock.h
• SamplerImpl.h
• SemaphoreImpl.h
• ShaderImpl.cpp
• ShaderImpl.h
• ShareGroupImpl.h
• StreamProducerImpl.h
• SurfaceImpl.cpp
• SurfaceImpl.h
• SyncImpl.h
• TextureImpl.cpp
• TextureImpl.h
• TextureImpl_mock.h
• TransformFeedbackImpl.cpp
• TransformFeedbackImpl.h
• TransformFeedbackImpl_mock.h
• VertexArrayImpl.cpp
• VertexArrayImpl.h
• angle_cl_format_map.json
• angle_format.py
• angle_format_data.json
• angle_format_map.json
• cl/
• cl_types.h
• copyvertex.h
• copyvertex.inc.h
• d3d/
• d3d_format.cpp
• d3d_format.h
• driver_utils.cpp
• driver_utils.h
• driver_utils_ios.mm
• driver_utils_mac.mm
• dxgi_format_data.json
• dxgi_format_map.h
• dxgi_format_map_autogen.cpp
• dxgi_support_data.json
• dxgi_support_table.h
• dxgi_support_table_autogen.cpp
• gen_angle_format_table.py
• gen_dxgi_format_table.py
• gen_dxgi_support_tables.py
• gen_load_functions_table.py
• gl/
• load_functions_data.json
• load_functions_table.h
• load_functions_table_autogen.cpp
• metal/
• null/
• renderer_utils.cpp
• renderer_utils.h
• serial_utils.h
• serial_utils_unittest.cpp
• vulkan/
• wgpu/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags