kc3-lang/angle/src/common/PoolAlloc_unittest.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/common/PoolAlloc_unittest.cpp

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // PoolAlloc_unittest:
  //   Tests of the PoolAlloc class
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include <gtest/gtest.h>
  
  #include "common/PoolAlloc.h"
  
  namespace angle
  {
  // Verify the public interface of PoolAllocator class
  TEST(PoolAllocatorTest, Interface)
  {
      size_t numBytes               = 1024;
      constexpr uint32_t kTestValue = 0xbaadbeef;
      // Create a default pool allocator and allocate from it
      PoolAllocator poolAllocator;
      void *allocation = poolAllocator.allocate(numBytes);
      // Verify non-zero ptr returned
      EXPECT_NE(nullptr, allocation);
      // Write to allocation to check later
      uint32_t *writePtr = static_cast<uint32_t *>(allocation);
      *writePtr          = kTestValue;
      // Test other allocator creating a new allocation
      {
          PoolAllocator poolAllocator2;
          allocation = poolAllocator2.allocate(numBytes);
          EXPECT_NE(nullptr, allocation);
          // Make an allocation that spans multiple pages
          allocation = poolAllocator2.allocate(10 * 1024);
          // Free previous two allocations.
      }
      // Verify first allocation still has data
      EXPECT_EQ(kTestValue, *writePtr);
      // Make a bunch of allocations
      for (uint32_t i = 0; i < 1000; ++i)
      {
          numBytes   = (rand() % (1024 * 4)) + 1;
          allocation = poolAllocator.allocate(numBytes);
          EXPECT_NE(nullptr, allocation);
          // Write data into full allocation. In debug case if we
          //  overwrite any other allocation we get error.
          memset(allocation, 0xb8, numBytes);
      }
  }
  
  #if !defined(ANGLE_POOL_ALLOC_GUARD_BLOCKS)
  // Verify allocations are correctly aligned for different alignments
  class PoolAllocatorAlignmentTest : public testing::TestWithParam<int>
  {};
  
  TEST_P(PoolAllocatorAlignmentTest, Alignment)
  {
      int alignment = GetParam();
      // Create a pool allocator to allocate from
      PoolAllocator poolAllocator(4096, alignment);
      // Test a number of allocation sizes for each alignment
      for (uint32_t i = 0; i < 100; ++i)
      {
          // Vary the allocation size around 4k to hit some multi-page allocations
          const size_t numBytes = rand() % (1024 * 4) + 1;
          void *allocation      = poolAllocator.allocate(numBytes);
          // Verify alignment of allocation matches expected default
          EXPECT_EQ(0u, reinterpret_cast<uintptr_t>(allocation) % alignment)
              << "Iteration " << i << " allocating " << numBytes;
      }
  }
  
  INSTANTIATE_TEST_SUITE_P(,
                           PoolAllocatorAlignmentTest,
                           testing::Values(2, 4, 8, 16, 32, 64, 128),
                           testing::PrintToStringParamName());
  #endif
  }  // namespace angle
  

Download