Hash :
80da4214
Author :
Date :
2020-01-29T10:12:31
D3D11: Copy from Image objects instead of TextureStorage when possible.
glCopyTextureCHROMIUM calls in D3D11 would call getNativeTexture on the
copy source which would allocate a TextureStorage11 if one did not
already exist. This caused full mip-chain allocations in some cases when
we could have just copied directly from the staging Image11.
When navigating to wikipedia.org:
Peak memory | Stable memory
Passthrough (before): 142 mb | 119 mb
Passthrough (after): 138 mb | 106 mb
Validating: 139 mb | 110 mb
No mip-mapped textures were allocated after this change.
BUG=chromium:1030835
Change-Id: Icd14afaec445299423cfea293cba501d774f6ade
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028147
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
//
// Copyright 2012 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Image11.h: Defines the rx::Image11 class, which acts as the interface to
// the actual underlying resources of a Texture
#ifndef LIBANGLE_RENDERER_D3D_D3D11_IMAGE11_H_
#define LIBANGLE_RENDERER_D3D_D3D11_IMAGE11_H_
#include "common/debug.h"
#include "libANGLE/ImageIndex.h"
#include "libANGLE/renderer/d3d/ImageD3D.h"
#include "libANGLE/renderer/d3d/d3d11/MappedSubresourceVerifier11.h"
#include "libANGLE/renderer/d3d/d3d11/renderer11_utils.h"
namespace gl
{
class Framebuffer;
}
namespace d3d11
{
template <typename T>
class ScopedUnmapper;
} // namespace d3d11
namespace rx
{
class Renderer11;
class TextureHelper11;
class TextureStorage11;
struct Renderer11DeviceCaps;
class Image11 : public ImageD3D
{
public:
Image11(Renderer11 *renderer);
~Image11() override;
static angle::Result GenerateMipmap(const gl::Context *context,
Image11 *dest,
Image11 *src,
const Renderer11DeviceCaps &rendererCaps);
static angle::Result CopyImage(const gl::Context *context,
Image11 *dest,
Image11 *source,
const gl::Box &sourceBox,
const gl::Offset &destOffset,
bool unpackFlipY,
bool unpackPremultiplyAlpha,
bool unpackUnmultiplyAlpha,
const Renderer11DeviceCaps &rendererCaps);
bool isDirty() const override;
angle::Result copyToStorage(const gl::Context *context,
TextureStorage *storage,
const gl::ImageIndex &index,
const gl::Box ®ion) override;
bool redefine(gl::TextureType type,
GLenum internalformat,
const gl::Extents &size,
bool forceRelease) override;
DXGI_FORMAT getDXGIFormat() const;
angle::Result loadData(const gl::Context *context,
const gl::Box &area,
const gl::PixelUnpackState &unpack,
GLenum type,
const void *input,
bool applySkipImages) override;
angle::Result loadCompressedData(const gl::Context *context,
const gl::Box &area,
const void *input) override;
angle::Result copyFromTexStorage(const gl::Context *context,
const gl::ImageIndex &imageIndex,
TextureStorage *source) override;
angle::Result copyFromFramebuffer(const gl::Context *context,
const gl::Offset &destOffset,
const gl::Rectangle &sourceArea,
const gl::Framebuffer *source) override;
angle::Result recoverFromAssociatedStorage(const gl::Context *context);
void verifyAssociatedStorageValid(TextureStorage11 *textureStorage) const;
void disassociateStorage();
angle::Result getStagingTexture(const gl::Context *context,
const TextureHelper11 **outStagingTexture,
unsigned int *outSubresourceIndex);
protected:
template <typename T>
friend class d3d11::ScopedUnmapper;
angle::Result map(const gl::Context *context, D3D11_MAP mapType, D3D11_MAPPED_SUBRESOURCE *map);
void unmap();
private:
angle::Result copyWithoutConversion(const gl::Context *context,
const gl::Offset &destOffset,
const gl::Box &sourceArea,
const TextureHelper11 &textureHelper,
UINT sourceSubResource);
angle::Result createStagingTexture(const gl::Context *context);
void releaseStagingTexture();
Renderer11 *mRenderer;
DXGI_FORMAT mDXGIFormat;
TextureHelper11 mStagingTexture;
unsigned int mStagingSubresource;
MappedSubresourceVerifier11 mStagingTextureSubresourceVerifier;
bool mRecoverFromStorage;
TextureStorage11 *mAssociatedStorage;
gl::ImageIndex mAssociatedImageIndex;
unsigned int mRecoveredFromStorageCount;
};
} // namespace rx
#endif // LIBANGLE_RENDERER_D3D_D3D11_IMAGE11_H_