Hash :
94de306d
Author :
Date :
2020-01-14T16:18:56
Extensions suffixes Added NV/OES suffixes to relevant Extensions members. Bug: angleproject:3104 Change-Id: Ia1798157086230bde8d11c6fcb4fe93211e996ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2013168 Reviewed-by: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294
//
// Copyright 2019 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// mtl_format_utils.mm:
// Implements Format conversion utilities classes that convert from angle formats
// to respective MTLPixelFormat and MTLVertexFormat.
//
#include "libANGLE/renderer/metal/mtl_format_utils.h"
#include "common/debug.h"
#include "libANGLE/renderer/Format.h"
#include "libANGLE/renderer/metal/DisplayMtl.h"
namespace rx
{
namespace mtl
{
namespace
{
bool OverrideTextureCaps(const DisplayMtl *display, angle::FormatID formatId, gl::TextureCaps *caps)
{
// NOTE(hqle): Auto generate this.
switch (formatId)
{
case angle::FormatID::R8G8_UNORM:
case angle::FormatID::R8G8B8_UNORM:
case angle::FormatID::R8G8B8_UNORM_SRGB:
case angle::FormatID::R8G8B8A8_UNORM:
case angle::FormatID::R8G8B8A8_UNORM_SRGB:
case angle::FormatID::B8G8R8A8_UNORM:
case angle::FormatID::B8G8R8A8_UNORM_SRGB:
// NOTE: even though iOS devices don't support filtering depth textures, we still report as
// supported here in order for the OES_depth_texture extension to be enabled.
// During draw call, the filter modes will be converted to nearest.
case angle::FormatID::D16_UNORM:
case angle::FormatID::D24_UNORM_S8_UINT:
case angle::FormatID::D32_FLOAT_S8X24_UINT:
case angle::FormatID::D32_FLOAT:
case angle::FormatID::D32_UNORM:
caps->texturable = caps->filterable = caps->textureAttachment = caps->renderbuffer =
true;
return true;
default:
// NOTE(hqle): Handle more cases
return false;
}
}
void GenerateTextureCapsMap(const FormatTable &formatTable,
const DisplayMtl *display,
gl::TextureCapsMap *capsMapOut,
std::vector<GLenum> *compressedFormatsOut)
{
auto &textureCapsMap = *capsMapOut;
auto &compressedFormats = *compressedFormatsOut;
compressedFormats.clear();
// Metal doesn't have programmatical way to determine texture format support.
// What is available is the online documents from Apple. What we can do here
// is manually set certain extension flag to true then let angle decide the supported formats.
//
// TODO(hqle): The proper way of doing this is creating a detailed "format support table" json
// file with info parsed from https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf.
// Then using that json file to generate a table in C++ file.
gl::Extensions tmpTextureExtensions;
#if TARGET_OS_OSX || TARGET_OS_MACCATALYST
// https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf
// Requires depth24Stencil8PixelFormatSupported=YES for these extensions
bool packedDepthStencil24Support =
display->getMetalDevice().depth24Stencil8PixelFormatSupported;
tmpTextureExtensions.packedDepthStencilOES = true; // We support this reguardless
tmpTextureExtensions.colorBufferHalfFloat = packedDepthStencil24Support;
tmpTextureExtensions.colorBufferFloat = packedDepthStencil24Support;
tmpTextureExtensions.colorBufferFloatRGB = packedDepthStencil24Support;
tmpTextureExtensions.colorBufferFloatRGBA = packedDepthStencil24Support;
tmpTextureExtensions.textureHalfFloat = packedDepthStencil24Support;
tmpTextureExtensions.textureFloatOES = packedDepthStencil24Support;
tmpTextureExtensions.textureHalfFloatLinear = packedDepthStencil24Support;
tmpTextureExtensions.textureFloatLinearOES = packedDepthStencil24Support;
tmpTextureExtensions.textureRG = packedDepthStencil24Support;
tmpTextureExtensions.textureFormatBGRA8888 = packedDepthStencil24Support;
tmpTextureExtensions.textureCompressionDXT3 = true;
tmpTextureExtensions.textureCompressionDXT5 = true;
// We can only fully support DXT1 without alpha using texture swizzle support from MacOs 10.15
tmpTextureExtensions.textureCompressionDXT1 = display->getFeatures().hasTextureSwizzle.enabled;
tmpTextureExtensions.textureCompressionS3TCsRGB = tmpTextureExtensions.textureCompressionDXT1;
#else
tmpTextureExtensions.packedDepthStencilOES = true; // override to D32_FLOAT_S8X24_UINT
tmpTextureExtensions.colorBufferHalfFloat = true;
tmpTextureExtensions.colorBufferFloat = true;
tmpTextureExtensions.colorBufferFloatRGB = true;
tmpTextureExtensions.colorBufferFloatRGBA = true;
tmpTextureExtensions.textureHalfFloat = true;
tmpTextureExtensions.textureHalfFloatLinear = true;
tmpTextureExtensions.textureFloatOES = true;
tmpTextureExtensions.textureRG = true;
tmpTextureExtensions.textureFormatBGRA8888 = true;
if ([display->getMetalDevice() supportsFeatureSet:MTLFeatureSet_iOS_GPUFamily1_v1])
{
tmpTextureExtensions.compressedETC1RGB8Texture = true;
tmpTextureExtensions.compressedETC2RGB8Texture = true;
tmpTextureExtensions.compressedETC2sRGB8Texture = true;
tmpTextureExtensions.compressedETC2RGBA8Texture = true;
tmpTextureExtensions.compressedETC2sRGB8Alpha8Texture = true;
tmpTextureExtensions.compressedEACR11UnsignedTexture = true;
tmpTextureExtensions.compressedEACR11SignedTexture = true;
tmpTextureExtensions.compressedEACRG11UnsignedTexture = true;
tmpTextureExtensions.compressedEACRG11SignedTexture = true;
tmpTextureExtensions.compressedTexturePVRTC = true;
tmpTextureExtensions.compressedTexturePVRTCsRGB = true;
}
#endif
tmpTextureExtensions.sRGB = true;
tmpTextureExtensions.depth32OES = true;
tmpTextureExtensions.depth24OES = true;
tmpTextureExtensions.rgb8rgba8OES = true;
tmpTextureExtensions.textureStorage = true;
tmpTextureExtensions.depthTextureOES = true;
tmpTextureExtensions.depthTextureANGLE = true;
auto formatVerifier = [&](const gl::InternalFormat &internalFormatInfo) {
angle::FormatID angleFormatId =
angle::Format::InternalFormatToID(internalFormatInfo.sizedInternalFormat);
const Format &mtlFormat = formatTable.getPixelFormat(angleFormatId);
if (!mtlFormat.valid())
{
return;
}
const angle::Format &intendedAngleFormat = mtlFormat.intendedAngleFormat();
gl::TextureCaps textureCaps;
const auto &clientVersion = kMaxSupportedGLVersion;
// First let check whether we can determine programmatically.
if (!OverrideTextureCaps(display, mtlFormat.intendedFormatId, &textureCaps))
{
// Let angle decide based on extensions we enabled above.
textureCaps = gl::GenerateMinimumTextureCaps(internalFormatInfo.sizedInternalFormat,
clientVersion, tmpTextureExtensions);
}
// NOTE(hqle): Support MSAA.
textureCaps.sampleCounts.clear();
textureCaps.sampleCounts.insert(0);
textureCaps.sampleCounts.insert(1);
textureCapsMap.set(mtlFormat.intendedFormatId, textureCaps);
if (intendedAngleFormat.isBlock)
{
compressedFormats.push_back(intendedAngleFormat.glInternalFormat);
}
// Verify implementation mismatch
ASSERT(!textureCaps.renderbuffer || mtl::Format::FormatRenderable(mtlFormat.metalFormat));
ASSERT(!textureCaps.textureAttachment ||
mtl::Format::FormatRenderable(mtlFormat.metalFormat));
};
// Texture caps map.
const gl::FormatSet &internalFormats = gl::GetAllSizedInternalFormats();
for (const auto internalFormat : internalFormats)
{
const gl::InternalFormat &internalFormatInfo =
gl::GetSizedInternalFormatInfo(internalFormat);
formatVerifier(internalFormatInfo);
}
}
} // namespace
// FormatBase implementation
const angle::Format &FormatBase::actualAngleFormat() const
{
return angle::Format::Get(actualFormatId);
}
const angle::Format &FormatBase::intendedAngleFormat() const
{
return angle::Format::Get(intendedFormatId);
}
// Format implementation
/** static */
bool Format::FormatRenderable(MTLPixelFormat format)
{
switch (format)
{
case MTLPixelFormatR8Unorm:
case MTLPixelFormatRG8Unorm:
case MTLPixelFormatR16Float:
case MTLPixelFormatRG16Float:
case MTLPixelFormatRGBA16Float:
case MTLPixelFormatR32Float:
case MTLPixelFormatRG32Float:
case MTLPixelFormatRGBA32Float:
case MTLPixelFormatBGRA8Unorm:
case MTLPixelFormatBGRA8Unorm_sRGB:
case MTLPixelFormatRGBA8Unorm:
case MTLPixelFormatRGBA8Unorm_sRGB:
case MTLPixelFormatDepth32Float:
case MTLPixelFormatStencil8:
case MTLPixelFormatDepth32Float_Stencil8:
#if TARGET_OS_OSX || TARGET_OS_MACCATALYST
case MTLPixelFormatDepth16Unorm:
case MTLPixelFormatDepth24Unorm_Stencil8:
#else
case MTLPixelFormatR8Unorm_sRGB:
case MTLPixelFormatRG8Unorm_sRGB:
case MTLPixelFormatB5G6R5Unorm:
case MTLPixelFormatA1BGR5Unorm:
case MTLPixelFormatABGR4Unorm:
case MTLPixelFormatBGR5A1Unorm:
#endif
// NOTE(hqle): we may add more formats support here in future.
return true;
default:
return false;
}
return false;
}
/** static */
bool Format::FormatCPUReadable(MTLPixelFormat format)
{
switch (format)
{
case MTLPixelFormatDepth32Float:
case MTLPixelFormatStencil8:
case MTLPixelFormatDepth32Float_Stencil8:
#if TARGET_OS_OSX || TARGET_OS_MACCATALYST
case MTLPixelFormatDepth16Unorm:
case MTLPixelFormatDepth24Unorm_Stencil8:
#endif
// NOTE(hqle): we may add more formats support here in future.
return false;
default:
return true;
}
}
const gl::InternalFormat &Format::intendedInternalFormat() const
{
return gl::GetSizedInternalFormatInfo(intendedAngleFormat().glInternalFormat);
}
// FormatTable implementation
angle::Result FormatTable::initialize(const DisplayMtl *display)
{
for (size_t i = 0; i < angle::kNumANGLEFormats; ++i)
{
const auto formatId = static_cast<angle::FormatID>(i);
mPixelFormatTable[i].init(display, formatId);
mVertexFormatTables[0][i].init(formatId, false);
mVertexFormatTables[1][i].init(formatId, true);
}
return angle::Result::Continue;
}
void FormatTable::generateTextureCaps(const DisplayMtl *display,
gl::TextureCapsMap *capsMapOut,
std::vector<GLenum> *compressedFormatsOut) const
{
GenerateTextureCapsMap(*this, display, capsMapOut, compressedFormatsOut);
}
const Format &FormatTable::getPixelFormat(angle::FormatID angleFormatId) const
{
return mPixelFormatTable[static_cast<size_t>(angleFormatId)];
}
const VertexFormat &FormatTable::getVertexFormat(angle::FormatID angleFormatId,
bool tightlyPacked) const
{
auto tableIdx = tightlyPacked ? 1 : 0;
return mVertexFormatTables[tableIdx][static_cast<size_t>(angleFormatId)];
}
} // namespace mtl
} // namespace rx