kc3-lang/angle/src/libANGLE/renderer/gl/TextureGL.h

• Show log

  Commit

• Hash : 0f2b1560
  Author :
  Date : 2016-05-13T16:15:35
  

  Fix GenerateMipmap when base level or max level are set
  
  According to GLES 3.0.4 section 3.8.10, GenerateMipmap should generate
  levels based on the base level, and generate them at most up to the
  max level. Levels outside the base/max level range should be unchanged
  by GenerateMipmap.
  
  The Texture class is fixed so that the image descs are set only for
  the changed mipmap range when GenerateMipmap is called.
  
  The D3D backend is fixed so that mipmap generation is correctly
  started from the base level instead of level 0, and making sure that
  mipmaps are generated only up to the max level. Generating mipmaps for
  array textures is also fixed for cases where the base level depth >=
  max(width, height) * 2.
  
  The GL backend is fixed to sync texture state before GenerateMipmap is
  called, so that base level and max level are set correctly in the
  driver.
  
  The GenerateMipmap entry point is refactored so that it has a separate
  validation function and a context function which does the work.
  Validation for out-of-range base levels is added.
  
  New tests are added to verify the functionality. One corner case in
  the tests fails on NVIDIA GL drivers likely due to a driver bug -
  similar rules for GenerateMipmap are found from newer GLES specs and
  also OpenGL specs (checked versions 3.3 and 4.4).
  
  BUG=angleproject:596
  TEST=angle_end2end_tests
  
  Change-Id: Ifc7b4126281967fc4f6dc4f9452e5b01e39f83d7
  Reviewed-on: https://chromium-review.googlesource.com/344514
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  

Download

• src/libANGLE/renderer/gl/TextureGL.h

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // TextureGL.h: Defines the class interface for TextureGL.
  
  #ifndef LIBANGLE_RENDERER_GL_TEXTUREGL_H_
  #define LIBANGLE_RENDERER_GL_TEXTUREGL_H_
  
  #include "libANGLE/angletypes.h"
  #include "libANGLE/renderer/TextureImpl.h"
  #include "libANGLE/Texture.h"
  
  namespace rx
  {
  
  class BlitGL;
  class FunctionsGL;
  class StateManagerGL;
  struct WorkaroundsGL;
  
  struct LUMAWorkaroundGL
  {
      bool enabled;
      GLenum workaroundFormat;
  
      LUMAWorkaroundGL();
      LUMAWorkaroundGL(bool enabled, GLenum workaroundFormat);
  };
  
  // Structure containing information about format and workarounds for each mip level of the
  // TextureGL.
  struct LevelInfoGL
  {
      // Format of the data used in this mip level.
      GLenum sourceFormat;
  
      // If this mip level requires sampler-state re-writing so that only a red channel is exposed.
      bool depthStencilWorkaround;
  
      // Information about luminance alpha texture workarounds in the core profile.
      LUMAWorkaroundGL lumaWorkaround;
  
      LevelInfoGL();
      LevelInfoGL(GLenum sourceFormat,
                  bool depthStencilWorkaround,
                  const LUMAWorkaroundGL &lumaWorkaround);
  };
  
  class TextureGL : public TextureImpl
  {
    public:
      TextureGL(const gl::TextureState &state,
                const FunctionsGL *functions,
                const WorkaroundsGL &workarounds,
                StateManagerGL *stateManager,
                BlitGL *blitter);
      ~TextureGL() override;
  
      gl::Error setImage(GLenum target, size_t level, GLenum internalFormat, const gl::Extents &size, GLenum format, GLenum type,
                         const gl::PixelUnpackState &unpack, const uint8_t *pixels) override;
      gl::Error setSubImage(GLenum target, size_t level, const gl::Box &area, GLenum format, GLenum type,
                            const gl::PixelUnpackState &unpack, const uint8_t *pixels) override;
  
      gl::Error setCompressedImage(GLenum target, size_t level, GLenum internalFormat, const gl::Extents &size,
                                   const gl::PixelUnpackState &unpack, size_t imageSize, const uint8_t *pixels) override;
      gl::Error setCompressedSubImage(GLenum target, size_t level, const gl::Box &area, GLenum format,
                                      const gl::PixelUnpackState &unpack, size_t imageSize, const uint8_t *pixels) override;
  
      gl::Error copyImage(GLenum target, size_t level, const gl::Rectangle &sourceArea, GLenum internalFormat,
                          const gl::Framebuffer *source) override;
      gl::Error copySubImage(GLenum target, size_t level, const gl::Offset &destOffset, const gl::Rectangle &sourceArea,
                             const gl::Framebuffer *source) override;
  
      gl::Error setStorage(GLenum target, size_t levels, GLenum internalFormat, const gl::Extents &size) override;
  
      gl::Error setImageExternal(GLenum target,
                                 egl::Stream *stream,
                                 const egl::Stream::GLTextureDescription &desc) override;
  
      gl::Error generateMipmap() override;
  
      void bindTexImage(egl::Surface *surface) override;
      void releaseTexImage() override;
  
      gl::Error setEGLImageTarget(GLenum target, egl::Image *image) override;
  
      void syncState(size_t textureUnit) const;
      GLuint getTextureID() const;
  
      gl::Error getAttachmentRenderTarget(const gl::FramebufferAttachment::Target &target,
                                          FramebufferAttachmentRenderTarget **rtOut) override
      {
          return gl::Error(GL_OUT_OF_MEMORY, "Not supported on OpenGL");
      }
  
      void setBaseLevel(GLuint) override {}
  
    private:
      const FunctionsGL *mFunctions;
      const WorkaroundsGL &mWorkarounds;
      StateManagerGL *mStateManager;
      BlitGL *mBlitter;
  
      std::vector<LevelInfoGL> mLevelInfo;
  
      mutable gl::TextureState mAppliedTextureState;
      GLuint mTextureID;
  };
  
  }
  
  #endif // LIBANGLE_RENDERER_GL_TEXTUREGL_H_
  

Download