Hash :
e60d05b2
Author :
Date :
2019-12-17T13:59:24
Make Sync constructors take GLImplFactory. Makes them consistent with the rest of the code. Will allow the Sync class to call methods in GLImplFactory to generate a resource Serial. Also updates the unit test to the new design. Bug: angleproject:4223 Change-Id: Ic5ba69c3a6a51d4b51d876c3b5e7eb7bc44a9ae8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969060 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131
//
// Copyright 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include "libANGLE/Fence.h"
#include "libANGLE/renderer/FenceNVImpl.h"
#include "libANGLE/renderer/SyncImpl.h"
#include "tests/angle_unittests_utils.h"
using namespace testing;
namespace
{
//
// FenceNV tests
//
class MockFenceNVImpl : public rx::FenceNVImpl
{
public:
virtual ~MockFenceNVImpl() { destroy(); }
MOCK_METHOD2(set, angle::Result(const gl::Context *, GLenum));
MOCK_METHOD2(test, angle::Result(const gl::Context *, GLboolean *));
MOCK_METHOD1(finish, angle::Result(const gl::Context *));
MOCK_METHOD0(destroy, void());
};
class FenceNVTest : public Test
{
protected:
void SetUp() override
{
mImpl = new MockFenceNVImpl;
EXPECT_CALL(factory, createFenceNV()).WillOnce(Return(mImpl));
EXPECT_CALL(*mImpl, destroy());
mFence = new gl::FenceNV(&factory);
}
void TearDown() override { delete mFence; }
NiceMock<rx::MockGLFactory> factory;
MockFenceNVImpl *mImpl;
gl::FenceNV *mFence;
};
TEST_F(FenceNVTest, SetAndTestBehavior)
{
EXPECT_CALL(*mImpl, set(_, _)).WillOnce(Return(angle::Result::Continue)).RetiresOnSaturation();
EXPECT_FALSE(mFence->isSet());
EXPECT_EQ(angle::Result::Continue, mFence->set(nullptr, GL_ALL_COMPLETED_NV));
EXPECT_TRUE(mFence->isSet());
// Fake the behavior of testing the fence before and after it's passed.
EXPECT_CALL(*mImpl, test(_, _))
.WillOnce(DoAll(SetArgumentPointee<1>(static_cast<GLboolean>(GL_FALSE)),
Return(angle::Result::Continue)))
.WillOnce(DoAll(SetArgumentPointee<1>(static_cast<GLboolean>(GL_TRUE)),
Return(angle::Result::Continue)))
.RetiresOnSaturation();
GLboolean out;
EXPECT_EQ(angle::Result::Continue, mFence->test(nullptr, &out));
EXPECT_EQ(GL_FALSE, out);
EXPECT_EQ(angle::Result::Continue, mFence->test(nullptr, &out));
EXPECT_EQ(GL_TRUE, out);
}
//
// Sync tests
//
class MockSyncImpl : public rx::SyncImpl
{
public:
virtual ~MockSyncImpl() { destroy(); }
MOCK_METHOD3(set, angle::Result(const gl::Context *, GLenum, GLbitfield));
MOCK_METHOD4(clientWait, angle::Result(const gl::Context *, GLbitfield, GLuint64, GLenum *));
MOCK_METHOD3(serverWait, angle::Result(const gl::Context *, GLbitfield, GLuint64));
MOCK_METHOD2(getStatus, angle::Result(const gl::Context *, GLint *));
MOCK_METHOD0(destroy, void());
};
class FenceSyncTest : public Test
{
protected:
void SetUp() override
{
mImpl = new MockSyncImpl;
EXPECT_CALL(factory, createSync()).WillOnce(Return(mImpl));
mFence = new gl::Sync(&factory, 1);
EXPECT_CALL(*mImpl, destroy());
mFence->addRef();
}
void TearDown() override { mFence->release(nullptr); }
NiceMock<rx::MockGLFactory> factory;
MockSyncImpl *mImpl;
gl::Sync *mFence;
};
TEST_F(FenceSyncTest, SetAndGetStatusBehavior)
{
EXPECT_CALL(*mImpl, set(_, _, _))
.WillOnce(Return(angle::Result::Continue))
.RetiresOnSaturation();
EXPECT_EQ(angle::Result::Continue, mFence->set(nullptr, GL_SYNC_GPU_COMMANDS_COMPLETE, 0));
EXPECT_EQ(static_cast<GLenum>(GL_SYNC_GPU_COMMANDS_COMPLETE), mFence->getCondition());
// Fake the behavior of testing the fence before and after it's passed.
EXPECT_CALL(*mImpl, getStatus(_, _))
.WillOnce(DoAll(SetArgumentPointee<1>(GL_UNSIGNALED), Return(angle::Result::Continue)))
.WillOnce(DoAll(SetArgumentPointee<1>(GL_SIGNALED), Return(angle::Result::Continue)))
.RetiresOnSaturation();
GLint out;
EXPECT_EQ(angle::Result::Continue, mFence->getStatus(nullptr, &out));
EXPECT_EQ(GL_UNSIGNALED, out);
EXPECT_EQ(angle::Result::Continue, mFence->getStatus(nullptr, &out));
EXPECT_EQ(GL_SIGNALED, out);
}
} // namespace