kc3-lang/angle/src/compiler/translator/ImmutableStringBuilder.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/ImmutableStringBuilder.cpp

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // ImmutableStringBuilder.cpp: Stringstream-like utility for building pool allocated strings where
  // the maximum length is known in advance.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "compiler/translator/ImmutableStringBuilder.h"
  
  #include <inttypes.h>
  #include <stdio.h>
  
  namespace sh
  {
  
  ImmutableStringBuilder &ImmutableStringBuilder::operator<<(const ImmutableString &str)
  {
      ASSERT(mData != nullptr);
      ASSERT(mPos + str.length() <= mMaxLength);
      memcpy(mData + mPos, str.data(), str.length());
      mPos += str.length();
      return *this;
  }
  
  ImmutableStringBuilder &ImmutableStringBuilder::operator<<(char c)
  {
      ASSERT(mData != nullptr);
      ASSERT(mPos + 1 <= mMaxLength);
      mData[mPos++] = c;
      return *this;
  }
  
  ImmutableStringBuilder &ImmutableStringBuilder::operator<<(uint64_t v)
  {
      // + 1 is because snprintf writes at most bufsz - 1 and then \0.
      // Our bufsz is mMaxLength + 1.
      int numChars = snprintf(mData + mPos, mMaxLength - mPos + 1, "%" PRIu64, v);
      ASSERT(numChars >= 0);
      ASSERT(mPos + numChars <= mMaxLength);
      mPos += numChars;
      return *this;
  }
  
  ImmutableStringBuilder &ImmutableStringBuilder::operator<<(int64_t v)
  {
      // + 1 is because snprintf writes at most bufsz - 1 and then \0.
      // Our bufsz is mMaxLength + 1.
      int numChars = snprintf(mData + mPos, mMaxLength - mPos + 1, "%" PRId64, v);
      ASSERT(numChars >= 0);
      ASSERT(mPos + numChars <= mMaxLength);
      mPos += numChars;
      return *this;
  }
  
  ImmutableStringBuilder::operator ImmutableString()
  {
      mData[mPos] = '\0';
      ImmutableString str(mData, mPos);
  #if defined(ANGLE_ENABLE_ASSERTS)
      // Make sure that nothing is added to the string after it is finalized.
      mData = nullptr;
  #endif
      return str;
  }
  
  }  // namespace sh
  

Download