• Show log

    Commit

  • Hash : 0d2c75f4
    Author : Corentin Wallez
    Date : 2020-01-14T19:35:16

    DisplayGLX::isValidNativeWindow, avoid X11 exiting the program
    
    The previous implementation of the function had an incorrect comment
    that implied XQueryTree was a great way to check if a Window is valid.
    Any X11 function taking a Window is a good candidate, what we need to be
    careful about is X11 exiting the program on any error.
    
    Replace it with a call to  XGetWindowAttributes while ignoring X11
    errors.
    
    This fix was found while implementing similar functionality in Dawn.
    
    Bug: dawn:269
    Change-Id: I777e59cddbe94baf63286d11887b58c63ac2b66c
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001301
    Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    kc3_lang_org thodg_w www_kmx_io thodg_l thodg thodg_m
    Tags