kc3-lang/angle/src/libANGLE/renderer/FramebufferAttachmentObjectImpl.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : Jamie Madill
  Date : 2018-11-29 18:16:17
  Hash : 7c985f5c
  Message : Make angle::Result an enum. This moves away from a class type to a value type. This should improve performance when using angle::Result as a return value. Previously the generated code would return a pointer instead of a value. Improves performance in the most targeted microbenchmark by 10%. In more realistic scanarios it will have a smaller improvement. Also simplifies the class implementation and usage. Includes some unrelated code generation changes. Bug: angleproject:2491 Change-Id: Ifcf86870bf1c00a2f73c39ea6e4f05ca705050aa Reviewed-on: https://chromium-review.googlesource.com/c/1356139 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

• src/libANGLE/renderer/FramebufferAttachmentObjectImpl.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // FramebufferAttachmentObjectImpl.h:
  //   Common ancenstor for all implementations of FBO attachable-objects.
  //   This means Surfaces, Textures and Renderbuffers.
  //
  
  #ifndef LIBANGLE_RENDERER_FRAMEBUFFER_ATTACHMENT_OBJECT_IMPL_H_
  #define LIBANGLE_RENDERER_FRAMEBUFFER_ATTACHMENT_OBJECT_IMPL_H_
  
  #include "libANGLE/ImageIndex.h"
  #include "libANGLE/Observer.h"
  
  namespace rx
  {
  class FramebufferAttachmentRenderTarget;
  
  class FramebufferAttachmentObjectImpl : angle::NonCopyable
  {
    public:
      FramebufferAttachmentObjectImpl() {}
      virtual ~FramebufferAttachmentObjectImpl() {}
  
      virtual angle::Result getAttachmentRenderTarget(const gl::Context *context,
                                                      GLenum binding,
                                                      const gl::ImageIndex &imageIndex,
                                                      FramebufferAttachmentRenderTarget **rtOut);
  
      virtual angle::Result initializeContents(const gl::Context *context,
                                               const gl::ImageIndex &imageIndex);
  };
  
  inline angle::Result FramebufferAttachmentObjectImpl::getAttachmentRenderTarget(
      const gl::Context *context,
      GLenum binding,
      const gl::ImageIndex &imageIndex,
      FramebufferAttachmentRenderTarget **rtOut)
  {
      UNIMPLEMENTED();
      return angle::Result::Stop;
  }
  
  inline angle::Result FramebufferAttachmentObjectImpl::initializeContents(
      const gl::Context *context,
      const gl::ImageIndex &imageIndex)
  {
      UNIMPLEMENTED();
      return angle::Result::Stop;
  }
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_FRAMEBUFFER_ATTACHMENT_OBJECT_IMPL_H_