Hash :
797e627e
Author :
Date :
2022-04-08T22:49:51
Autogenerate list of features as enum The WithX() and WithNoX() helpers are removed and replaced with enable() and disable() member functions that take the name of the feature (as a Feature::X enum constant). This has two benefits: - Adding tests that override a feature no longer requires additional helper functions to be written. - There's no mistaking the feature name. This change doesn't yet fix the main issue in anglebug.com/6435, but does fix the following helpers using an old feature name (so they were ineffective): - WithMetalForcedBufferGPUStorage - WithNoVulkanViewportFlip A follow up would remove the old way of overriding features in tests and replaces them with the new way. Bug: angleproject:6435 Change-Id: Ida02b26ec72bc40d7a8938c76a93815bb903ca05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580982 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
{
"include/platform/FeaturesD3D.h":
"66f7409cc3fed196ef4b30fa2a911cf5",
"include/platform/FeaturesGL.h":
"c29f5ed18ab719dc01c42221bde72519",
"include/platform/FeaturesMtl.h":
"a5f41dc5dbc9f9272819cb6c0ff02a47",
"include/platform/FeaturesVk.h":
"e1f816b2f3bc3ea2f311f7de25974330",
"include/platform/FrontendFeatures.h":
"69191d0121faa83ad7e38eccf454fb91",
"include/platform/d3d_features.json":
"abdcf90e79eb2aae4f55a33b1ca17b72",
"include/platform/frontend_features.json":
"cf60ba62068fbd82274a20fbbb5a3030",
"include/platform/gen_features.py":
"d717215ff1884d23cde74db5074188e0",
"include/platform/gl_features.json":
"ff2f4dac740e071f511f751f59f3ef31",
"include/platform/mtl_features.json":
"3f4a698e0bf3dcd448a7316202faf174",
"include/platform/vk_features.json":
"5ad282166141c6a8afaabc9581bc851d",
"util/angle_features_autogen.cpp":
"6d2601d2a0e15bec38907cb15a7ff9f6",
"util/angle_features_autogen.h":
"b4fd8bcffc3de8cbd25224429f0caa7b"
}