Hash :
0297779c
Author :
Date :
2021-06-08T01:06:21
Vulkan: SPIR-V Gen: Handle invariant variables The Invariant decoration is applied to variable declarations and block members as necessary. When invariant is applied to a gl_PerVertex built-in, it's applied to the appropriate member in DeclarePerVertexBlocks. Bug: angleproject:4889 Change-Id: Idaa8d4ab92f975381a0237d372f0a4044ff983e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946116 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400
//
// Copyright 2021 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// DeclarePerVertexBlocks: Declare gl_PerVertex blocks if not already.
//
#include "compiler/translator/tree_ops/vulkan/DeclarePerVertexBlocks.h"
#include "compiler/translator/Compiler.h"
#include "compiler/translator/ImmutableStringBuilder.h"
#include "compiler/translator/StaticType.h"
#include "compiler/translator/SymbolTable.h"
#include "compiler/translator/tree_util/IntermNode_util.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
#include "compiler/translator/tree_util/ReplaceVariable.h"
namespace sh
{
namespace
{
using PerVertexMemberFlags = std::array<bool, 4>;
int GetPerVertexFieldIndex(const TQualifier qualifier, const ImmutableString &name)
{
switch (qualifier)
{
case EvqPosition:
ASSERT(name == "gl_Position");
return 0;
case EvqPointSize:
ASSERT(name == "gl_PointSize");
return 1;
case EvqClipDistance:
ASSERT(name == "gl_ClipDistance");
return 2;
case EvqCullDistance:
ASSERT(name == "gl_CullDistance");
return 3;
default:
return -1;
}
}
// Traverser that:
//
// 1. Declares the input and output gl_PerVertex types and variables if not already (based on shader
// type).
// 2. Turns built-in references into indexes into these variables.
class DeclarePerVertexBlocksTraverser : public TIntermTraverser
{
public:
DeclarePerVertexBlocksTraverser(TCompiler *compiler,
TSymbolTable *symbolTable,
const PerVertexMemberFlags &invariantFlags,
const PerVertexMemberFlags &preciseFlags)
: TIntermTraverser(true, false, false, symbolTable),
mShaderType(compiler->getShaderType()),
mResources(compiler->getResources()),
mPerVertexInVar(nullptr),
mPerVertexOutVar(nullptr),
mPerVertexInVarRedeclared(false),
mPerVertexOutVarRedeclared(false),
mPerVertexOutInvariantFlags(invariantFlags),
mPerVertexOutPreciseFlags(preciseFlags)
{}
void visitSymbol(TIntermSymbol *symbol) override
{
const TVariable *variable = &symbol->variable();
const TType *type = &variable->getType();
// Replace gl_out if necessary.
if (mShaderType == GL_TESS_CONTROL_SHADER && type->getQualifier() == EvqPerVertexOut)
{
ASSERT(variable->name() == "gl_out");
// Declare gl_out if not already.
if (mPerVertexOutVar == nullptr)
{
// Record invariant and precise qualifiers used on the fields so they would be
// applied to the replacement gl_out.
for (const TField *field : type->getInterfaceBlock()->fields())
{
const TType &fieldType = *field->type();
const int fieldIndex =
GetPerVertexFieldIndex(fieldType.getQualifier(), field->name());
ASSERT(fieldIndex >= 0);
if (fieldType.isInvariant())
{
mPerVertexOutInvariantFlags[fieldIndex] = true;
}
if (fieldType.isPrecise())
{
mPerVertexOutPreciseFlags[fieldIndex] = true;
}
}
declareDefaultGlOut();
}
if (mPerVertexOutVarRedeclared)
{
queueReplacement(new TIntermSymbol(mPerVertexOutVar), OriginalNode::IS_DROPPED);
}
return;
}
// Replace gl_in if necessary.
if ((mShaderType == GL_TESS_CONTROL_SHADER || mShaderType == GL_TESS_EVALUATION_SHADER ||
mShaderType == GL_GEOMETRY_SHADER) &&
type->getQualifier() == EvqPerVertexIn)
{
ASSERT(variable->name() == "gl_in");
// Declare gl_in if not already.
if (mPerVertexInVar == nullptr)
{
declareDefaultGlIn();
}
if (mPerVertexInVarRedeclared)
{
queueReplacement(new TIntermSymbol(mPerVertexInVar), OriginalNode::IS_DROPPED);
}
return;
}
// Turn gl_Position, gl_PointSize, gl_ClipDistance and gl_CullDistance into references to
// the output gl_PerVertex. Note that the default gl_PerVertex is declared as follows:
//
// out gl_PerVertex
// {
// vec4 gl_Position;
// float gl_PointSize;
// float gl_ClipDistance[];
// float gl_CullDistance[];
// };
//
if (variable->symbolType() != SymbolType::BuiltIn)
{
ASSERT(variable->name() != "gl_Position" && variable->name() != "gl_PointSize" &&
variable->name() != "gl_ClipDistance" && variable->name() != "gl_CullDistance");
return;
}
// If this built-in was already visited, reuse the variable defined for it.
auto replacement = mVariableMap.find(variable);
if (replacement != mVariableMap.end())
{
queueReplacement(replacement->second->deepCopy(), OriginalNode::IS_DROPPED);
return;
}
const int fieldIndex = GetPerVertexFieldIndex(type->getQualifier(), variable->name());
// Not the built-in we are looking for.
if (fieldIndex < 0)
{
return;
}
// Declare the output gl_PerVertex if not already.
if (mPerVertexOutVar == nullptr)
{
declareDefaultGlOut();
}
TType *newType = new TType(*type);
newType->setInterfaceBlockField(mPerVertexOutVar->getType().getInterfaceBlock(),
fieldIndex);
TVariable *newVariable = new TVariable(mSymbolTable, variable->name(), newType,
variable->symbolType(), variable->extensions());
TIntermSymbol *newSymbol = new TIntermSymbol(newVariable);
mVariableMap[variable] = newSymbol;
queueReplacement(newSymbol, OriginalNode::IS_DROPPED);
}
const TVariable *getRedeclaredPerVertexOutVar()
{
return mPerVertexOutVarRedeclared ? mPerVertexOutVar : nullptr;
}
const TVariable *getRedeclaredPerVertexInVar()
{
return mPerVertexInVarRedeclared ? mPerVertexInVar : nullptr;
}
private:
const TVariable *declarePerVertex(TQualifier qualifier,
uint32_t arraySize,
ImmutableString &variableName)
{
TFieldList *fields = new TFieldList;
const TType *vec4Type = StaticType::GetBasic<EbtFloat, 4>();
const TType *floatType = StaticType::GetBasic<EbtFloat, 1>();
TType *positionType = new TType(*vec4Type);
TType *pointSizeType = new TType(*floatType);
TType *clipDistanceType = new TType(*floatType);
TType *cullDistanceType = new TType(*floatType);
positionType->setQualifier(EvqPosition);
pointSizeType->setQualifier(EvqPointSize);
clipDistanceType->setQualifier(EvqClipDistance);
cullDistanceType->setQualifier(EvqCullDistance);
clipDistanceType->makeArray(mResources.MaxClipDistances);
cullDistanceType->makeArray(mResources.MaxCullDistances);
if (qualifier == EvqPerVertexOut)
{
positionType->setInvariant(mPerVertexOutInvariantFlags[0]);
pointSizeType->setInvariant(mPerVertexOutInvariantFlags[1]);
clipDistanceType->setInvariant(mPerVertexOutInvariantFlags[2]);
cullDistanceType->setInvariant(mPerVertexOutInvariantFlags[3]);
positionType->setPrecise(mPerVertexOutPreciseFlags[0]);
pointSizeType->setPrecise(mPerVertexOutPreciseFlags[1]);
clipDistanceType->setPrecise(mPerVertexOutPreciseFlags[2]);
cullDistanceType->setPrecise(mPerVertexOutPreciseFlags[3]);
}
fields->push_back(new TField(positionType, ImmutableString("gl_Position"), TSourceLoc(),
SymbolType::AngleInternal));
fields->push_back(new TField(pointSizeType, ImmutableString("gl_PointSize"), TSourceLoc(),
SymbolType::AngleInternal));
fields->push_back(new TField(clipDistanceType, ImmutableString("gl_ClipDistance"),
TSourceLoc(), SymbolType::AngleInternal));
fields->push_back(new TField(cullDistanceType, ImmutableString("gl_CullDistance"),
TSourceLoc(), SymbolType::AngleInternal));
TInterfaceBlock *interfaceBlock =
new TInterfaceBlock(mSymbolTable, ImmutableString("gl_PerVertex"), fields,
TLayoutQualifier::Create(), SymbolType::AngleInternal);
TType *interfaceBlockType =
new TType(interfaceBlock, qualifier, TLayoutQualifier::Create());
if (arraySize > 0)
{
interfaceBlockType->makeArray(arraySize);
}
TVariable *interfaceBlockVar =
new TVariable(mSymbolTable, variableName, interfaceBlockType,
variableName.empty() ? SymbolType::Empty : SymbolType::AngleInternal);
return interfaceBlockVar;
}
void declareDefaultGlOut()
{
ASSERT(!mPerVertexOutVarRedeclared);
// For tessellation control shaders, gl_out is an array of MaxPatchVertices
// For other shaders, there's no explicit name or array size
ImmutableString varName("");
uint32_t arraySize = 0;
if (mShaderType == GL_TESS_CONTROL_SHADER)
{
varName = ImmutableString("gl_out");
arraySize = mResources.MaxPatchVertices;
}
mPerVertexOutVar = declarePerVertex(EvqPerVertexOut, arraySize, varName);
mPerVertexOutVarRedeclared = true;
}
void declareDefaultGlIn()
{
ASSERT(!mPerVertexInVarRedeclared);
// For tessellation shaders, gl_in is an array of MaxPatchVertices.
// For geometry shaders, gl_in is sized based on the primitive type.
ImmutableString varName("gl_in");
uint32_t arraySize = mResources.MaxPatchVertices;
if (mShaderType == GL_GEOMETRY_SHADER)
{
arraySize =
mSymbolTable->getGlInVariableWithArraySize()->getType().getOutermostArraySize();
}
mPerVertexInVar = declarePerVertex(EvqPerVertexIn, arraySize, varName);
mPerVertexInVarRedeclared = true;
}
GLenum mShaderType;
const ShBuiltInResources &mResources;
const TVariable *mPerVertexInVar;
const TVariable *mPerVertexOutVar;
bool mPerVertexInVarRedeclared;
bool mPerVertexOutVarRedeclared;
// A map of already replaced built-in variables.
VariableReplacementMap mVariableMap;
// Whether each field is invariant or precise.
PerVertexMemberFlags mPerVertexOutInvariantFlags;
PerVertexMemberFlags mPerVertexOutPreciseFlags;
};
void AddPerVertexDecl(TIntermBlock *root, const TVariable *variable)
{
if (variable == nullptr)
{
return;
}
TIntermDeclaration *decl = new TIntermDeclaration;
TIntermSymbol *symbol = new TIntermSymbol(variable);
decl->appendDeclarator(symbol);
// Insert the declaration before the first function.
size_t firstFunctionIndex = FindFirstFunctionDefinitionIndex(root);
root->insertChildNodes(firstFunctionIndex, {decl});
}
} // anonymous namespace
bool DeclarePerVertexBlocks(TCompiler *compiler, TIntermBlock *root, TSymbolTable *symbolTable)
{
if (compiler->getShaderType() == GL_COMPUTE_SHADER ||
compiler->getShaderType() == GL_FRAGMENT_SHADER)
{
return true;
}
// First, visit all global qualifier declarations and find which built-ins are invariant or
// precise.
PerVertexMemberFlags invariantFlags = {};
PerVertexMemberFlags preciseFlags = {};
TIntermSequence withoutPerVertexGlobalQualifierDeclarations;
for (TIntermNode *node : *root->getSequence())
{
TIntermGlobalQualifierDeclaration *asGlobalQualifierDecl =
node->getAsGlobalQualifierDeclarationNode();
if (asGlobalQualifierDecl == nullptr)
{
withoutPerVertexGlobalQualifierDeclarations.push_back(node);
continue;
}
TIntermSymbol *symbol = asGlobalQualifierDecl->getSymbol();
const int fieldIndex =
GetPerVertexFieldIndex(symbol->getType().getQualifier(), symbol->getName());
if (fieldIndex < 0)
{
withoutPerVertexGlobalQualifierDeclarations.push_back(node);
continue;
}
if (asGlobalQualifierDecl->isInvariant())
{
invariantFlags[fieldIndex] = true;
}
else if (asGlobalQualifierDecl->isPrecise())
{
preciseFlags[fieldIndex] = true;
}
}
// Remove the global qualifier declarations for the gl_PerVertex members.
root->replaceAllChildren(withoutPerVertexGlobalQualifierDeclarations);
// If #pragma STDGL invariant(all) is specified, make all outputs invariant.
if (compiler->getPragma().stdgl.invariantAll)
{
std::fill(invariantFlags.begin(), invariantFlags.end(), true);
}
// Then declare the in and out gl_PerVertex I/O blocks.
DeclarePerVertexBlocksTraverser traverser(compiler, symbolTable, invariantFlags, preciseFlags);
root->traverse(&traverser);
if (!traverser.updateTree(compiler, root))
{
return false;
}
AddPerVertexDecl(root, traverser.getRedeclaredPerVertexOutVar());
AddPerVertexDecl(root, traverser.getRedeclaredPerVertexInVar());
return compiler->validateAST(root);
}
} // namespace sh