Hash :
f00f1009
Author :
Date :
2021-09-30T18:59:25
Capture/Replay: Fix readback of zero-sized renderbuffers Only read back the renderbuffer content if the renderbuffer has a non-zero size. Add a test to test the capture/replay in this case. Bug: angleproject:6425 Change-Id: I943804884f18a3a2b9de526309dd500de9dd6fd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3197572 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76
//
// Copyright 2015 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// ObjectAllocationTest
// Tests for object allocations and lifetimes.
//
#include "test_utils/ANGLETest.h"
using namespace angle;
namespace
{
class ObjectAllocationTest : public ANGLETest
{
protected:
ObjectAllocationTest() {}
};
class ObjectAllocationTestES3 : public ObjectAllocationTest
{};
// Test that we don't re-allocate a bound framebuffer ID.
TEST_P(ObjectAllocationTestES3, BindFramebufferBeforeGen)
{
glBindFramebuffer(GL_FRAMEBUFFER, 1);
GLuint fbo = 0;
glGenFramebuffers(1, &fbo);
EXPECT_NE(1u, fbo);
glDeleteFramebuffers(1, &fbo);
EXPECT_GL_NO_ERROR();
}
// Test that we don't re-allocate a bound framebuffer ID, other pattern.
TEST_P(ObjectAllocationTestES3, BindFramebufferAfterGen)
{
GLuint firstFBO = 0;
glGenFramebuffers(1, &firstFBO);
glBindFramebuffer(GL_FRAMEBUFFER, 1);
glDeleteFramebuffers(1, &firstFBO);
glBindFramebuffer(GL_FRAMEBUFFER, 2);
GLuint secondFBOs[2] = {0};
glGenFramebuffers(2, secondFBOs);
EXPECT_NE(2u, secondFBOs[0]);
EXPECT_NE(2u, secondFBOs[1]);
glDeleteFramebuffers(2, secondFBOs);
EXPECT_GL_NO_ERROR();
}
// Test that we don't re-allocate a bound framebuffer ID.
TEST_P(ObjectAllocationTest, BindRenderbuffer)
{
GLuint rbId;
glGenRenderbuffers(1, &rbId);
glBindRenderbuffer(GL_RENDERBUFFER, rbId);
EXPECT_GL_NO_ERROR();
// Swap now to trigger the serialization of the renderbuffer that
// was initialized with the default values
swapBuffers();
glDeleteRenderbuffers(1, &rbId);
EXPECT_GL_NO_ERROR();
}
} // anonymous namespace
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(ObjectAllocationTest);
ANGLE_INSTANTIATE_TEST_ES2(ObjectAllocationTest);
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(ObjectAllocationTestES3);
ANGLE_INSTANTIATE_TEST_ES3(ObjectAllocationTestES3);