Hash :
30c9bd21
Author :
Date :
2023-08-21T13:17:21
Mark more TraceFunctions methods as pure virtual
Otherwise there's expected to be an implementation of them,
causing breakages like
ld.lld: error: undefined symbol: typeinfo for angle::TraceFunctions
Change-Id: Ieda87db9983a08c139ce7cf2ad962d33c1eeeac2
Bug: chromium:1453674
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4799335
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Auto-Submit: Arthur Eubanks <aeubanks@google.com>
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82
//
// Copyright 2023 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// trace_interface:
// Interface shared between trace libraries and the test suite.
//
#ifndef UTIL_CAPTURE_TRACE_INTERFACE_H_
#define UTIL_CAPTURE_TRACE_INTERFACE_H_
#include <string>
#include <vector>
namespace angle
{
static constexpr size_t kTraceInfoMaxNameLen = 128;
enum class ReplayResourceMode
{
Active,
All,
};
struct TraceInfo
{
char name[kTraceInfoMaxNameLen];
bool initialized = false;
uint32_t contextClientMajorVersion;
uint32_t contextClientMinorVersion;
uint32_t frameStart;
uint32_t frameEnd;
uint32_t drawSurfaceWidth;
uint32_t drawSurfaceHeight;
uint32_t drawSurfaceColorSpace;
uint32_t displayPlatformType;
uint32_t displayDeviceType;
int configRedBits;
int configBlueBits;
int configGreenBits;
int configAlphaBits;
int configDepthBits;
int configStencilBits;
bool isBinaryDataCompressed;
bool areClientArraysEnabled;
bool isBindGeneratesResourcesEnabled;
bool isWebGLCompatibilityEnabled;
bool isRobustResourceInitEnabled;
std::vector<std::string> traceFiles;
int windowSurfaceContextId;
std::vector<std::string> requiredExtensions;
std::vector<int> keyFrames;
};
// Test suite calls into the trace library (fixture).
struct TraceFunctions
{
virtual void SetupReplay() = 0;
virtual void ReplayFrame(uint32_t frameIndex) = 0;
virtual void ResetReplay() = 0;
virtual void FinishReplay() = 0;
virtual void SetBinaryDataDir(const char *dataDir) = 0;
virtual void SetReplayResourceMode(const ReplayResourceMode resourceMode) = 0;
virtual void SetTraceGzPath(const std::string &traceGzPath) = 0;
virtual void SetTraceInfo(const TraceInfo &traceInfo) = 0;
virtual ~TraceFunctions() {}
};
// Trace library (fixture) calls into the test suite.
struct TraceCallbacks
{
virtual uint8_t *LoadBinaryData(const char *fileName) = 0;
virtual ~TraceCallbacks() {}
};
} // namespace angle
#endif // UTIL_CAPTURE_TRACE_INTERFACE_H_