kc3-lang/angle/src/libANGLE/Error.inc

Branch : - branch - main - tag -

• Show log

  Commit

• Author : George Burgess IV
  Date : 2020-10-07 12:02:14
  Hash : c759206c
  Message : fix an instance of bugprone-unused-return-value This new clang-tidy check fires when the result of a function like `unique_ptr.release()` is unused. Sometimes this is intentional, other times, it's not (e.g., the dev intended to `.reset()`). Bug: chromium:1134714 Change-Id: I9b6bc9e847e5c27d68707a4f33d37b225ded34fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458188 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>

• src/libANGLE/Error.inc

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  
  // Error.inc: Inline definitions of egl::Error and gl::Error classes which encapsulate API errors
  // and optional error messages.
  
  #include "common/angleutils.h"
  
  #include <cstdarg>
  
  namespace egl
  {
  
  Error::Error(EGLint errorCode)
      : mCode(errorCode),
        mID(0)
  {
  }
  
  Error::Error(const Error &other)
      : mCode(other.mCode),
        mID(other.mID)
  {
      if (other.mMessage)
      {
          createMessageString();
          *mMessage = *(other.mMessage);
      }
  }
  
  Error::Error(Error &&other)
      : mCode(other.mCode),
        mID(other.mID),
        mMessage(std::move(other.mMessage))
  {
  }
  
  Error &Error::operator=(const Error &other)
  {
      mCode = other.mCode;
      mID = other.mID;
  
      if (other.mMessage)
      {
          createMessageString();
          *mMessage = *(other.mMessage);
      }
      else
      {
          mMessage.reset();
      }
  
      return *this;
  }
  
  Error &Error::operator=(Error &&other)
  {
      if (this != &other)
      {
          mCode = other.mCode;
          mID = other.mID;
          mMessage = std::move(other.mMessage);
      }
  
      return *this;
  }
  
  EGLint Error::getCode() const
  {
      return mCode;
  }
  
  EGLint Error::getID() const
  {
      return mID;
  }
  
  bool Error::isError() const
  {
      return (mCode != EGL_SUCCESS);
  }
  
  // Static
  Error Error::NoError()
  {
      return Error(EGL_SUCCESS);
  }
  
  }