Hash :
eb0d5997
Author :
Date :
2023-09-15T16:41:13
Move set/get uniform machinery to ProgramExecutable This is done because some uniforms are internally added by the compiler (draw ID, base vertex, and base instance) and are automatically set **on the installed executable**. This change fixes scenarios where a draw is done after a program has failed a relink, and therefore is unable to correctly set the uniforms (as it does not have access to the executable that is installed). It also fixes draws that use those uniforms in a PPO. Bug: angleproject:8297 Change-Id: Id74b4984b88aa09b5b81be1c91412d6c91711136 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4864693 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
//
// Copyright 2023 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// ProgramExecutableNULL.cpp: Implementation of ProgramExecutableNULL.
#include "libANGLE/renderer/null/ProgramExecutableNULL.h"
namespace rx
{
ProgramExecutableNULL::ProgramExecutableNULL(const gl::ProgramExecutable *executable)
: ProgramExecutableImpl(executable)
{}
ProgramExecutableNULL::~ProgramExecutableNULL() = default;
void ProgramExecutableNULL::destroy(const gl::Context *context) {}
void ProgramExecutableNULL::setUniform1fv(GLint location, GLsizei count, const GLfloat *v) {}
void ProgramExecutableNULL::setUniform2fv(GLint location, GLsizei count, const GLfloat *v) {}
void ProgramExecutableNULL::setUniform3fv(GLint location, GLsizei count, const GLfloat *v) {}
void ProgramExecutableNULL::setUniform4fv(GLint location, GLsizei count, const GLfloat *v) {}
void ProgramExecutableNULL::setUniform1iv(GLint location, GLsizei count, const GLint *v) {}
void ProgramExecutableNULL::setUniform2iv(GLint location, GLsizei count, const GLint *v) {}
void ProgramExecutableNULL::setUniform3iv(GLint location, GLsizei count, const GLint *v) {}
void ProgramExecutableNULL::setUniform4iv(GLint location, GLsizei count, const GLint *v) {}
void ProgramExecutableNULL::setUniform1uiv(GLint location, GLsizei count, const GLuint *v) {}
void ProgramExecutableNULL::setUniform2uiv(GLint location, GLsizei count, const GLuint *v) {}
void ProgramExecutableNULL::setUniform3uiv(GLint location, GLsizei count, const GLuint *v) {}
void ProgramExecutableNULL::setUniform4uiv(GLint location, GLsizei count, const GLuint *v) {}
void ProgramExecutableNULL::setUniformMatrix2fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix3fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix4fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix2x3fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix3x2fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix2x4fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix4x2fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix3x4fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::setUniformMatrix4x3fv(GLint location,
GLsizei count,
GLboolean transpose,
const GLfloat *value)
{}
void ProgramExecutableNULL::getUniformfv(const gl::Context *context,
GLint location,
GLfloat *params) const
{
// TODO: Write some values.
}
void ProgramExecutableNULL::getUniformiv(const gl::Context *context,
GLint location,
GLint *params) const
{
// TODO: Write some values.
}
void ProgramExecutableNULL::getUniformuiv(const gl::Context *context,
GLint location,
GLuint *params) const
{
// TODO: Write some values.
}
} // namespace rx