kc3-lang/angle/src

Diff

• Show log

  Commit

• Hash : a1bf828d
  Author :
  Date : 2023-02-13T21:30:38
  

  Vulkan: Rename "RendererVk::waitFor*ToBeSubmitted()" methods.
  
  Following "RendererVk" methods are a little bit confusing:
  - submitCommands()
  - hasResourceUseSubmitted()
  - hasQueueSerialSubmitted()
  - waitForResourceUseToBeSubmitted()
  - waitForQueueSerialToBeSubmitted()
  
  Because after "RendererVk::submitCommands(..., submitQueueSerial)" call
  "hasQueueSerialSubmitted(submitQueueSerial)" will always return "true".
  And it is not clear why need to call "waitForResourceUseToBeSubmitted()"
  method, if it already "Submitted". It is even more: it is technically
  illegal to call "waitFor*ToBeSubmitted()" if "has*Submitted" is "false".
  
  This refactoring suggests adding "ToDevice" to the methods names:
  - waitForResourceUseToBeSubmittedToDevice()
  - waitForQueueSerialToBeSubmittedToDevice()
  
  So that:
  - "Submitted"         - will mean to the RendererVk (and maybe Device)
  - "SubmittedToDevice" - definitely submitted to the Device.
  
  Bug: b/267348918
  Change-Id: I12323be3ddc0cbcff4667e52a37089b187b63fe8
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4245423
  Reviewed-by: Charlie Lao <cclao@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

• Files

• android_system_settings/
• angle_program_serialize_data_version.gni
• commit_id.py
• common/
• compiler.gni
• compiler/
• copy_compiler_dll.bat
• feature_support_util/
• gpu_info_util/
• image_util/
• libANGLE/
• libEGL/
• libGLESv1_CM/
• libGLESv2.gni
• libGLESv2/
• libOpenCL/
• program_serialize_data_version.py
• tests/
• third_party/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags