Hash :
9d0e2851
Author :
Date :
2021-09-01T00:42:58
Fix SeparateDeclarations vs struct specifiers Bug: chromium:1237696 Change-Id: I3b00f3797800e814ca83226a8e4f25b2a43cc641 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3133824 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133
//
// Copyright 2020 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include <algorithm>
#include <unordered_map>
#include "compiler/translator/SymbolTable.h"
#include "compiler/translator/TranslatorMetalDirect.h"
#include "compiler/translator/TranslatorMetalDirect/AstHelpers.h"
#include "compiler/translator/TranslatorMetalDirect/IntermRebuild.h"
#include "compiler/translator/TranslatorMetalDirect/ReduceInterfaceBlocks.h"
#include "compiler/translator/tree_ops/SeparateDeclarations.h"
using namespace sh;
////////////////////////////////////////////////////////////////////////////////
namespace
{
class Reducer : public TIntermRebuild
{
std::unordered_map<const TInterfaceBlock *, const TVariable *> mLiftedMap;
std::unordered_map<const TVariable *, const TVariable *> mInstanceMap;
IdGen &mIdGen;
public:
Reducer(TCompiler &compiler, IdGen &idGen)
: TIntermRebuild(compiler, true, false), mIdGen(idGen)
{}
PreResult visitDeclarationPre(TIntermDeclaration &declNode) override
{
ASSERT(declNode.getChildCount() == 1);
TIntermNode &node = *declNode.getChildNode(0);
if (TIntermSymbol *symbolNode = node.getAsSymbolNode())
{
const TVariable &var = symbolNode->variable();
const TType &type = var.getType();
const SymbolType symbolType = var.symbolType();
if (const TInterfaceBlock *interfaceBlock = type.getInterfaceBlock())
{
if (symbolType == SymbolType::Empty)
{
// Create instance variable
auto &structure =
*new TStructure(&mSymbolTable, interfaceBlock->name(),
&interfaceBlock->fields(), interfaceBlock->symbolType());
auto &structVar = CreateStructTypeVariable(mSymbolTable, structure);
auto &instanceVar = CreateInstanceVariable(
mSymbolTable, structure, mIdGen.createNewName(interfaceBlock->name()),
TQualifier::EvqBuffer, &type.getArraySizes());
mLiftedMap[interfaceBlock] = &instanceVar;
TIntermNode *replacements[] = {
new TIntermDeclaration{new TIntermSymbol(&structVar)},
new TIntermDeclaration{new TIntermSymbol(&instanceVar)}};
return PreResult::Multi(std::begin(replacements), std::end(replacements));
}
else
{
ASSERT(type.getQualifier() == TQualifier::EvqUniform);
auto &structure =
*new TStructure(&mSymbolTable, interfaceBlock->name(),
&interfaceBlock->fields(), interfaceBlock->symbolType());
auto &structVar = CreateStructTypeVariable(mSymbolTable, structure);
auto &instanceVar =
CreateInstanceVariable(mSymbolTable, structure, Name(var),
TQualifier::EvqBuffer, &type.getArraySizes());
mInstanceMap[&var] = &instanceVar;
TIntermNode *replacements[] = {
new TIntermDeclaration{new TIntermSymbol(&structVar)},
new TIntermDeclaration{new TIntermSymbol(&instanceVar)}};
return PreResult::Multi(std::begin(replacements), std::end(replacements));
}
}
}
return {declNode, VisitBits::Both};
}
PreResult visitSymbolPre(TIntermSymbol &symbolNode) override
{
const TVariable &var = symbolNode.variable();
{
auto it = mInstanceMap.find(&var);
if (it != mInstanceMap.end())
{
return *new TIntermSymbol(it->second);
}
}
if (const TInterfaceBlock *ib = var.getType().getInterfaceBlock())
{
auto it = mLiftedMap.find(ib);
if (it != mLiftedMap.end())
{
return AccessField(*(it->second), var.name());
}
}
return symbolNode;
}
};
} // anonymous namespace
////////////////////////////////////////////////////////////////////////////////
bool sh::ReduceInterfaceBlocks(TCompiler &compiler,
TIntermBlock &root,
IdGen &idGen,
TSymbolTable *symbolTable)
{
Reducer reducer(compiler, idGen);
if (!reducer.rebuildRoot(root))
{
return false;
}
if (!SeparateDeclarations(&compiler, &root, symbolTable))
{
return false;
}
return true;
}