kc3-lang/angle/src/common/MemoryBuffer.cpp

• Show log

  Commit

• Hash : a36f8bd4
  Author :
  Date : 2020-01-29T12:10:17
  

  Mark MemoryBuffer allocation functions as NO_DISCARD
  
  Not all call sites were checking the return value of
  MemoryBuffer::resize, mark the return value as NO_DISCARD and fix all
  the warnings.
  
  BUG=chromium:1030835
  
  Change-Id: I762796e3d11efc131a814069d78a195b0d4c9f8f
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028151
  Commit-Queue: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/common/MemoryBuffer.cpp

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "common/MemoryBuffer.h"
  
  #include <algorithm>
  #include <cstdlib>
  
  #include "common/debug.h"
  
  namespace angle
  {
  
  // MemoryBuffer implementation.
  MemoryBuffer::~MemoryBuffer()
  {
      free(mData);
      mData = nullptr;
  }
  
  bool MemoryBuffer::resize(size_t size)
  {
      if (size == 0)
      {
          free(mData);
          mData = nullptr;
          mSize = 0;
          return true;
      }
  
      if (size == mSize)
      {
          return true;
      }
  
      // Only reallocate if the size has changed.
      uint8_t *newMemory = static_cast<uint8_t *>(malloc(sizeof(uint8_t) * size));
      if (newMemory == nullptr)
      {
          return false;
      }
  
      if (mData)
      {
          // Copy the intersection of the old data and the new data
          std::copy(mData, mData + std::min(mSize, size), newMemory);
          free(mData);
      }
  
      mData = newMemory;
      mSize = size;
  
      return true;
  }
  
  void MemoryBuffer::fill(uint8_t datum)
  {
      if (!empty())
      {
          std::fill(mData, mData + mSize, datum);
      }
  }
  
  MemoryBuffer::MemoryBuffer(MemoryBuffer &&other) : MemoryBuffer()
  {
      *this = std::move(other);
  }
  
  MemoryBuffer &MemoryBuffer::operator=(MemoryBuffer &&other)
  {
      std::swap(mSize, other.mSize);
      std::swap(mData, other.mData);
      return *this;
  }
  
  // ScratchBuffer implementation.
  
  ScratchBuffer::ScratchBuffer(uint32_t lifetime) : mLifetime(lifetime), mResetCounter(lifetime) {}
  
  ScratchBuffer::~ScratchBuffer() {}
  
  bool ScratchBuffer::get(size_t requestedSize, MemoryBuffer **memoryBufferOut)
  {
      return getImpl(requestedSize, memoryBufferOut, Optional<uint8_t>::Invalid());
  }
  
  bool ScratchBuffer::getInitialized(size_t requestedSize,
                                     MemoryBuffer **memoryBufferOut,
                                     uint8_t initValue)
  {
      return getImpl(requestedSize, memoryBufferOut, Optional<uint8_t>(initValue));
  }
  
  bool ScratchBuffer::getImpl(size_t requestedSize,
                              MemoryBuffer **memoryBufferOut,
                              Optional<uint8_t> initValue)
  {
      if (mScratchMemory.size() == requestedSize)
      {
          mResetCounter    = mLifetime;
          *memoryBufferOut = &mScratchMemory;
          return true;
      }
  
      if (mScratchMemory.size() > requestedSize)
      {
          tick();
      }
  
      if (mResetCounter == 0 || mScratchMemory.size() < requestedSize)
      {
          clear();
          if (!mScratchMemory.resize(requestedSize))
          {
              return false;
          }
          mResetCounter = mLifetime;
          if (initValue.valid())
          {
              mScratchMemory.fill(initValue.value());
          }
      }
  
      ASSERT(mScratchMemory.size() >= requestedSize);
  
      *memoryBufferOut = &mScratchMemory;
      return true;
  }
  
  void ScratchBuffer::tick()
  {
      if (mResetCounter > 0)
      {
          --mResetCounter;
      }
  }
  
  void ScratchBuffer::clear()
  {
      mResetCounter = mLifetime;
      mScratchMemory.clear();
  }
  
  }  // namespace angle
  

Download