kc3-lang/angle/src/libANGLE/renderer/SurfaceImpl.cpp

• Show log

  Commit

• Hash : 317f81db
  Author :
  Date : 2025-05-01T14:17:47
  

  Fix EGL_RENDER_BUFFER query if EGL_SINGLE_BUFFER unsupported
  
  eglCreateWindowSurface() can have the EGL attribute EGL_RENDER_BUFFER
  specified:
  
    EGL_RENDER_BUFFER specifies which buffer should be used by default for
    client API rendering to the window, as described in section 2.2.2. If
    its value is EGL_SINGLE_BUFFER, then client APIs should render
    directly into the visible window. If its value is EGL_BACK_BUFFER,
    then all client APIs should render into the back buffer. The default
    value of EGL_RENDER_BUFFER is EGL_BACK_BUFFER.
    Client APIs may not be able to respect the requested rendering buffer.
    To determine the actual buffer that a context will render to by
    default, call eglQueryContext with attribute EGL_RENDER_BUFFER (see
    section 3.7.4).
  
  To support EGL_SINGLE_BUFFER, Vulkan surfaces must support the
  VkPresentModeKHR value VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR:
  
    VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR specifies that the
    presentation engine and application have concurrent access to a single
    image, which is referred to as a shared presentable image. The
    presentation engine is only required to update the current image after
    a new presentation request is received. Therefore the application must
    make a presentation request whenever an update is required. However,
    the presentation engine may update the current image at any point,
    meaning this mode may result in visible tearing.
  
  However, this is only available on Vulkan devices that support the
  extension VK_KHR_shared_presentable_image.
  
  Add checking in Surface::initialize() to update Surface::mRenderBuffer
  to EGL_BACK_BUFFER if the backend implementation does not support
  EGL_SINGLE_BUFFER. This includes adding supportsSingleRenderBuffer() to
  query the backend if it supports single render buffer mode, which
  defaults to False. The Vulkan backend overrides this and the result is
  based on support for VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR.
  
  Bug: b/412446258
  Test: EGLLockSurface3Test.WindowMsaaSurfaceReadTest/ES2_Vulkan_NoFixture
  Test: EGLSingleBufferTest.VerifyMutableRenderBufferKHR/*
  Change-Id: I4e6d56f01a895a5bd887580e6ffa34d574c87fad
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6506764
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/renderer/SurfaceImpl.cpp

• //
  // Copyright 2002 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // SurfaceImpl.cpp: Implementation of Surface stub method class
  
  #include "libANGLE/renderer/SurfaceImpl.h"
  
  namespace rx
  {
  
  SurfaceImpl::SurfaceImpl(const egl::SurfaceState &state) : mState(state) {}
  
  SurfaceImpl::~SurfaceImpl() {}
  
  egl::Error SurfaceImpl::makeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::unMakeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::prepareSwap(const gl::Context *)
  {
      return angle::ResultToEGL(angle::Result::Continue);
  }
  
  egl::Error SurfaceImpl::swapWithDamage(const gl::Context *context,
                                         const EGLint *rects,
                                         EGLint n_rects,
                                         SurfaceSwapFeedback *feedback)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "swapWithDamage implementation missing.");
  }
  
  egl::Error SurfaceImpl::postSubBuffer(const gl::Context *context,
                                        EGLint x,
                                        EGLint y,
                                        EGLint width,
                                        EGLint height)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "getMscRate implementation missing.");
  }
  
  egl::Error SurfaceImpl::setPresentationTime(EGLnsecsANDROID time)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "setPresentationTime implementation missing.");
  }
  
  egl::Error SurfaceImpl::querySurfacePointerANGLE(EGLint attribute, void **value)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "querySurfacePointerANGLE implementation missing.");
  }
  
  egl::Error SurfaceImpl::getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "getSyncValues implementation missing.");
  }
  
  egl::Error SurfaceImpl::getMscRate(EGLint *numerator, EGLint *denominator)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_SURFACE, "getMscRate implementation missing.");
  }
  
  void SurfaceImpl::setFixedWidth(EGLint width)
  {
      UNREACHABLE();
  }
  
  void SurfaceImpl::setFixedHeight(EGLint height)
  {
      UNREACHABLE();
  }
  
  void SurfaceImpl::setTimestampsEnabled(bool enabled)
  {
      UNREACHABLE();
  }
  
  const angle::Format *SurfaceImpl::getD3DTextureColorFormat() const
  {
      UNREACHABLE();
      return nullptr;
  }
  
  egl::SupportedCompositorTimings SurfaceImpl::getSupportedCompositorTimings() const
  {
      UNREACHABLE();
      return egl::SupportedCompositorTimings();
  }
  
  egl::Error SurfaceImpl::getCompositorTiming(EGLint numTimestamps,
                                              const EGLint *names,
                                              EGLnsecsANDROID *values) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY);
  }
  
  egl::Error SurfaceImpl::getNextFrameId(EGLuint64KHR *frameId) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY);
  }
  
  egl::SupportedTimestamps SurfaceImpl::getSupportedTimestamps() const
  {
      UNREACHABLE();
      return egl::SupportedTimestamps();
  }
  
  egl::Error SurfaceImpl::getFrameTimestamps(EGLuint64KHR frameId,
                                             EGLint numTimestamps,
                                             const EGLint *timestamps,
                                             EGLnsecsANDROID *values) const
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_DISPLAY);
  }
  egl::Error SurfaceImpl::getUserWidth(const egl::Display *display, EGLint *value) const
  {
      *value = getWidth();
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::getUserHeight(const egl::Display *display, EGLint *value) const
  {
      *value = getHeight();
      return egl::NoError();
  }
  
  EGLint SurfaceImpl::isPostSubBufferSupported() const
  {
      UNREACHABLE();
      return EGL_FALSE;
  }
  
  egl::Error SurfaceImpl::getBufferAge(const gl::Context *context, EGLint *age)
  {
      *age = 0;
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::setAutoRefreshEnabled(bool enabled)
  {
      return egl::Error(EGL_BAD_MATCH);
  }
  
  egl::Error SurfaceImpl::lockSurface(const egl::Display *display,
                                      EGLint usageHint,
                                      bool preservePixels,
                                      uint8_t **bufferPtrOut,
                                      EGLint *bufferPitchOut)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_MATCH);
  }
  
  egl::Error SurfaceImpl::unlockSurface(const egl::Display *display, bool preservePixels)
  {
      UNREACHABLE();
      return egl::Error(EGL_BAD_MATCH);
  }
  
  EGLint SurfaceImpl::origin() const
  {
      return EGL_LOWER_LEFT_KHR;
  }
  
  egl::Error SurfaceImpl::setRenderBuffer(EGLint renderBuffer)
  {
      return egl::NoError();
  }
  
  EGLint SurfaceImpl::getCompressionRate(const egl::Display *display) const
  {
      UNREACHABLE();
      return EGL_SURFACE_COMPRESSION_FIXED_RATE_NONE_EXT;
  }
  
  bool SurfaceImpl::supportsSingleRenderBuffer() const
  {
      return false;
  }
  
  }  // namespace rx
  

Download