kc3-lang/angle/src/libANGLE/renderer/SurfaceImpl.h

• Show log

  Commit

• Hash : 317f81db
  Author :
  Date : 2025-05-01T14:17:47
  

  Fix EGL_RENDER_BUFFER query if EGL_SINGLE_BUFFER unsupported
  
  eglCreateWindowSurface() can have the EGL attribute EGL_RENDER_BUFFER
  specified:
  
    EGL_RENDER_BUFFER specifies which buffer should be used by default for
    client API rendering to the window, as described in section 2.2.2. If
    its value is EGL_SINGLE_BUFFER, then client APIs should render
    directly into the visible window. If its value is EGL_BACK_BUFFER,
    then all client APIs should render into the back buffer. The default
    value of EGL_RENDER_BUFFER is EGL_BACK_BUFFER.
    Client APIs may not be able to respect the requested rendering buffer.
    To determine the actual buffer that a context will render to by
    default, call eglQueryContext with attribute EGL_RENDER_BUFFER (see
    section 3.7.4).
  
  To support EGL_SINGLE_BUFFER, Vulkan surfaces must support the
  VkPresentModeKHR value VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR:
  
    VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR specifies that the
    presentation engine and application have concurrent access to a single
    image, which is referred to as a shared presentable image. The
    presentation engine is only required to update the current image after
    a new presentation request is received. Therefore the application must
    make a presentation request whenever an update is required. However,
    the presentation engine may update the current image at any point,
    meaning this mode may result in visible tearing.
  
  However, this is only available on Vulkan devices that support the
  extension VK_KHR_shared_presentable_image.
  
  Add checking in Surface::initialize() to update Surface::mRenderBuffer
  to EGL_BACK_BUFFER if the backend implementation does not support
  EGL_SINGLE_BUFFER. This includes adding supportsSingleRenderBuffer() to
  query the backend if it supports single render buffer mode, which
  defaults to False. The Vulkan backend overrides this and the result is
  based on support for VK_PRESENT_MODE_SHARED_DEMAND_REFRESH_KHR.
  
  Bug: b/412446258
  Test: EGLLockSurface3Test.WindowMsaaSurfaceReadTest/ES2_Vulkan_NoFixture
  Test: EGLSingleBufferTest.VerifyMutableRenderBufferKHR/*
  Change-Id: I4e6d56f01a895a5bd887580e6ffa34d574c87fad
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6506764
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/renderer/SurfaceImpl.h

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // SurfaceImpl.h: Implementation methods of egl::Surface
  
  #ifndef LIBANGLE_RENDERER_SURFACEIMPL_H_
  #define LIBANGLE_RENDERER_SURFACEIMPL_H_
  
  #include <EGL/egl.h>
  #include <EGL/eglext.h>
  
  #include "common/angleutils.h"
  #include "libANGLE/Error.h"
  #include "libANGLE/FramebufferAttachment.h"
  #include "libANGLE/renderer/FramebufferAttachmentObjectImpl.h"
  
  namespace angle
  {
  struct Format;
  }
  
  namespace gl
  {
  class Context;
  class FramebufferState;
  }  // namespace gl
  
  namespace egl
  {
  class Display;
  struct Config;
  struct SurfaceState;
  class Thread;
  
  using SupportedTimestamps        = angle::PackedEnumBitSet<Timestamp>;
  using SupportedCompositorTimings = angle::PackedEnumBitSet<CompositorTiming>;
  }  // namespace egl
  
  namespace rx
  {
  struct SurfaceSwapFeedback
  {
      bool swapChainImageChanged = false;
  };
  
  class SurfaceImpl : public FramebufferAttachmentObjectImpl
  {
    public:
      SurfaceImpl(const egl::SurfaceState &surfaceState);
      ~SurfaceImpl() override;
      virtual void destroy(const egl::Display *display) {}
  
      virtual egl::Error initialize(const egl::Display *display) = 0;
      virtual egl::Error makeCurrent(const gl::Context *context);
      virtual egl::Error unMakeCurrent(const gl::Context *context);
      virtual egl::Error prepareSwap(const gl::Context *);
      virtual egl::Error swap(const gl::Context *context, SurfaceSwapFeedback *feedback) = 0;
      virtual egl::Error swapWithDamage(const gl::Context *context,
                                        const EGLint *rects,
                                        EGLint n_rects,
                                        SurfaceSwapFeedback *feedback);
      virtual egl::Error postSubBuffer(const gl::Context *context,
                                       EGLint x,
                                       EGLint y,
                                       EGLint width,
                                       EGLint height);
      virtual egl::Error setPresentationTime(EGLnsecsANDROID time);
      virtual egl::Error querySurfacePointerANGLE(EGLint attribute, void **value);
      virtual egl::Error bindTexImage(const gl::Context *context,
                                      gl::Texture *texture,
                                      EGLint buffer)                                = 0;
      virtual egl::Error releaseTexImage(const gl::Context *context, EGLint buffer) = 0;
      virtual egl::Error getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc);
      virtual egl::Error getMscRate(EGLint *numerator, EGLint *denominator);
      virtual void setSwapInterval(const egl::Display *display, EGLint interval) = 0;
      virtual void setFixedWidth(EGLint width);
      virtual void setFixedHeight(EGLint height);
  
      // width and height can change with client window resizing
      virtual EGLint getWidth() const  = 0;
      virtual EGLint getHeight() const = 0;
      // Sizes that Surface will have after render target is first accessed (e.g. after draw).
      virtual egl::Error getUserWidth(const egl::Display *display, EGLint *value) const;
      virtual egl::Error getUserHeight(const egl::Display *display, EGLint *value) const;
  
      virtual EGLint isPostSubBufferSupported() const;
      virtual EGLint getSwapBehavior() const = 0;
  
      virtual egl::Error attachToFramebuffer(const gl::Context *context,
                                             gl::Framebuffer *framebuffer)   = 0;
      virtual egl::Error detachFromFramebuffer(const gl::Context *context,
                                               gl::Framebuffer *framebuffer) = 0;
  
      // Used to query color format from pbuffers created from D3D textures.
      virtual const angle::Format *getD3DTextureColorFormat() const;
  
      // EGL_ANDROID_get_frame_timestamps
      virtual void setTimestampsEnabled(bool enabled);
      virtual egl::SupportedCompositorTimings getSupportedCompositorTimings() const;
      virtual egl::Error getCompositorTiming(EGLint numTimestamps,
                                             const EGLint *names,
                                             EGLnsecsANDROID *values) const;
      virtual egl::Error getNextFrameId(EGLuint64KHR *frameId) const;
      virtual egl::SupportedTimestamps getSupportedTimestamps() const;
      virtual egl::Error getFrameTimestamps(EGLuint64KHR frameId,
                                            EGLint numTimestamps,
                                            const EGLint *timestamps,
                                            EGLnsecsANDROID *values) const;
      virtual egl::Error getBufferAge(const gl::Context *context, EGLint *age);
  
      // EGL_ANDROID_front_buffer_auto_refresh
      virtual egl::Error setAutoRefreshEnabled(bool enabled);
  
      // EGL_KHR_lock_surface3
      virtual egl::Error lockSurface(const egl::Display *display,
                                     EGLint usageHint,
                                     bool preservePixels,
                                     uint8_t **bufferPtrOut,
                                     EGLint *bufferPitchOut);
      virtual egl::Error unlockSurface(const egl::Display *display, bool preservePixels);
      virtual EGLint origin() const;
  
      virtual egl::Error setRenderBuffer(EGLint renderBuffer);
  
      virtual EGLint getCompressionRate(const egl::Display *display) const;
  
      virtual bool supportsSingleRenderBuffer() const;
  
    protected:
      const egl::SurfaceState &mState;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_SURFACEIMPL_H_
  

Download