Hash :
cfb430c8
Author :
Date :
2025-02-10T13:19:05
Remove angle::ErrorStream helper Most uses of the helper either use just the code or a fixed string, which compiles to a few instructions. Using this helper adds 200+ bytes of assembly to each use, due to the unneeded instantiation of ostringstream which allocates a buffer etc. The combined effect of this CL on an Android perf build is ~12KB (0.2%) reduction in size. The cases where the message is actually formatted are converted to an explicit use of ostringstream. Removing the helper so that the new code is explicit about the intent to use ostringstream, or an alternative way to format the message. Discovered accidentally while looking into size reduction due to __builtin_unreachable() Semi-automated code change, risk of copy-paste mistakes should be minimal. Bug: angleproject:394129077 Change-Id: I47c2642d750d31416b08a1cfa435d5463c294e35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6250078 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// StreamProducerD3DTexture.cpp: Implements the stream producer for D3D11 textures
#include "libANGLE/renderer/d3d/d3d11/StreamProducerD3DTexture.h"
#include "common/utilities.h"
#include "libANGLE/renderer/d3d/d3d11/Renderer11.h"
#include "libANGLE/renderer/d3d/d3d11/renderer11_utils.h"
#include <array>
namespace rx
{
namespace
{
egl::Error GetGLDescFromTex(ID3D11Texture2D *const tex,
const UINT planeIndex,
egl::Stream::GLTextureDescription *const out)
{
if (!tex)
return egl::Error(EGL_BAD_PARAMETER, "Texture is null");
D3D11_TEXTURE2D_DESC desc;
tex->GetDesc(&desc);
if (desc.Width < 1 || desc.Height < 1)
return egl::Error(EGL_BAD_PARAMETER, "Width or height < 1");
out->width = desc.Width;
out->height = desc.Height;
out->mipLevels = 0;
std::array<uint32_t, 2> planeFormats = {};
switch (desc.Format)
{
case DXGI_FORMAT_NV12:
planeFormats = {GL_R8, GL_RG8};
break;
case DXGI_FORMAT_P010:
case DXGI_FORMAT_P016:
planeFormats = {GL_R16_EXT, GL_RG16_EXT};
break;
case DXGI_FORMAT_R8_UNORM:
planeFormats = {GL_R8};
break;
case DXGI_FORMAT_R8G8_UNORM:
planeFormats[0] = GL_RG8;
break;
case DXGI_FORMAT_R8G8B8A8_UNORM:
planeFormats[0] = GL_RGBA8;
break;
case DXGI_FORMAT_B8G8R8A8_UNORM:
planeFormats[0] = GL_BGRA8_EXT;
break;
case DXGI_FORMAT_R16_UNORM:
planeFormats[0] = GL_R16_EXT;
break;
case DXGI_FORMAT_R16G16_UNORM:
planeFormats[0] = GL_RG16_EXT;
break;
case DXGI_FORMAT_R16G16B16A16_UNORM:
planeFormats[0] = GL_RGBA16_EXT;
break;
case DXGI_FORMAT_R16G16B16A16_FLOAT:
planeFormats[0] = GL_RGBA16F;
break;
default:
return egl::Error(EGL_BAD_PARAMETER, "Unsupported format");
}
if (planeFormats[1]) // If we have YUV planes, expect 4:2:0.
{
if ((desc.Width % 2) != 0 || (desc.Height % 2) != 0)
return egl::Error(EGL_BAD_PARAMETER,
"YUV 4:2:0 textures must have even width and height.");
}
if (planeIndex > 0)
{
out->width /= 2;
out->height /= 2;
}
out->internalFormat = 0;
if (planeIndex < planeFormats.size())
{
out->internalFormat = planeFormats[planeIndex];
}
if (!out->internalFormat)
return egl::Error(EGL_BAD_PARAMETER, "Plane out of range");
return egl::NoError();
}
} // namespace
StreamProducerD3DTexture::StreamProducerD3DTexture(Renderer11 *renderer)
: mRenderer(renderer), mTexture(nullptr), mArraySlice(0), mPlaneOffset(0)
{}
StreamProducerD3DTexture::~StreamProducerD3DTexture()
{
SafeRelease(mTexture);
}
egl::Error StreamProducerD3DTexture::validateD3DTexture(const void *pointer,
const egl::AttributeMap &attributes) const
{
// We must remove the const qualifier because "GetDevice" and "GetDesc" are non-const in D3D11.
ID3D11Texture2D *textureD3D = static_cast<ID3D11Texture2D *>(const_cast<void *>(pointer));
// Check that the texture originated from our device
angle::ComPtr<ID3D11Device> device;
textureD3D->GetDevice(&device);
if (device.Get() != mRenderer->getDevice())
{
return egl::Error(EGL_BAD_PARAMETER, "Texture not created on ANGLE D3D device");
}
const auto planeId = static_cast<UINT>(attributes.get(EGL_NATIVE_BUFFER_PLANE_OFFSET_IMG, 0));
egl::Stream::GLTextureDescription unused;
return GetGLDescFromTex(textureD3D, planeId, &unused);
}
void StreamProducerD3DTexture::postD3DTexture(void *pointer, const egl::AttributeMap &attributes)
{
ASSERT(pointer != nullptr);
ID3D11Texture2D *textureD3D = static_cast<ID3D11Texture2D *>(pointer);
// Release the previous texture if there is one
SafeRelease(mTexture);
mTexture = textureD3D;
mTexture->AddRef();
mPlaneOffset = static_cast<UINT>(attributes.get(EGL_NATIVE_BUFFER_PLANE_OFFSET_IMG, 0));
mArraySlice = static_cast<UINT>(attributes.get(EGL_D3D_TEXTURE_SUBRESOURCE_ID_ANGLE, 0));
}
egl::Stream::GLTextureDescription StreamProducerD3DTexture::getGLFrameDescription(int planeIndex)
{
const auto planeOffsetIndex = static_cast<UINT>(planeIndex + mPlaneOffset);
egl::Stream::GLTextureDescription ret;
ANGLE_SWALLOW_ERR(GetGLDescFromTex(mTexture, planeOffsetIndex, &ret));
return ret;
}
ID3D11Texture2D *StreamProducerD3DTexture::getD3DTexture()
{
return mTexture;
}
UINT StreamProducerD3DTexture::getArraySlice()
{
return mArraySlice;
}
} // namespace rx