kc3-lang/angle/src/libANGLE/HandleAllocator.h

• Show log

  Commit

• Hash : a7238b52
  Author :
  Date : 2022-04-28T12:04:51
  

  Consolidate handle list before pushing to mReleasedList
  
  Walk mUnallocatedList and try consolidating the range before pushing
  the to-be-released handle onto mReleasedList. This avoids a buggy
  behavior with dEQP which can be reproduced by running the following
  tests in this order -
      dEQP.GLES3/functional_samplers_single_cubemap_diff_wrap_t
      dEQP.GLES3/functional_negative_api_buffer_framebuffer_texture_layer
  
  Test: HandleAllocatorTest.ConsolidateRangeDuringRelease
  Bug: angleproject:7248
  Change-Id: I8d2701f193fc6a2f36151c09719284a7832ab2d4
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3617198
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: mohan maiya <m.maiya@samsung.com>
  

Download

• src/libANGLE/HandleAllocator.h

• //
  // Copyright 2002 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // HandleAllocator.h: Defines the gl::HandleAllocator class, which is used to
  // allocate GL handles.
  
  #ifndef LIBANGLE_HANDLEALLOCATOR_H_
  #define LIBANGLE_HANDLEALLOCATOR_H_
  
  #include "common/angleutils.h"
  
  #include "angle_gl.h"
  
  namespace gl
  {
  
  class HandleAllocator final : angle::NonCopyable
  {
    public:
      // Maximum handle = MAX_UINT-1
      HandleAllocator();
      // Specify maximum handle value. Used for testing.
      HandleAllocator(GLuint maximumHandleValue);
  
      ~HandleAllocator();
  
      void setBaseHandle(GLuint value);
  
      GLuint allocate();
      void release(GLuint handle);
      void reserve(GLuint handle);
      void reset();
  
      void enableLogging(bool enabled);
  
    private:
      GLuint mBaseValue;
      GLuint mNextValue;
  
      // Represents an inclusive range [begin, end]
      struct HandleRange
      {
          HandleRange(GLuint beginIn, GLuint endIn) : begin(beginIn), end(endIn) {}
  
          GLuint begin;
          GLuint end;
      };
  
      struct HandleRangeComparator;
  
      // The freelist consists of never-allocated handles, stored
      // as ranges, and handles that were previously allocated and
      // released, stored in a heap.
      std::vector<HandleRange> mUnallocatedList;
      std::vector<GLuint> mReleasedList;
  
      bool mLoggingEnabled;
  };
  
  }  // namespace gl
  
  #endif  // LIBANGLE_HANDLEALLOCATOR_H_
  

Download