Hash :
d375547c
Author :
Date :
2022-08-12T15:54:39
Do not link program pipeline in glUseProgramStages
1. The commit 3a9f18f135fe82 caused a link to occur everytime
glUseProgramStages is called. This is redundant since the program
pipeline can be linked just before usage, thus allowing for multiple
stages to be bound before linking the executable.
2. Mark PPO as a dirty object and link the PPO in dirty object handler
3. Early return if the same program is being bound to the same stage
of the pipeline.
4. Added ProgramPipelineObjectBenchmark perf test that switches programs
before a draw and observed following data -
1. vulkan profile -
1. wall_time before patch - 102000 ns
2. wall_time after patch - 38000 ns
2. vulkan_null profile -
1. wall_time before patch - 125000 ns
2. wall_time after patch - 52000 ns
Bug: angleproject:5102
Bug: angleproject:6566
Test: ContextNoErrorPPOTest31.*Vulkan
Test: ProgramPipelineTest31.*Vulkan
Test: ProgramPipelineObjectBenchmark*
Change-Id: Idbc2fcb4875bbd040e9ec847eb2a8f96f287173c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3830170
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
//
// Copyright 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include "libANGLE/TransformFeedback.h"
#include "common/mathutil.h"
#include "libANGLE/Buffer.h"
#include "libANGLE/Caps.h"
#include "libANGLE/Context.h"
#include "libANGLE/Program.h"
#include "libANGLE/State.h"
#include "libANGLE/renderer/GLImplFactory.h"
#include "libANGLE/renderer/TransformFeedbackImpl.h"
#include <limits>
namespace gl
{
angle::CheckedNumeric<GLsizeiptr> GetVerticesNeededForDraw(PrimitiveMode primitiveMode,
GLsizei count,
GLsizei primcount)
{
if (count < 0 || primcount < 0)
{
return 0;
}
// Transform feedback only outputs complete primitives, so we need to round down to the nearest
// complete primitive before multiplying by the number of instances.
angle::CheckedNumeric<GLsizeiptr> checkedCount = count;
angle::CheckedNumeric<GLsizeiptr> checkedPrimcount = primcount;
switch (primitiveMode)
{
case PrimitiveMode::Triangles:
return checkedPrimcount * (checkedCount - checkedCount % 3);
case PrimitiveMode::Lines:
return checkedPrimcount * (checkedCount - checkedCount % 2);
case PrimitiveMode::Points:
return checkedPrimcount * checkedCount;
default:
UNREACHABLE();
return checkedPrimcount * checkedCount;
}
}
TransformFeedbackState::TransformFeedbackState(size_t maxIndexedBuffers)
: mLabel(),
mActive(false),
mPrimitiveMode(PrimitiveMode::InvalidEnum),
mPaused(false),
mVerticesDrawn(0),
mVertexCapacity(0),
mProgram(nullptr),
mIndexedBuffers(maxIndexedBuffers)
{}
TransformFeedbackState::~TransformFeedbackState() {}
const OffsetBindingPointer<Buffer> &TransformFeedbackState::getIndexedBuffer(size_t idx) const
{
return mIndexedBuffers[idx];
}
const std::vector<OffsetBindingPointer<Buffer>> &TransformFeedbackState::getIndexedBuffers() const
{
return mIndexedBuffers;
}
GLsizeiptr TransformFeedbackState::getPrimitivesDrawn() const
{
switch (mPrimitiveMode)
{
case gl::PrimitiveMode::Points:
return mVerticesDrawn;
case gl::PrimitiveMode::Lines:
return mVerticesDrawn / 2;
case gl::PrimitiveMode::Triangles:
return mVerticesDrawn / 3;
default:
return 0;
}
}
TransformFeedback::TransformFeedback(rx::GLImplFactory *implFactory,
TransformFeedbackID id,
const Caps &caps)
: RefCountObject(implFactory->generateSerial(), id),
mState(caps.maxTransformFeedbackSeparateAttributes),
mImplementation(implFactory->createTransformFeedback(mState))
{
ASSERT(mImplementation != nullptr);
}
void TransformFeedback::onDestroy(const Context *context)
{
ASSERT(!context || !context->isCurrentTransformFeedback(this));
if (mState.mProgram)
{
mState.mProgram->release(context);
mState.mProgram = nullptr;
}
ASSERT(!mState.mProgram);
for (size_t i = 0; i < mState.mIndexedBuffers.size(); i++)
{
mState.mIndexedBuffers[i].set(context, nullptr, 0, 0);
}
if (mImplementation)
{
mImplementation->onDestroy(context);
}
}
TransformFeedback::~TransformFeedback()
{
SafeDelete(mImplementation);
}
angle::Result TransformFeedback::setLabel(const Context *context, const std::string &label)
{
mState.mLabel = label;
if (mImplementation)
{
return mImplementation->onLabelUpdate(context);
}
return angle::Result::Continue;
}
const std::string &TransformFeedback::getLabel() const
{
return mState.mLabel;
}
angle::Result TransformFeedback::begin(const Context *context,
PrimitiveMode primitiveMode,
Program *program)
{
// TODO: http://anglebug.com/5486: This method should take in as parameter a
// ProgramExecutable instead of a Program.
ANGLE_TRY(mImplementation->begin(context, primitiveMode));
mState.mActive = true;
mState.mPrimitiveMode = primitiveMode;
mState.mPaused = false;
mState.mVerticesDrawn = 0;
bindProgram(context, program);
// In one of the angle_unittests - "TransformFeedbackTest.SideEffectsOfStartAndStop"
// there is a code path where <context> is a nullptr, account for that possiblity.
const ProgramExecutable *programExecutable =
context ? context->getState().getLinkedProgramExecutable(context) : nullptr;
if (programExecutable)
{
// Compute the number of vertices we can draw before overflowing the bound buffers.
auto strides = programExecutable->getTransformFeedbackStrides();
ASSERT(strides.size() <= mState.mIndexedBuffers.size() && !strides.empty());
GLsizeiptr minCapacity = std::numeric_limits<GLsizeiptr>::max();
for (size_t index = 0; index < strides.size(); index++)
{
GLsizeiptr capacity =
GetBoundBufferAvailableSize(mState.mIndexedBuffers[index]) / strides[index];
minCapacity = std::min(minCapacity, capacity);
}
mState.mVertexCapacity = minCapacity;
}
else
{
mState.mVertexCapacity = 0;
}
return angle::Result::Continue;
}
angle::Result TransformFeedback::end(const Context *context)
{
ANGLE_TRY(mImplementation->end(context));
mState.mActive = false;
mState.mPrimitiveMode = PrimitiveMode::InvalidEnum;
mState.mPaused = false;
mState.mVerticesDrawn = 0;
mState.mVertexCapacity = 0;
if (mState.mProgram)
{
mState.mProgram->release(context);
mState.mProgram = nullptr;
}
return angle::Result::Continue;
}
angle::Result TransformFeedback::pause(const Context *context)
{
ANGLE_TRY(mImplementation->pause(context));
mState.mPaused = true;
return angle::Result::Continue;
}
angle::Result TransformFeedback::resume(const Context *context)
{
ANGLE_TRY(mImplementation->resume(context));
mState.mPaused = false;
return angle::Result::Continue;
}
bool TransformFeedback::isPaused() const
{
return mState.mPaused;
}
PrimitiveMode TransformFeedback::getPrimitiveMode() const
{
return mState.mPrimitiveMode;
}
bool TransformFeedback::checkBufferSpaceForDraw(GLsizei count, GLsizei primcount) const
{
auto vertices =
mState.mVerticesDrawn + GetVerticesNeededForDraw(mState.mPrimitiveMode, count, primcount);
return vertices.IsValid() && vertices.ValueOrDie() <= mState.mVertexCapacity;
}
void TransformFeedback::onVerticesDrawn(const Context *context, GLsizei count, GLsizei primcount)
{
ASSERT(mState.mActive && !mState.mPaused);
// All draws should be validated with checkBufferSpaceForDraw so ValueOrDie should never fail.
mState.mVerticesDrawn =
(mState.mVerticesDrawn + GetVerticesNeededForDraw(mState.mPrimitiveMode, count, primcount))
.ValueOrDie();
for (auto &buffer : mState.mIndexedBuffers)
{
if (buffer.get() != nullptr)
{
buffer->onDataChanged();
}
}
}
void TransformFeedback::bindProgram(const Context *context, Program *program)
{
if (mState.mProgram != program)
{
if (mState.mProgram != nullptr)
{
mState.mProgram->release(context);
}
mState.mProgram = program;
if (mState.mProgram != nullptr)
{
mState.mProgram->addRef();
}
}
}
bool TransformFeedback::hasBoundProgram(ShaderProgramID program) const
{
return mState.mProgram != nullptr && mState.mProgram->id().value == program.value;
}
angle::Result TransformFeedback::detachBuffer(const Context *context, BufferID bufferID)
{
bool isBound = context->isCurrentTransformFeedback(this);
for (size_t index = 0; index < mState.mIndexedBuffers.size(); index++)
{
if (mState.mIndexedBuffers[index].id() == bufferID)
{
if (isBound)
{
mState.mIndexedBuffers[index]->onTFBindingChanged(context, false, true);
}
mState.mIndexedBuffers[index].set(context, nullptr, 0, 0);
ANGLE_TRY(
mImplementation->bindIndexedBuffer(context, index, mState.mIndexedBuffers[index]));
}
}
return angle::Result::Continue;
}
angle::Result TransformFeedback::bindIndexedBuffer(const Context *context,
size_t index,
Buffer *buffer,
size_t offset,
size_t size)
{
ASSERT(index < mState.mIndexedBuffers.size());
bool isBound = context && context->isCurrentTransformFeedback(this);
if (isBound && mState.mIndexedBuffers[index].get())
{
mState.mIndexedBuffers[index]->onTFBindingChanged(context, false, true);
}
mState.mIndexedBuffers[index].set(context, buffer, offset, size);
if (isBound && buffer)
{
buffer->onTFBindingChanged(context, true, true);
}
return mImplementation->bindIndexedBuffer(context, index, mState.mIndexedBuffers[index]);
}
const OffsetBindingPointer<Buffer> &TransformFeedback::getIndexedBuffer(size_t index) const
{
ASSERT(index < mState.mIndexedBuffers.size());
return mState.mIndexedBuffers[index];
}
size_t TransformFeedback::getIndexedBufferCount() const
{
return mState.mIndexedBuffers.size();
}
bool TransformFeedback::buffersBoundForOtherUseInWebGL() const
{
for (auto &buffer : mState.mIndexedBuffers)
{
if (buffer.get() && buffer->hasWebGLXFBBindingConflict(true))
{
return true;
}
}
return false;
}
rx::TransformFeedbackImpl *TransformFeedback::getImplementation() const
{
return mImplementation;
}
void TransformFeedback::onBindingChanged(const Context *context, bool bound)
{
for (auto &buffer : mState.mIndexedBuffers)
{
if (buffer.get())
{
buffer->onTFBindingChanged(context, bound, true);
}
}
}
const std::vector<OffsetBindingPointer<Buffer>> &TransformFeedback::getIndexedBuffers() const
{
return mState.mIndexedBuffers;
}
} // namespace gl