Hash :
1443a451
Author :
Date :
2025-07-04T16:18:30
Regenerate the parsers with current cl format The format tool has changed since last parser generation. This causes overly many changes when downstream regenerates the parsers. The diff formatting fails for flex and bison generated content. Format them in full always. Bug: angleproject:429588208 Change-Id: I7a4b8e966e9502920fc25f5c1c5bf80246f5cf0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6705451 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315
#!/usr/bin/python3
#
# Copyright 2017 The ANGLE Project Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
#
# run_code_generation.py:
# Runs ANGLE format table and other script code generation scripts.
import argparse
from concurrent import futures
import hashlib
import json
import os
import subprocess
import sys
import platform
script_dir = sys.path[0]
root_dir = os.path.abspath(os.path.join(script_dir, '..'))
hash_dir = os.path.join(script_dir, 'code_generation_hashes')
def get_child_script_dirname(script):
# All script names are relative to ANGLE's root
return os.path.dirname(os.path.abspath(os.path.join(root_dir, script)))
def get_executable_name(script):
with open(script, 'r') as f:
# Check shebang
binary = os.path.basename(f.readline().strip().replace(' ', '/'))
assert binary in ['python3', 'vpython3']
if platform.system() == 'Windows':
return binary + '.bat'
else:
return binary
def paths_from_auto_script(script, param):
script_dir = get_child_script_dirname(script)
# python3 (not vpython3) to get inputs/outputs faster
exe = 'python3'
try:
res = subprocess.check_output([exe, os.path.basename(script), param],
cwd=script_dir).decode().strip()
except Exception:
print('Error with auto_script %s: %s, executable %s' % (param, script, exe))
raise
if res == '':
return []
return [
os.path.relpath(os.path.join(script_dir, path), root_dir).replace("\\", "/")
for path in res.split(',')
]
# auto_script is a standard way for scripts to return their inputs and outputs.
def auto_script(script):
info = {
'inputs': paths_from_auto_script(script, 'inputs'),
'outputs': paths_from_auto_script(script, 'outputs')
}
return info
generators = {
'ANGLE format':
'src/libANGLE/renderer/gen_angle_format_table.py',
'ANGLE load functions table':
'src/libANGLE/renderer/gen_load_functions_table.py',
'ANGLE shader preprocessor':
'src/compiler/preprocessor/generate_parser.py',
'ANGLE shader translator':
'src/compiler/translator/generate_parser.py',
'D3D11 blit shader selection':
'src/libANGLE/renderer/d3d/d3d11/gen_blit11helper.py',
'D3D11 format':
'src/libANGLE/renderer/d3d/d3d11/gen_texture_format_table.py',
'DXGI format':
'src/libANGLE/renderer/gen_dxgi_format_table.py',
'DXGI format support':
'src/libANGLE/renderer/gen_dxgi_support_tables.py',
'Emulated HLSL functions':
'src/compiler/translator/hlsl/gen_emulated_builtin_function_tables.py',
'Extension files':
'src/libANGLE/gen_extensions.py',
'GL copy conversion table':
'src/libANGLE/gen_copy_conversion_table.py',
'GL CTS (dEQP) build files':
'scripts/gen_vk_gl_cts_build.py',
'GL/EGL/WGL loader':
'scripts/generate_loader.py',
'GL/EGL entry points':
'scripts/generate_entry_points.py',
'GLenum value to string map':
'scripts/gen_gl_enum_utils.py',
'GL format map':
'src/libANGLE/gen_format_map.py',
'interpreter utils':
'scripts/gen_interpreter_utils.py',
'Metal format table':
'src/libANGLE/renderer/metal/gen_mtl_format_table.py',
'Metal default shaders':
'src/libANGLE/renderer/metal/shaders/gen_mtl_internal_shaders.py',
'OpenGL dispatch table':
'src/libANGLE/renderer/gl/generate_gl_dispatch_table.py',
'overlay fonts':
'src/libANGLE/gen_overlay_fonts.py',
'overlay widgets':
'src/libANGLE/gen_overlay_widgets.py',
'packed enum':
'src/common/gen_packed_gl_enums.py',
'proc table':
'scripts/gen_proc_table.py',
'restricted traces':
'src/tests/restricted_traces/gen_restricted_traces.py',
'SPIR-V helpers':
'src/common/spirv/gen_spirv_builder_and_parser.py',
'Static builtins':
'src/compiler/translator/gen_builtin_symbols.py',
'uniform type':
'src/common/gen_uniform_type_table.py',
'Vulkan format':
'src/libANGLE/renderer/vulkan/gen_vk_format_table.py',
'Vulkan internal shader programs':
'src/libANGLE/renderer/vulkan/gen_vk_internal_shaders.py',
'Vulkan mandatory format support table':
'src/libANGLE/renderer/vulkan/gen_vk_mandatory_format_support_table.py',
'WebGPU format':
'src/libANGLE/renderer/wgpu/gen_wgpu_format_table.py',
}
# Fast and supports --verify-only without hashes.
hashless_generators = {
'ANGLE features': 'include/platform/gen_features.py',
'Test spec JSON': 'infra/specs/generate_test_spec_json.py',
}
def md5(fname):
hash_md5 = hashlib.md5()
with open(fname, 'rb') as f:
if sys.platform.startswith('win') or sys.platform == 'cygwin':
# Beware: Windows crlf + git behavior + unicode in some files
hash_md5.update(f.read().replace(b'\r\n', b'\n'))
else:
for chunk in iter(lambda: f.read(4096), b''):
hash_md5.update(chunk)
return hash_md5.hexdigest()
def get_hash_file_name(name):
return name.replace(' ', '_').replace('/', '_') + '.json'
def any_hash_dirty(name, filenames, new_hashes, old_hashes):
found_dirty_hash = False
for fname in filenames:
if not os.path.isfile(os.path.join(root_dir, fname)):
print('File not found: "%s". Code gen dirty for %s' % (fname, name))
found_dirty_hash = True
else:
new_hashes[fname] = md5(fname)
if (not fname in old_hashes) or (old_hashes[fname] != new_hashes[fname]):
print('Hash for "%s" dirty for %s generator.' % (fname, name))
found_dirty_hash = True
return found_dirty_hash
def any_old_hash_missing(all_new_hashes, all_old_hashes):
result = False
for file, old_hashes in all_old_hashes.items():
if file not in all_new_hashes:
print('"%s" does not exist. Code gen dirty.' % file)
result = True
else:
for name, _ in old_hashes.items():
if name not in all_new_hashes[file]:
print('Hash for %s is missing from "%s". Code gen is dirty.' % (name, file))
result = True
return result
def update_output_hashes(script, outputs, new_hashes):
for output in outputs:
if not os.path.isfile(output):
print('Output is missing from %s: %s' % (script, output))
sys.exit(1)
new_hashes[output] = md5(output)
def load_hashes():
hashes = {}
for file in os.listdir(hash_dir):
hash_fname = os.path.join(hash_dir, file)
with open(hash_fname) as hash_file:
try:
hashes[file] = json.load(hash_file)
except ValueError:
raise Exception("Could not decode JSON from %s" % file)
return hashes
def main():
all_old_hashes = load_hashes()
all_new_hashes = {}
any_dirty = False
full_formats = []
parser = argparse.ArgumentParser(description='Generate ANGLE internal code.')
parser.add_argument(
'-v',
'--verify-no-dirty',
dest='verify_only',
action='store_true',
help='verify hashes are not dirty')
parser.add_argument(
'-g', '--generator', action='append', nargs='*', type=str, dest='specified_generators'),
args = parser.parse_args()
ranGenerators = generators
runningSingleGenerator = False
if (args.specified_generators):
ranGenerators = {k: v for k, v in generators.items() if k in args.specified_generators[0]}
runningSingleGenerator = True
if len(ranGenerators) == 0:
print("No valid generators specified.")
return 1
# Just get 'inputs' and 'outputs' from scripts but this runs the scripts so it's a bit slow
infos = {}
with futures.ThreadPoolExecutor(max_workers=8) as executor:
for _, script in sorted(ranGenerators.items()):
infos[script] = executor.submit(auto_script, script)
for name, script in sorted(ranGenerators.items()):
info = infos[script].result()
fname = get_hash_file_name(name)
filenames = info['inputs'] + info['outputs'] + [script]
new_hashes = {}
if fname not in all_old_hashes:
all_old_hashes[fname] = {}
if any_hash_dirty(name, filenames, new_hashes, all_old_hashes[fname]):
any_dirty = True
full_formats += [fn for fn in filenames if '_tab_' in fn or '_lex_' in fn]
if not args.verify_only:
print('Running ' + name + ' code generator')
exe = get_executable_name(script)
subprocess.check_call([exe, os.path.basename(script)],
cwd=get_child_script_dirname(script))
# Update the hash dictionary.
all_new_hashes[fname] = new_hashes
if not runningSingleGenerator and any_old_hash_missing(all_new_hashes, all_old_hashes):
any_dirty = True
# Handle hashless_generators separately as these don't have hash maps.
hashless_generators_dirty = False
for name, script in sorted(hashless_generators.items()):
cmd = [get_executable_name(script), os.path.basename(script)]
rc = subprocess.call(cmd + ['--verify-only'], cwd=get_child_script_dirname(script))
if rc != 0:
print(name + ' generator dirty')
# Don't set any_dirty as we don't need git cl format in this case.
hashless_generators_dirty = True
if not args.verify_only:
print('Running ' + name + ' code generator')
subprocess.check_call(cmd, cwd=get_child_script_dirname(script))
if args.verify_only:
return int(any_dirty or hashless_generators_dirty)
if any_dirty:
args = ['git.bat'] if os.name == 'nt' else ['git']
args += ['cl', 'format']
print('Calling git cl format')
subprocess.check_call(args)
if full_formats:
# Some formattings fail, and thus we can never submit such a cl because
# of vicious circle of needing clean formatting but formatting not generating
# clean formatting.
print('Calling git cl format --full' % full_formats)
args += ['--full'] + full_formats
subprocess.check_call(args)
# Update the output hashes again since they can be formatted.
for name, script in sorted(ranGenerators.items()):
info = auto_script(script)
fname = get_hash_file_name(name)
update_output_hashes(name, info['outputs'], all_new_hashes[fname])
for fname, new_hashes in all_new_hashes.items():
hash_fname = os.path.join(hash_dir, fname)
with open(hash_fname, "w") as f:
json.dump(new_hashes, f, indent=2, sort_keys=True, separators=(',', ':\n '))
f.write('\n') # json.dump doesn't end with newline
return 0
if __name__ == '__main__':
sys.exit(main())