kc3-lang/angle/src/image_util/loadimage_astc.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/image_util/loadimage_astc.cpp

• //
  // Copyright 2022 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  // loadimage_astc.cpp: Decodes ASTC encoded textures.
  
  #include "image_util/AstcDecompressor.h"
  #include "image_util/loadimage.h"
  
  namespace angle
  {
  
  void LoadASTCToRGBA8Inner(const ImageLoadContext &context,
                            size_t width,
                            size_t height,
                            size_t depth,
                            uint32_t blockWidth,
                            uint32_t blockHeight,
                            const uint8_t *input,
                            size_t inputRowPitch,
                            size_t inputDepthPitch,
                            uint8_t *output,
                            size_t outputRowPitch,
                            size_t outputDepthPitch)
  {
      auto imgWidth  = static_cast<uint32_t>(width);
      auto imgHeight = static_cast<uint32_t>(height);
  
      AstcDecompressor &decompressor = AstcDecompressor::get();
      if (!decompressor.available())
      {
          ERR() << "Trying to decompress ASTC without having ASTC support built.";
          return;
      }
  
      // Compute the number of ASTC blocks in each dimension
      uint32_t blockCountX = (imgWidth + blockWidth - 1) / blockWidth;
      uint32_t blockCountY = (imgHeight + blockHeight - 1) / blockHeight;
  
      // Space needed for 16 bytes of output per compressed block
      size_t blockSize = blockCountX * blockCountY * 16;
  
      for (size_t slice = 0; slice < depth; ++slice)
      {
          int32_t result =
              decompressor.decompress(context.singleThreadPool, context.multiThreadPool, imgWidth,
                                      imgHeight, blockWidth, blockHeight, input, blockSize, output);
          if (result != 0)
          {
              WARN() << "ASTC decompression failed: " << decompressor.getStatusString(result);
          }
  
          input += inputDepthPitch;
          output += outputDepthPitch;
      }
  }
  }  // namespace angle
  

Download