Hash :
02ae054c
Author :
Date :
2025-04-07T13:48:29
Translator: Fix init of inactive output variables Bug: chromium:398401939 Change-Id: I0df494b945b8d0e805a62cf7645d06bf233f36ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6438495 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465
//
// Copyright 2017 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// EXT_YUV_target.cpp:
// Test for EXT_YUV_target implementation.
//
#include "tests/test_utils/ShaderExtensionTest.h"
namespace
{
class EXTYUVTargetTest : public sh::ShaderExtensionTest
{
public:
void InitializeCompiler() { InitializeCompiler(SH_GLSL_450_CORE_OUTPUT); }
void InitializeCompiler(ShShaderOutput shaderOutputType)
{
DestroyCompiler();
if (shaderOutputType == SH_SPIRV_VULKAN_OUTPUT || shaderOutputType == SH_MSL_METAL_OUTPUT)
{
mCompileOptions.removeInactiveVariables = true;
}
mCompiler = sh::ConstructCompiler(GL_FRAGMENT_SHADER, testing::get<0>(GetParam()),
shaderOutputType, &mResources);
ASSERT_TRUE(mCompiler != nullptr) << "Compiler could not be constructed.";
}
};
const char EXTYTPragma[] = "#extension GL_EXT_YUV_target : require\n";
const char ESSL300_SimpleShader[] =
R"(precision mediump float;
uniform __samplerExternal2DY2YEXT uSampler;
out vec4 fragColor;
void main() {
fragColor = vec4(1.0);
})";
// Shader that samples the texture and writes to FragColor.
const char ESSL300_FragColorShader[] =
R"(precision mediump float;
uniform __samplerExternal2DY2YEXT uSampler;
layout(yuv) out vec4 fragColor;
void main() {
fragColor = texture(uSampler, vec2(0.0));
})";
// Shader that samples the texture and swizzle and writes to FragColor.
const char ESSL300_textureSwizzleFragColorShader[] =
R"(precision mediump float;
uniform __samplerExternal2DY2YEXT uSampler;
layout(yuv) out vec4 fragColor;
void main() {
fragColor = vec4(texture(uSampler, vec2(0.0)).zyx, 1.0);
})";
// Shader that specifies yuv layout qualifier multiple times.
const char ESSL300_YUVQualifierMultipleTimesShader[] =
R"(precision mediump float;
layout(yuv, yuv, yuv) out vec4 fragColor;
void main() {
})";
// Shader that specifies yuv layout qualifier for not output fails to compile.
const char ESSL300_YUVQualifierFailureShader1[] =
R"(precision mediump float;
layout(yuv) in vec4 fragColor;
void main() {
})";
const char ESSL300_YUVQualifierFailureShader2[] =
R"(precision mediump float;
layout(yuv) uniform;
layout(yuv) uniform Transform {
mat4 M1;
};
void main() {
})";
// Shader that specifies yuv layout qualifier with location fails to compile.
const char ESSL300_LocationAndYUVFailureShader[] =
R"(precision mediump float;
layout(location = 0, yuv) out vec4 fragColor;
void main() {
})";
// Shader that specifies yuv layout qualifier with multiple color outputs fails to compile.
const char ESSL300_MultipleColorAndYUVOutputsFailureShader1[] =
R"(precision mediump float;
layout(yuv) out vec4 fragColor;
layout out vec4 fragColor1;
void main() {
})";
const char ESSL300_MultipleColorAndYUVOutputsFailureShader2[] =
R"(precision mediump float;
layout(yuv) out vec4 fragColor;
layout(location = 1) out vec4 fragColor1;
void main() {
})";
// Shader that specifies yuv layout qualifier with depth output fails to compile.
const char ESSL300_DepthAndYUVOutputsFailureShader[] =
R"(precision mediump float;
layout(yuv) out vec4 fragColor;
void main() {
gl_FragDepth = 1.0f;
})";
// Shader that specifies yuv layout qualifier with multiple outputs fails to compile.
const char ESSL300_MultipleYUVOutputsFailureShader[] =
R"(precision mediump float;
layout(yuv) out vec4 fragColor;
layout(yuv) out vec4 fragColor1;
void main() {
})";
// Shader that specifies yuvCscStandartEXT type and associated values.
const char ESSL300_YuvCscStandardEXTShader[] =
R"(precision mediump float;
yuvCscStandardEXT;
yuvCscStandardEXT conv;
yuvCscStandardEXT conv1 = itu_601;
yuvCscStandardEXT conv2 = itu_601_full_range;
yuvCscStandardEXT conv3 = itu_709;
const yuvCscStandardEXT conv4 = itu_709;
uniform int u;
out vec4 my_color;
yuvCscStandardEXT conv_standard()
{
switch(u)
{
case 1:
return conv1;
case 2:
return conv2;
case 3:
return conv3;
default:
return conv;
}
}
bool is_itu_601(inout yuvCscStandardEXT csc)
{
csc = itu_601;
return csc == itu_601;
}
bool is_itu_709(yuvCscStandardEXT csc)
{
return csc == itu_709;
}
void main()
{
yuvCscStandardEXT conv = conv_standard();
bool csc_check1 = is_itu_601(conv);
bool csc_check2 = is_itu_709(itu_709);
if (csc_check1 && csc_check2) {
my_color = vec4(0, 1, 0, 1);
}
})";
// Shader that specifies yuvCscStandardEXT type constructor fails to compile.
const char ESSL300_YuvCscStandardEXTConstructFailureShader1[] =
R"(precision mediump float;
yuvCscStandardEXT conv = yuvCscStandardEXT();
void main() {
})";
const char ESSL300_YuvCscStandardEXTConstructFailureShader2[] =
R"(precision mediump float;
yuvCscStandardEXT conv = yuvCscStandardEXT(itu_601);
void main() {
})";
// Shader that specifies yuvCscStandardEXT type conversion fails to compile.
const char ESSL300_YuvCscStandardEXTConversionFailureShader1[] =
R"(precision mediump float;
yuvCscStandardEXT conv = false;
void main() {
})";
const char ESSL300_YuvCscStandardEXTConversionFailureShader2[] =
R"(precision mediump float;
yuvCscStandardEXT conv = 0;
void main() {
})";
const char ESSL300_YuvCscStandardEXTConversionFailureShader3[] =
R"(precision mediump float;
yuvCscStandardEXT conv = 2.0f;
void main() {
})";
const char ESSL300_YuvCscStandardEXTConversionFailureShader4[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_601 | itu_709;
void main() {
})";
const char ESSL300_YuvCscStandardEXTConversionFailureShader5[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_601 & 3.0f;
void main() {
})";
// Shader that specifies yuvCscStandardEXT type qualifiers fails to compile.
const char ESSL300_YuvCscStandardEXTQualifiersFailureShader1[] =
R"(precision mediump float;
in yuvCscStandardEXT conv = itu_601;
void main() {
})";
const char ESSL300_YuvCscStandardEXTQualifiersFailureShader2[] =
R"(precision mediump float;
out yuvCscStandardEXT conv = itu_601;
void main() {
})";
const char ESSL300_YuvCscStandardEXTQualifiersFailureShader3[] =
R"(precision mediump float;
uniform yuvCscStandardEXT conv = itu_601;
void main() {
})";
// Shader that specifies yuv_to_rgb() and rgb_to_yuv() built-in functions.
const char ESSL300_BuiltInFunctionsShader[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_601;
out vec4 my_color;
void main()
{
vec3 yuv = rgb_2_yuv(vec3(0.0f), conv);
vec3 rgb = yuv_2_rgb(yuv, itu_601);
my_color = vec4(rgb, 1.0);
})";
// Shader with nested yuv_to_rgb() and rgb_to_yuv() built-in functions.
const char ESSL300_BuiltInFunctionsNested1Shader[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_601;
out vec4 my_color;
void main()
{
vec3 rgb = yuv_2_rgb(rgb_2_yuv(vec3(0.0f), conv), conv);
my_color = vec4(rgb, 1.0);
})";
const char ESSL300_BuiltInFunctionsNested2Shader[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_601_full_range;
out vec4 my_color;
void main()
{
vec3 rgb = yuv_2_rgb(vec3(0.1) + rgb_2_yuv(vec3(0.0f), conv), conv);
my_color = vec4(rgb, 1.0);
})";
const char ESSL300_BuiltInFunctionsNested3Shader[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_709;
out vec4 my_color;
vec3 f(vec3 v) { return v + vec3(0.1); }
void main()
{
vec3 rgb = yuv_2_rgb(f(rgb_2_yuv(vec3(0.0f), conv)), conv);
my_color = vec4(rgb, 1.0);
})";
const char ESSL300_BuiltInFunctionsNested4Shader[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_601;
out vec4 my_color;
vec3 f(vec3 v) { return v + vec3(0.1); }
void main()
{
vec3 rgb = f(yuv_2_rgb(f(rgb_2_yuv(vec3(0.0f), conv)), conv));
my_color = vec4(rgb, 1.0);
})";
// Shader with yuv_to_rgb() and rgb_to_yuv() built-in functions with different precision.
const char ESSL300_BuiltInFunctionsPrecisionShader[] =
R"(precision mediump float;
yuvCscStandardEXT conv = itu_601;
out vec4 my_color;
void main()
{
lowp vec3 rgbLow = vec3(0.1);
mediump vec3 rgbMedium = vec3(0.2);
highp vec3 rgbHigh = vec3(0.3);
lowp vec3 yuvLow = vec3(0.4);
mediump vec3 yuvMedium = vec3(0.5);
highp vec3 yuvHigh = vec3(0.6);
my_color = vec4(
rgb_2_yuv(rgbLow, conv) - rgb_2_yuv(rgbMedium, conv) + rgb_2_yuv(rgbHigh, conv) -
yuv_2_rgb(yuvLow, conv) - yuv_2_rgb(yuvMedium, conv) + yuv_2_rgb(yuvHigh, conv),
1.0);
})";
const char ESSL300_OverloadRgb2Yuv[] =
R"(precision mediump float;
float rgb_2_yuv(float x) { return x + 1.0; }
in float i;
out float o;
void main()
{
o = rgb_2_yuv(i);
})";
const char ESSL300_OverloadYuv2Rgb[] =
R"(precision mediump float;
float yuv_2_rgb(float x) { return x + 1.0; }
in float i;
out float o;
void main()
{
o = yuv_2_rgb(i);
})";
// Extension flag is required to compile properly. Expect failure when it is
// not present.
TEST_P(EXTYUVTargetTest, CompileFailsWithoutExtension)
{
mResources.EXT_YUV_target = 0;
InitializeCompiler();
EXPECT_FALSE(TestShaderCompile(EXTYTPragma));
}
// Extension directive is required to compile properly. Expect failure when
// it is not present.
TEST_P(EXTYUVTargetTest, CompileFailsWithExtensionWithoutPragma)
{
mResources.EXT_YUV_target = 1;
InitializeCompiler();
EXPECT_FALSE(TestShaderCompile(""));
}
// With extension flag and extension directive, compiling succeeds.
// Also test that the extension directive state is reset correctly.
TEST_P(EXTYUVTargetTest, CompileSucceedsWithExtensionAndPragma)
{
mResources.EXT_YUV_target = 1;
InitializeCompiler();
EXPECT_TRUE(TestShaderCompile(EXTYTPragma));
// Test reset functionality.
EXPECT_FALSE(TestShaderCompile(""));
EXPECT_TRUE(TestShaderCompile(EXTYTPragma));
}
INSTANTIATE_TEST_SUITE_P(CorrectVariantsWithExtensionAndPragma,
EXTYUVTargetTest,
Combine(Values(SH_GLES3_SPEC),
Values(sh::ESSLVersion300),
Values(ESSL300_SimpleShader, ESSL300_FragColorShader)));
class EXTYUVTargetCompileSuccessTest : public EXTYUVTargetTest
{};
TEST_P(EXTYUVTargetCompileSuccessTest, CompileSucceeds)
{
// Expect compile success.
mResources.EXT_YUV_target = 1;
InitializeCompiler();
EXPECT_TRUE(TestShaderCompile(EXTYTPragma));
}
#ifdef ANGLE_ENABLE_VULKAN
// Test that YUV built-in emulation works on Vulkan
TEST_P(EXTYUVTargetCompileSuccessTest, CompileSucceedsWithExtensionAndPragmaOnVulkan)
{
mResources.EXT_YUV_target = 1;
mCompileOptions.validateAST = 1;
InitializeCompiler(SH_SPIRV_VULKAN_OUTPUT);
EXPECT_TRUE(TestShaderCompile(EXTYTPragma));
}
#endif
INSTANTIATE_TEST_SUITE_P(CorrectESSL300Shaders,
EXTYUVTargetCompileSuccessTest,
Combine(Values(SH_GLES3_SPEC),
Values(sh::ESSLVersion300),
Values(ESSL300_FragColorShader,
ESSL300_textureSwizzleFragColorShader,
ESSL300_YUVQualifierMultipleTimesShader,
ESSL300_YuvCscStandardEXTShader,
ESSL300_BuiltInFunctionsShader,
ESSL300_BuiltInFunctionsNested1Shader,
ESSL300_BuiltInFunctionsNested2Shader,
ESSL300_BuiltInFunctionsNested3Shader,
ESSL300_BuiltInFunctionsNested4Shader,
ESSL300_BuiltInFunctionsPrecisionShader)));
class EXTYUVTargetCompileFailureTest : public EXTYUVTargetTest
{};
TEST_P(EXTYUVTargetCompileFailureTest, CompileFails)
{
// Expect compile failure due to shader error, with shader having correct pragma.
mResources.EXT_YUV_target = 1;
InitializeCompiler();
EXPECT_FALSE(TestShaderCompile(EXTYTPragma));
}
INSTANTIATE_TEST_SUITE_P(IncorrectESSL300Shaders,
EXTYUVTargetCompileFailureTest,
Combine(Values(SH_GLES3_SPEC),
Values(sh::ESSLVersion300),
Values(ESSL300_YUVQualifierFailureShader1,
ESSL300_YUVQualifierFailureShader2,
ESSL300_LocationAndYUVFailureShader,
ESSL300_MultipleColorAndYUVOutputsFailureShader1,
ESSL300_MultipleColorAndYUVOutputsFailureShader2,
ESSL300_DepthAndYUVOutputsFailureShader,
ESSL300_MultipleYUVOutputsFailureShader,
ESSL300_YuvCscStandardEXTConstructFailureShader1,
ESSL300_YuvCscStandardEXTConstructFailureShader2,
ESSL300_YuvCscStandardEXTConversionFailureShader1,
ESSL300_YuvCscStandardEXTConversionFailureShader2,
ESSL300_YuvCscStandardEXTConversionFailureShader3,
ESSL300_YuvCscStandardEXTConversionFailureShader4,
ESSL300_YuvCscStandardEXTConversionFailureShader5,
ESSL300_YuvCscStandardEXTQualifiersFailureShader1,
ESSL300_YuvCscStandardEXTQualifiersFailureShader2,
ESSL300_YuvCscStandardEXTQualifiersFailureShader3)));
class EXTYUVNotEnabledTest : public EXTYUVTargetTest
{};
TEST_P(EXTYUVNotEnabledTest, CanOverloadConversions)
{
// Expect compile success with a shader that overloads functions in the EXT_YUV_target
// extension.
mResources.EXT_YUV_target = 0;
InitializeCompiler();
EXPECT_TRUE(TestShaderCompile(""));
}
INSTANTIATE_TEST_SUITE_P(CoreESSL300Shaders,
EXTYUVNotEnabledTest,
Combine(Values(SH_GLES3_SPEC),
Values(sh::ESSLVersion300),
Values(ESSL300_OverloadRgb2Yuv, ESSL300_OverloadYuv2Rgb)));
} // namespace