Hash :
89a69a03
Author :
Date :
2017-10-23T12:20:45
Generate performance warnings in HLSL translation Generate performance warnings for some code that undergoes heavy emulation when translated to HLSL: 1. Dynamic indexing of vectors and matrices. 2. Non-empty fall-through cases in switch/case. The warnings are generated only when code is translated to HLSL. Generating them in the parsing stage would add too much maintenance burden. Improves switch statement fall-through handling in cases where an empty fall-through case follows a non-empty one so that extra performance warnings are not generated. BUG=angleproject:1116 Change-Id: I7c85d78fe7c4f8e6042bda72ceaaf6e37dadfe6c Reviewed-on: https://chromium-review.googlesource.com/732986 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105
//
// Copyright (c) 2012-2013 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include "compiler/translator/Diagnostics.h"
#include "common/debug.h"
#include "compiler/preprocessor/SourceLocation.h"
#include "compiler/translator/Common.h"
#include "compiler/translator/InfoSink.h"
namespace sh
{
TDiagnostics::TDiagnostics(TInfoSinkBase &infoSink)
: mInfoSink(infoSink), mNumErrors(0), mNumWarnings(0)
{
}
TDiagnostics::~TDiagnostics()
{
}
void TDiagnostics::writeInfo(Severity severity,
const pp::SourceLocation &loc,
const char *reason,
const char *token)
{
switch (severity)
{
case SH_ERROR:
++mNumErrors;
break;
case SH_WARNING:
++mNumWarnings;
break;
default:
UNREACHABLE();
break;
}
/* VC++ format: file(linenum) : error #: 'token' : extrainfo */
mInfoSink.prefix(severity);
mInfoSink.location(loc.file, loc.line);
mInfoSink << "'" << token << "' : " << reason << "\n";
}
void TDiagnostics::globalError(const char *message)
{
++mNumErrors;
mInfoSink.prefix(SH_ERROR);
mInfoSink << message << "\n";
}
void TDiagnostics::error(const pp::SourceLocation &loc, const char *reason, const char *token)
{
writeInfo(SH_ERROR, loc, reason, token);
}
void TDiagnostics::warning(const pp::SourceLocation &loc, const char *reason, const char *token)
{
writeInfo(SH_WARNING, loc, reason, token);
}
void TDiagnostics::error(const TSourceLoc &loc, const char *reason, const char *token)
{
pp::SourceLocation srcLoc;
srcLoc.file = loc.first_file;
srcLoc.line = loc.first_line;
error(srcLoc, reason, token);
}
void TDiagnostics::warning(const TSourceLoc &loc, const char *reason, const char *token)
{
pp::SourceLocation srcLoc;
srcLoc.file = loc.first_file;
srcLoc.line = loc.first_line;
warning(srcLoc, reason, token);
}
void TDiagnostics::print(ID id, const pp::SourceLocation &loc, const std::string &text)
{
writeInfo(isError(id) ? SH_ERROR : SH_WARNING, loc, message(id), text.c_str());
}
void TDiagnostics::resetErrorCount()
{
mNumErrors = 0;
mNumWarnings = 0;
}
PerformanceDiagnostics::PerformanceDiagnostics(TDiagnostics *diagnostics)
: mDiagnostics(diagnostics)
{
ASSERT(diagnostics);
}
void PerformanceDiagnostics::warning(const TSourceLoc &loc, const char *reason, const char *token)
{
mDiagnostics->warning(loc, reason, token);
}
} // namespace sh