kc3-lang/angle/src/compiler/translator/UnfoldShortCircuitAST.h

• Show log

  Commit

• Hash : 7cab38b5
  Author :
  Date : 2013-10-15T12:59:30
  

  Add an option to unfold short circuiting in AST.
  
  We replace "a || b" with "a ? true : b",
  "a && b" with "a ? b : false".
  
  This is to work around short circuiting bug in Mac drivers.
  
  ANGLEBUG=482
  TEST=webgl conformance tests
  R=alokp@chromium.org, kbr@chromium.org
  
  Review URL: https://codereview.appspot.com/14529048
  
  Conflicts:
  
  	src/build_angle.gypi
  	src/compiler/translator/Compiler.cpp
  
  Change-Id: Ic2384a97d58f54294efcb3a012deb2007a9fc658
  Reviewed-on: https://chromium-review.googlesource.com/178996
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Tested-by: Shannon Woods <shannonwoods@chromium.org>
  

Download

• src/compiler/translator/UnfoldShortCircuitAST.h

• //
  // Copyright (c) 2002-2013 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // UnfoldShortCircuitAST is an AST traverser to replace short-circuiting
  // operations with ternary operations.
  //
  
  #ifndef COMPILER_UNFOLD_SHORT_CIRCUIT_AST_H_
  #define COMPILER_UNFOLD_SHORT_CIRCUIT_AST_H_
  
  #include "common/angleutils.h"
  #include "compiler/translator/intermediate.h"
  
  // This traverser identifies all the short circuit binary  nodes that need to
  // be replaced, and creates the corresponding replacement nodes. However,
  // the actual replacements happen after the traverse through updateTree().
  
  class UnfoldShortCircuitAST : public TIntermTraverser
  {
    public:
      UnfoldShortCircuitAST() { }
  
      virtual bool visitBinary(Visit visit, TIntermBinary *);
  
      void updateTree();
  
    private:
      struct NodeUpdateEntry
      {
          NodeUpdateEntry(TIntermNode *_parent,
                          TIntermNode *_original,
                          TIntermNode *_replacement)
              : parent(_parent),
                original(_original),
                replacement(_replacement) {}
  
          TIntermNode *parent;
          TIntermNode *original;
          TIntermNode *replacement;
      };
  
      // During traversing, save all the replacements that need to happen;
      // then replace them by calling updateNodes().
      std::vector<NodeUpdateEntry> replacements;
  
      DISALLOW_COPY_AND_ASSIGN(UnfoldShortCircuitAST);
  };
  
  #endif  // COMPILER_UNFOLD_SHORT_CIRCUIT_AST_H_
  

Download