Hash :
9bc9a321
Author :
Date :
2017-07-21T14:28:17
Integrate multiview state in FBO completeness check The patch extends the FBO completeness validation to include the multiview state members according to the ANGLE_multiview specification. It also changes the numViews in FramebufferAttachment to be consistently of type GLsizei instead of GLint. BUG=angleproject:2062 TEST=angle_end2end_tests Change-Id: Ibe550ba03204d808d96a4edf4807c68421aa1158 Reviewed-on: https://chromium-review.googlesource.com/581193 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310
//
// Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// FramebufferAttachment.cpp: the gl::FramebufferAttachment class and its derived classes
// objects and related functionality. [OpenGL ES 2.0.24] section 4.4.3 page 108.
#include "libANGLE/FramebufferAttachment.h"
#include "common/utilities.h"
#include "libANGLE/Config.h"
#include "libANGLE/Renderbuffer.h"
#include "libANGLE/Surface.h"
#include "libANGLE/Texture.h"
#include "libANGLE/formatutils.h"
#include "libANGLE/renderer/FramebufferImpl.h"
#include "libANGLE/renderer/FramebufferAttachmentObjectImpl.h"
namespace gl
{
////// FramebufferAttachment::Target Implementation //////
const GLsizei FramebufferAttachment::kDefaultNumViews = 1;
const GLenum FramebufferAttachment::kDefaultMultiviewLayout = GL_NONE;
const GLint FramebufferAttachment::kDefaultBaseViewIndex = 0;
const GLint FramebufferAttachment::kDefaultViewportOffsets[2] = {0};
FramebufferAttachment::Target::Target()
: mBinding(GL_NONE),
mTextureIndex(ImageIndex::MakeInvalid())
{
}
FramebufferAttachment::Target::Target(GLenum binding, const ImageIndex &imageIndex)
: mBinding(binding),
mTextureIndex(imageIndex)
{
}
FramebufferAttachment::Target::Target(const Target &other)
: mBinding(other.mBinding),
mTextureIndex(other.mTextureIndex)
{
}
FramebufferAttachment::Target &FramebufferAttachment::Target::operator=(const Target &other)
{
this->mBinding = other.mBinding;
this->mTextureIndex = other.mTextureIndex;
return *this;
}
////// FramebufferAttachment Implementation //////
FramebufferAttachment::FramebufferAttachment()
: mType(GL_NONE),
mResource(nullptr),
mNumViews(kDefaultNumViews),
mMultiviewLayout(kDefaultMultiviewLayout),
mBaseViewIndex(kDefaultBaseViewIndex),
mViewportOffsets(1u)
{
}
FramebufferAttachment::FramebufferAttachment(const Context *context,
GLenum type,
GLenum binding,
const ImageIndex &textureIndex,
FramebufferAttachmentObject *resource)
: mResource(nullptr)
{
attach(context, type, binding, textureIndex, resource, kDefaultNumViews, kDefaultBaseViewIndex,
kDefaultMultiviewLayout, kDefaultViewportOffsets);
}
FramebufferAttachment::FramebufferAttachment(FramebufferAttachment &&other)
: FramebufferAttachment()
{
*this = std::move(other);
}
FramebufferAttachment &FramebufferAttachment::operator=(FramebufferAttachment &&other)
{
std::swap(mType, other.mType);
std::swap(mTarget, other.mTarget);
std::swap(mResource, other.mResource);
std::swap(mNumViews, other.mNumViews);
std::swap(mMultiviewLayout, other.mMultiviewLayout);
std::swap(mBaseViewIndex, other.mBaseViewIndex);
std::swap(mViewportOffsets, other.mViewportOffsets);
return *this;
}
FramebufferAttachment::~FramebufferAttachment()
{
ASSERT(!isAttached());
}
void FramebufferAttachment::detach(const Context *context)
{
mType = GL_NONE;
if (mResource != nullptr)
{
mResource->onDetach(context);
mResource = nullptr;
}
mNumViews = kDefaultNumViews;
mMultiviewLayout = kDefaultMultiviewLayout;
mBaseViewIndex = kDefaultBaseViewIndex;
mViewportOffsets.resize(1u);
mViewportOffsets[0] = Offset();
// not technically necessary, could omit for performance
mTarget = Target();
}
void FramebufferAttachment::attach(const Context *context,
GLenum type,
GLenum binding,
const ImageIndex &textureIndex,
FramebufferAttachmentObject *resource,
GLsizei numViews,
GLuint baseViewIndex,
GLenum multiviewLayout,
const GLint *viewportOffsets)
{
if (resource == nullptr)
{
detach(context);
return;
}
mType = type;
mTarget = Target(binding, textureIndex);
mNumViews = numViews;
mBaseViewIndex = baseViewIndex;
mMultiviewLayout = multiviewLayout;
mViewportOffsets.resize(numViews);
for (size_t i = 0u; i < mViewportOffsets.size(); ++i)
{
mViewportOffsets[i] = Offset(viewportOffsets[i * 2u], viewportOffsets[i * 2u + 1u], 0);
}
resource->onAttach(context);
if (mResource != nullptr)
{
mResource->onDetach(context);
}
mResource = resource;
}
GLuint FramebufferAttachment::getRedSize() const
{
return getFormat().info->redBits;
}
GLuint FramebufferAttachment::getGreenSize() const
{
return getFormat().info->greenBits;
}
GLuint FramebufferAttachment::getBlueSize() const
{
return getFormat().info->blueBits;
}
GLuint FramebufferAttachment::getAlphaSize() const
{
return getFormat().info->alphaBits;
}
GLuint FramebufferAttachment::getDepthSize() const
{
return getFormat().info->depthBits;
}
GLuint FramebufferAttachment::getStencilSize() const
{
return getFormat().info->stencilBits;
}
GLenum FramebufferAttachment::getComponentType() const
{
return getFormat().info->componentType;
}
GLenum FramebufferAttachment::getColorEncoding() const
{
return getFormat().info->colorEncoding;
}
GLuint FramebufferAttachment::id() const
{
return mResource->getId();
}
const ImageIndex &FramebufferAttachment::getTextureImageIndex() const
{
ASSERT(type() == GL_TEXTURE);
return mTarget.textureIndex();
}
GLenum FramebufferAttachment::cubeMapFace() const
{
ASSERT(mType == GL_TEXTURE);
const auto &index = mTarget.textureIndex();
return IsCubeMapTextureTarget(index.type) ? index.type : GL_NONE;
}
GLint FramebufferAttachment::mipLevel() const
{
ASSERT(type() == GL_TEXTURE);
return mTarget.textureIndex().mipIndex;
}
GLint FramebufferAttachment::layer() const
{
ASSERT(mType == GL_TEXTURE);
const auto &index = mTarget.textureIndex();
if (index.type == GL_TEXTURE_2D_ARRAY || index.type == GL_TEXTURE_3D)
{
return index.layerIndex;
}
return 0;
}
GLsizei FramebufferAttachment::getNumViews() const
{
return mNumViews;
}
GLenum FramebufferAttachment::getMultiviewLayout() const
{
return mMultiviewLayout;
}
GLint FramebufferAttachment::getBaseViewIndex() const
{
return mBaseViewIndex;
}
const std::vector<Offset> &FramebufferAttachment::getMultiviewViewportOffsets() const
{
return mViewportOffsets;
}
Texture *FramebufferAttachment::getTexture() const
{
return rx::GetAs<Texture>(mResource);
}
Renderbuffer *FramebufferAttachment::getRenderbuffer() const
{
return rx::GetAs<Renderbuffer>(mResource);
}
const egl::Surface *FramebufferAttachment::getSurface() const
{
return rx::GetAs<egl::Surface>(mResource);
}
FramebufferAttachmentObject *FramebufferAttachment::getResource() const
{
return mResource;
}
bool FramebufferAttachment::operator==(const FramebufferAttachment &other) const
{
if (mResource != other.mResource || mType != other.mType || mNumViews != other.mNumViews ||
mMultiviewLayout != other.mMultiviewLayout || mBaseViewIndex != other.mBaseViewIndex ||
mViewportOffsets != other.mViewportOffsets)
{
return false;
}
if (mType == GL_TEXTURE && getTextureImageIndex() != other.getTextureImageIndex())
{
return false;
}
return true;
}
bool FramebufferAttachment::operator!=(const FramebufferAttachment &other) const
{
return !(*this == other);
}
Error FramebufferAttachmentObject::getAttachmentRenderTarget(
const Context *context,
GLenum binding,
const ImageIndex &imageIndex,
rx::FramebufferAttachmentRenderTarget **rtOut) const
{
return getAttachmentImpl()->getAttachmentRenderTarget(context, binding, imageIndex, rtOut);
}
angle::BroadcastChannel<> *FramebufferAttachmentObject::getDirtyChannel()
{
return &mDirtyChannel;
}
} // namespace gl