kc3-lang/angle/src/common/utilities_unittest.cpp

• Show log

  Commit

• Hash : 78048112
  Author :
  Date : 2025-01-15T15:13:14
  

  Fix IndexRange::vertexIndexCount calculation
  
  Use only one loop.
  Avoid redundant primitive restart index parameter.
  Avoid calling GetPrimitiveRestartIndexFromType() because the algorithm
  relies on the value being numeric_limits<T>::max().
  
  Fixes a bug where primitive restart case would process the value
  after first primitive restart twice, once in both for loops. This would
  result in incorrect vertexIndexCount.
  
  Fix by removing IndexRange::vertexIndexCount, and instead using
  IndexRange::mCount == 0 to signify empty range.
  
  Bug: angleproject:401284933
  Change-Id: Ifaeb9949f2e852fb7c5ef80bc47f72bfabba21a6
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6333541
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
  Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
  

Download

• src/common/utilities_unittest.cpp

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  
  // utilities_unittest.cpp: Unit tests for ANGLE's GL utility functions
  
  #include "gmock/gmock.h"
  #include "gtest/gtest.h"
  
  #include "common/utilities.h"
  
  namespace
  {
  
  // Test parsing valid single array indices
  TEST(ParseResourceName, ArrayIndex)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo[123]", &indices));
      ASSERT_EQ(1u, indices.size());
      EXPECT_EQ(123u, indices[0]);
  
      EXPECT_EQ("bar", gl::ParseResourceName("bar[0]", &indices));
      ASSERT_EQ(1u, indices.size());
      EXPECT_EQ(0u, indices[0]);
  }
  
  // Parsing a negative array index should result in INVALID_INDEX.
  TEST(ParseResourceName, NegativeArrayIndex)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo[-1]", &indices));
      ASSERT_EQ(1u, indices.size());
      EXPECT_EQ(GL_INVALID_INDEX, indices.back());
  }
  
  // Parsing a letter array index should result in INVALID_INDEX.
  TEST(ParseResourceName, LetterArrayIndex)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo[a]", &indices));
      ASSERT_EQ(1u, indices.size());
      EXPECT_EQ(GL_INVALID_INDEX, indices.back());
  }
  
  // Parsing no array indices should result in an empty array.
  TEST(ParseResourceName, NoArrayIndex)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo", &indices));
      EXPECT_TRUE(indices.empty());
  
      EXPECT_EQ("foo[]", gl::ParseResourceName("foo[]", &indices));
      EXPECT_TRUE(indices.empty());
  }
  
  // The ParseResourceName function should work when a nullptr is passed as the indices output vector.
  TEST(ParseResourceName, NULLArrayIndices)
  {
      EXPECT_EQ("foo", gl::ParseResourceName("foo[10]", nullptr));
  }
  
  // Parsing multiple array indices should result in outermost array indices being last in the vector.
  TEST(ParseResourceName, MultipleArrayIndices)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo[12][34][56]", &indices));
      ASSERT_EQ(3u, indices.size());
      // Indices are sorted with outermost array index last.
      EXPECT_EQ(56u, indices[0]);
      EXPECT_EQ(34u, indices[1]);
      EXPECT_EQ(12u, indices[2]);
  }
  
  // Trailing whitespace should not be accepted by ParseResourceName.
  TEST(ParseResourceName, TrailingWhitespace)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo ", gl::ParseResourceName("foo ", &indices));
      EXPECT_TRUE(indices.empty());
  
      EXPECT_EQ("foo[10] ", gl::ParseResourceName("foo[10] ", &indices));
      EXPECT_TRUE(indices.empty());
  
      EXPECT_EQ("foo[10][20] ", gl::ParseResourceName("foo[10][20] ", &indices));
      EXPECT_TRUE(indices.empty());
  }
  
  // Parse a string without any index.
  TEST(ParseArrayIndex, NoArrayIndex)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(3u, nameLengthWithoutArrayIndex);
  }
  
  // Parse an empty string for an array index.
  TEST(ParseArrayIndex, EmptyString)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(0u, nameLengthWithoutArrayIndex);
  }
  
  // A valid array index is parsed correctly from the end of the string.
  TEST(ParseArrayIndex, ArrayIndex)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(123u, gl::ParseArrayIndex("foo[123]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(3u, nameLengthWithoutArrayIndex);
  }
  
  // An array index from the middle of the string is not parsed.
  TEST(ParseArrayIndex, ArrayIndexInMiddle)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[123].bar", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(12u, nameLengthWithoutArrayIndex);
  }
  
  // Trailing whitespace in the parsed string is taken into account.
  TEST(ParseArrayIndex, TrailingWhitespace)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[123] ", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(9u, nameLengthWithoutArrayIndex);
  }
  
  // Only the last index is parsed.
  TEST(ParseArrayIndex, MultipleArrayIndices)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(34u, gl::ParseArrayIndex("foo[12][34]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 mentions "decimal" integer.
  // So an integer in hexadecimal format should not parse as an array index.
  TEST(ParseArrayIndex, HexArrayIndex)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[0xff]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(9u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 mentions that the array
  // index should not contain a leading plus sign.
  TEST(ParseArrayIndex, ArrayIndexLeadingPlus)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[+1]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 says that index should not
  // contain whitespace. Test leading whitespace.
  TEST(ParseArrayIndex, ArrayIndexLeadingWhiteSpace)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[ 0]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 says that index should not
  // contain whitespace. Test trailing whitespace.
  TEST(ParseArrayIndex, ArrayIndexTrailingWhiteSpace)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[0 ]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 says that index should only
  // contain an integer.
  TEST(ParseArrayIndex, ArrayIndexBogus)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[0bogus]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(11u, nameLengthWithoutArrayIndex);
  }
  
  // Verify that using an index value out-of-range fails.
  TEST(ParseArrayIndex, ArrayIndexOutOfRange)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX,
                gl::ParseArrayIndex("foo[4294967296]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(15u, nameLengthWithoutArrayIndex);
  }
  
  // Test that ConstStrLen works.
  TEST(Utilities, ConstStrLen)
  {
      constexpr auto v1 = angle::ConstStrLen(nullptr);
      EXPECT_EQ(0u, v1);
      constexpr auto v2 = angle::ConstStrLen("");
      EXPECT_EQ(0u, v2);
      constexpr auto v3 = angle::ConstStrLen("a");
      EXPECT_EQ(1u, v3);
      constexpr char c[5] = "cc\0c";
      constexpr auto v4   = angle::ConstStrLen(c);
      EXPECT_EQ(2u, v4);
      constexpr char d[] = "dddd";
      constexpr auto v5  = angle::ConstStrLen(d);
      EXPECT_EQ(4u, v5);
      constexpr char *e = nullptr;
      constexpr auto v6 = angle::ConstStrLen(e);
      EXPECT_EQ(0u, v6);
  
      // Non-constexpr invocations
      const char cc[5] = "cc\0c";
      auto n1          = angle::ConstStrLen(cc);
      EXPECT_EQ(2u, n1);
      const char *dd = "ddd";
      auto n2        = angle::ConstStrLen(dd);
      EXPECT_EQ(3u, n2);
  }
  
  // Tests gl::ComputeIndexRange().
  TEST(Utilities, IndexRanges)
  {
      constexpr auto b    = gl::DrawElementsType::UnsignedByte;
      uint8_t vertices1[] = {1, 2, 3, 4, 0xff, 6, 5, 7, 10, 0xff, 0xff, 0xff, 9, 8, 0xff};
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 0, true), gl::IndexRange());
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 0, false), gl::IndexRange());
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 1, true), gl::IndexRange(1, 1));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 1, false), gl::IndexRange(1, 1));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 2, true), gl::IndexRange(1, 2));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 2, false), gl::IndexRange(1, 2));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 4, true), gl::IndexRange(1, 4));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 4, false), gl::IndexRange(1, 4));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 5, true), gl::IndexRange(1, 4));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 5, false), gl::IndexRange(1, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 15, true), gl::IndexRange(1, 10));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 15, false), gl::IndexRange(1, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices1, 15, false), gl::IndexRange(1, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices1 + 9, 3, false), gl::IndexRange(255, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices1 + 9, 3, true), gl::IndexRange());
      EXPECT_EQ(ComputeIndexRange(b, vertices1 + 9, 4, false), gl::IndexRange(9, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices1 + 9, 4, true), gl::IndexRange(9, 9));
      EXPECT_EQ(ComputeIndexRange(b, vertices1 + 8, 4, false), gl::IndexRange(10, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices1 + 8, 4, true), gl::IndexRange(10, 10));
      uint8_t vertices2[] = {
          0xff,
          0xff,
          2,
      };
      EXPECT_EQ(ComputeIndexRange(b, vertices2, 1, true), gl::IndexRange());
      EXPECT_EQ(ComputeIndexRange(b, vertices2, 1, false), gl::IndexRange(255, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices2, 2, true), gl::IndexRange());
      EXPECT_EQ(ComputeIndexRange(b, vertices2, 2, false), gl::IndexRange(255, 255));
      EXPECT_EQ(ComputeIndexRange(b, vertices2, 3, true), gl::IndexRange(2, 2));
      EXPECT_EQ(ComputeIndexRange(b, vertices2, 3, false), gl::IndexRange(2, 255));
  }
  
  }  // anonymous namespace
  

Download