• Show log

    Commit

  • Hash : 60e2f11e
    Author : Corentin Wallez
    Date : 2019-07-11T14:56:47

    Rename StaticType's kInstance to instance.
    
    This is more than just a noop: when ANGLE is rolled in Chromium it is
    tested by the Android Binary Size trybot. This trybot runs an analysis
    pass that checks that any new variable names "kSomthing" is in .rodata
    or .data.rel.ro because it helps keep the binary size (and the size of
    each new Chromium process) small on Android.
    
    The analysis picks up new usages of StaticType::Helpers::kInstance as a
    new constant varaible that isn't in .data.rel.ro or .rodata. My
    understanding is that kInstances isn't put in those segments because it
    contains a TType that has a "mutable" field so it would be incorrect to
    put the variable in a read-only segment.
    
    BUG=chromium:981610
    
    Change-Id: I36e550e066206df3404619f1d012b183cbb72fe4
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1698202
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags