-
Show log
Commit
-
Hash : fdba40fe
Author :
Date : 2021-03-31T12:52:00
Reland "Fix multithreaded crash on draw commands on D3D11 backend." This is a reland of 8b9889bf62272fea2495331b622bde1f7c781bd0 The previous CL relied on a define which now only exists in a specific gn configuration. This reland removes D3D11 as a multithread-supported platform in the test configuration. Original change's description: > Fix multithreaded crash on draw commands on D3D11 backend. > > A crash can occur if thread A is executing eglDestroyContext while > thread B issues a draw call, if the threads are interleaved in such a > manner that a makeCurrent occurs without triggering a change to the > global context and a dirtyAllState call. We handle that case by > explicitly making current the proper contexts in the eglDestroyContext > call. > > A test has been added that triggers a crash without this fix when > running on the D3D11 backend. In addition, all of MultithreadingTest > is enabled for the D3D11 backend. > > Test: Ran MultithreadingTest. Test exhibits a crash before this > change, and does not after this change. Also ran: > dEQP-EGL.functional.sharing.gles2.multithread.* > dEQP-EGL.functional.multithread.* > > Bug: b/183756357 > Change-Id: Ic6f76a062868b2f3b4e60d29dc087ec180bfb7cd > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798591 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Doug Horn <doughorn@google.com> Bug: b/183756357 Change-Id: I5be9a011ea99a69730eddc9e4da23bcf92ed3bf2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815243 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
-
Files
- EGLAndroidFrameBufferTargetTest.cpp
- EGLBackwardsCompatibleContextTest.cpp
- EGLBlobCacheTest.cpp
- EGLBufferAgeTest.cpp
- EGLChooseConfigTest.cpp
- EGLContextASANTest.cpp
- EGLContextCompatibilityTest.cpp
- EGLContextSharingTest.cpp
- EGLCreateContextAttribsTest.cpp
- EGLDebugTest.cpp
- EGLDeviceCGLTest.cpp
- EGLDeviceTest.cpp
- EGLDirectCompositionTest.cpp
- EGLDisplayLuidTest.cpp
- EGLFeatureControlTest.cpp
- EGLIOSurfaceClientBufferTest.cpp
- EGLMultiContextTest.cpp
- EGLMultiThreadSteps.h
- EGLNoConfigContextTest.cpp
- EGLPreRotationTest.cpp
- EGLPresentPathD3D11Test.cpp
- EGLPrintEGLinfoTest.cpp
- EGLProgramCacheControlTest.cpp
- EGLQueryContextTest.cpp
- EGLReadinessCheckTest.cpp
- EGLRecordableTest.cpp
- EGLRobustnessTest.cpp
- EGLStreamTest.cpp
- EGLSurfaceTest.cpp
- EGLSurfaceTestMac.mm
- EGLSurfacelessContextTest.cpp
- EGLSyncControlTest.cpp
- EGLSyncTest.cpp
- EGLX11VisualTest.cpp
- media/
