Hash :
b0739436
Author :
Date :
2023-02-13T14:28:17
Traces: Add key frame support
Allow specifying a key frame in the trace JSON, i.e:
"KeyFrames": [ 20 ],
This allows our infra to use a frame other than 1 when
taking screenshots for quality comparison.
Adds new flag `--run-to-key-frame`, which will stop the
trace once key frame has been reached. If no key frame in
JSON, frame 1 will be used.
Note the name in JSON is plural, but we only support one
key frame for now. Multiple key frame support can come
in the future.
This CL also updates the code to allow ending traces
early with `--max-steps-performed` which has been broken
since http://crrev/c/4008998
It also removes `--one-frame-only` which is superseded by
`--run-to-key-frame`, and can be replicated using
`--max-steps-performed 1`.
Test: angle_trace_tests --gtest_filter="*tmnt_shredders_revenge*"
Bug: angleproject:8035
Bug: b/270426257
Change-Id: Ib02ef60d887ae5efb0288f5a9b8c2914dafc6efc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4284637
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342
//
// Copyright 2020 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// frame_capture_test_utils:
// Helper functions for capture and replay of traces.
//
#ifndef UTIL_CAPTURE_FRAME_CAPTURE_TEST_UTILS_H_
#define UTIL_CAPTURE_FRAME_CAPTURE_TEST_UTILS_H_
#include <iostream>
#include <map>
#include <memory>
#include <sstream>
#include <type_traits>
#include <vector>
#include "common/angleutils.h"
#include "common/debug.h"
#include "common/frame_capture_utils.h"
#include "common/system_utils.h"
#define USE_SYSTEM_ZLIB
#include "compression_utils_portable.h"
#define ANGLE_MACRO_STRINGIZE_AUX(a) #a
#define ANGLE_MACRO_STRINGIZE(a) ANGLE_MACRO_STRINGIZE_AUX(a)
#define ANGLE_MACRO_CONCAT_AUX(a, b) a##b
#define ANGLE_MACRO_CONCAT(a, b) ANGLE_MACRO_CONCAT_AUX(a, b)
namespace angle
{
inline uint8_t *DecompressBinaryData(const std::vector<uint8_t> &compressedData)
{
uint32_t uncompressedSize =
zlib_internal::GetGzipUncompressedSize(compressedData.data(), compressedData.size());
std::unique_ptr<uint8_t[]> uncompressedData(new uint8_t[uncompressedSize]);
uLong destLen = uncompressedSize;
int zResult =
zlib_internal::GzipUncompressHelper(uncompressedData.get(), &destLen, compressedData.data(),
static_cast<uLong>(compressedData.size()));
if (zResult != Z_OK)
{
std::cerr << "Failure to decompressed binary data: " << zResult << "\n";
return nullptr;
}
return uncompressedData.release();
}
inline void DeleteBinaryData(uint8_t *uncompressedData)
{
delete[] uncompressedData;
}
using DecompressCallback = uint8_t *(*)(const std::vector<uint8_t> &);
using DeleteCallback = void (*)(uint8_t *);
using ValidateSerializedStateCallback = void (*)(const char *, const char *, uint32_t);
using SetBinaryDataDecompressCallbackFunc = void (*)(DecompressCallback, DeleteCallback);
using SetBinaryDataDirFunc = void (*)(const char *);
using SetupReplayFunc = void (*)();
using ReplayFrameFunc = void (*)(uint32_t);
using ResetReplayFunc = void (*)();
using FinishReplayFunc = void (*)();
using GetSerializedContextStateFunc = const char *(*)(uint32_t);
using SetValidateSerializedStateCallbackFunc = void (*)(ValidateSerializedStateCallback);
class TraceReplayInterface : angle::NonCopyable
{
public:
virtual ~TraceReplayInterface() {}
virtual bool valid() const = 0;
virtual void setBinaryDataDir(const char *dataDir) = 0;
virtual void setBinaryDataDecompressCallback(DecompressCallback decompressCallback,
DeleteCallback deleteCallback) = 0;
virtual void replayFrame(uint32_t frameIndex) = 0;
virtual void setupReplay() = 0;
virtual void resetReplay() = 0;
virtual void finishReplay() = 0;
virtual const char *getSerializedContextState(uint32_t frameIndex) = 0;
virtual void setValidateSerializedStateCallback(ValidateSerializedStateCallback callback) = 0;
protected:
TraceReplayInterface() {}
};
class TraceLibrary : public TraceReplayInterface
{
public:
TraceLibrary(const char *traceNameIn)
{
std::stringstream traceNameStr;
#if !defined(ANGLE_PLATFORM_WINDOWS)
traceNameStr << "lib";
#endif // !defined(ANGLE_PLATFORM_WINDOWS)
traceNameStr << traceNameIn;
#if defined(ANGLE_PLATFORM_ANDROID) && defined(COMPONENT_BUILD)
// Added to shared library names in Android component builds in
// https://chromium.googlesource.com/chromium/src/+/9bacc8c4868cc802f69e1e858eea6757217a508f/build/toolchain/toolchain.gni#56
traceNameStr << ".cr";
#endif // defined(ANGLE_PLATFORM_ANDROID) && defined(COMPONENT_BUILD)
std::string traceName = traceNameStr.str();
mTraceLibrary.reset(OpenSharedLibrary(traceName.c_str(), SearchType::ModuleDir));
}
bool valid() const override
{
return (mTraceLibrary != nullptr) && (mTraceLibrary->getNative() != nullptr);
}
void setBinaryDataDir(const char *dataDir) override
{
callFunc<SetBinaryDataDirFunc>("SetBinaryDataDir", dataDir);
}
void setBinaryDataDecompressCallback(DecompressCallback decompressCallback,
DeleteCallback deleteCallback) override
{
callFunc<SetBinaryDataDecompressCallbackFunc>("SetBinaryDataDecompressCallback",
decompressCallback, deleteCallback);
}
void replayFrame(uint32_t frameIndex) override
{
callFunc<ReplayFrameFunc>("ReplayFrame", frameIndex);
}
void setupReplay() override { callFunc<SetupReplayFunc>("SetupReplay"); }
void resetReplay() override { callFunc<ResetReplayFunc>("ResetReplay"); }
void finishReplay() override { callFunc<FinishReplayFunc>("FinishReplay"); }
const char *getSerializedContextState(uint32_t frameIndex) override
{
return callFunc<GetSerializedContextStateFunc>("GetSerializedContextState", frameIndex);
}
void setValidateSerializedStateCallback(ValidateSerializedStateCallback callback) override
{
return callFunc<SetValidateSerializedStateCallbackFunc>(
"SetValidateSerializedStateCallback", callback);
}
private:
template <typename FuncT, typename... ArgsT>
typename std::invoke_result<FuncT, ArgsT...>::type callFunc(const char *funcName, ArgsT... args)
{
void *untypedFunc = mTraceLibrary->getSymbol(funcName);
if (!untypedFunc)
{
fprintf(stderr, "Error loading function: %s\n", funcName);
ASSERT(untypedFunc);
}
auto typedFunc = reinterpret_cast<FuncT>(untypedFunc);
return typedFunc(args...);
}
std::unique_ptr<Library> mTraceLibrary;
};
static constexpr size_t kTraceInfoMaxNameLen = 128;
struct TraceInfo
{
char name[kTraceInfoMaxNameLen];
bool initialized = false;
uint32_t contextClientMajorVersion;
uint32_t contextClientMinorVersion;
uint32_t frameStart;
uint32_t frameEnd;
uint32_t drawSurfaceWidth;
uint32_t drawSurfaceHeight;
uint32_t drawSurfaceColorSpace;
uint32_t displayPlatformType;
uint32_t displayDeviceType;
int configRedBits;
int configBlueBits;
int configGreenBits;
int configAlphaBits;
int configDepthBits;
int configStencilBits;
bool isBinaryDataCompressed;
bool areClientArraysEnabled;
bool isBindGeneratesResourcesEnabled;
bool isWebGLCompatibilityEnabled;
bool isRobustResourceInitEnabled;
std::vector<std::string> traceFiles;
int windowSurfaceContextId;
std::vector<std::string> requiredExtensions;
std::vector<int> keyFrames;
};
bool LoadTraceNamesFromJSON(const std::string jsonFilePath, std::vector<std::string> *namesOut);
bool LoadTraceInfoFromJSON(const std::string &traceName,
const std::string &traceJsonPath,
TraceInfo *traceInfoOut);
using TraceFunction = std::vector<CallCapture>;
using TraceFunctionMap = std::map<std::string, TraceFunction>;
void ReplayTraceFunction(const TraceFunction &func, const TraceFunctionMap &customFunctions);
void ReplayTraceFunctionCall(const CallCapture &call, const TraceFunctionMap &customFunctions);
void ReplayCustomFunctionCall(const CallCapture &call, const TraceFunctionMap &customFunctions);
template <typename T>
struct AssertFalse : std::false_type
{};
GLuint GetResourceIDMapValue(ResourceIDType resourceIDType, GLuint key);
template <typename T>
T GetParamValue(ParamType type, const ParamValue &value);
template <>
inline GLuint GetParamValue<GLuint>(ParamType type, const ParamValue &value)
{
ResourceIDType resourceIDType = GetResourceIDTypeFromParamType(type);
if (resourceIDType == ResourceIDType::InvalidEnum)
{
return value.GLuintVal;
}
else
{
return GetResourceIDMapValue(resourceIDType, value.GLuintVal);
}
}
template <>
inline GLint GetParamValue<GLint>(ParamType type, const ParamValue &value)
{
return value.GLintVal;
}
template <>
inline const void *GetParamValue<const void *>(ParamType type, const ParamValue &value)
{
return value.voidConstPointerVal;
}
template <>
inline GLuint64 GetParamValue<GLuint64>(ParamType type, const ParamValue &value)
{
return value.GLuint64Val;
}
template <>
inline GLint64 GetParamValue<GLint64>(ParamType type, const ParamValue &value)
{
return value.GLint64Val;
}
template <>
inline const char *GetParamValue<const char *>(ParamType type, const ParamValue &value)
{
return value.GLcharConstPointerVal;
}
template <>
inline void *GetParamValue<void *>(ParamType type, const ParamValue &value)
{
return value.voidPointerVal;
}
#if defined(ANGLE_IS_64_BIT_CPU)
template <>
inline const EGLAttrib *GetParamValue<const EGLAttrib *>(ParamType type, const ParamValue &value)
{
return value.EGLAttribConstPointerVal;
}
#endif // defined(ANGLE_IS_64_BIT_CPU)
template <>
inline const EGLint *GetParamValue<const EGLint *>(ParamType type, const ParamValue &value)
{
return value.EGLintConstPointerVal;
}
template <>
inline const GLchar *const *GetParamValue<const GLchar *const *>(ParamType type,
const ParamValue &value)
{
return value.GLcharConstPointerPointerVal;
}
// On Apple platforms, std::is_same<uint64_t, long> is false despite being both 8 bits.
#if defined(ANGLE_PLATFORM_APPLE) || !defined(ANGLE_IS_64_BIT_CPU)
template <>
inline long GetParamValue<long>(ParamType type, const ParamValue &value)
{
return static_cast<long>(value.GLint64Val);
}
template <>
inline unsigned long GetParamValue<unsigned long>(ParamType type, const ParamValue &value)
{
return static_cast<unsigned long>(value.GLuint64Val);
}
#endif // defined(ANGLE_PLATFORM_APPLE)
template <typename T>
T GetParamValue(ParamType type, const ParamValue &value)
{
static_assert(AssertFalse<T>::value, "No specialization for type.");
}
template <typename T>
struct Traits;
template <typename... Args>
struct Traits<void(Args...)>
{
static constexpr size_t NArgs = sizeof...(Args);
template <size_t Idx>
struct Arg
{
typedef typename std::tuple_element<Idx, std::tuple<Args...>>::type Type;
};
};
template <typename Fn, size_t Idx>
using FnArg = typename Traits<Fn>::template Arg<Idx>::Type;
template <typename Fn, size_t NArgs>
using EnableIfNArgs = typename std::enable_if_t<Traits<Fn>::NArgs == NArgs, int>;
template <typename Fn, size_t Idx>
FnArg<Fn, Idx> Arg(const Captures &cap)
{
ASSERT(Idx < cap.size());
return GetParamValue<FnArg<Fn, Idx>>(cap[Idx].type, cap[Idx].value);
}
} // namespace angle
#endif // UTIL_CAPTURE_FRAME_CAPTURE_TEST_UTILS_H_