kc3-lang/angle/src/libANGLE/renderer

• Show log

  Commit

• Hash : 1365f5b3
  Author :
  Date : 2022-09-09T17:19:26
  

  Vulkan: Fix Swapchain Acquire Image Semaphore wait stage flags.
  
  There is a screen tearing on G996B with single
  "glClear(GL_COLOR_BUFFER_BIT)" no scissor in the frame.
  
  Fixed by defining "kSwapchainAcquireImageWaitStageFlags" and
  adding "VK_PIPELINE_STAGE_TRANSFER_BIT" stage flag.
  
  Also added "VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT" stage, because first
  use of the Swapchain Image after Acquire may be in the
  "glBlitFramebuffer()" command.
  
  This fix may slightly affect performance. In such case, a better fix
  should be implemented (include only stages based on the actual first
  use). However, this may be not trivial.
  
  Additionally, "kSwapchainAcquireImageWaitStageFlags" is used as a source
  stage mask in the "ImageLayout::Present" pipeline barrier. This is
  needed in order to build a dependency chain from the Acquire Image
  Semaphore to the layout transition's first synchronization scope, so
  that layout transition happens after acquire semaphore is signaled.
  Reference:
      https://github.com/KhronosGroup/Vulkan-Docs/wiki/Synchronization-Examples#combined-graphicspresent-queue
      https://vulkan-tutorial.com/Drawing_a_triangle/Drawing/Rendering_and_presentation
  
  Alternative fix of both issues is to define:
  
      kSwapchainAcquireImageWaitStageFlags = VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT
  
  This might potentially delay command buffer execution relative to the
  Swapchain Acquire Image Semaphore signal operations, but will relax
  the pipeline barrier.
  
  Bug: angleproject:8030
  Test: angle_end2end_tests --gtest_also_run_disabled_tests --gtest_filter=EGLSurfaceTest.DISABLED_RandomClearTearing*
  Change-Id: I29f58862c4b369524b2555dd944e2fb67eebe956
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4271377
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  Reviewed-by: Charlie Lao <cclao@google.com>
  

• Files

• BufferImpl.cpp
• BufferImpl.h
• BufferImpl_mock.h
• CLCommandQueueImpl.cpp
• CLCommandQueueImpl.h
• CLContextImpl.cpp
• CLContextImpl.h
• CLDeviceImpl.cpp
• CLDeviceImpl.h
• CLEventImpl.cpp
• CLEventImpl.h
• CLExtensions.cpp
• CLExtensions.h
• CLKernelImpl.cpp
• CLKernelImpl.h
• CLMemoryImpl.cpp
• CLMemoryImpl.h
• CLPlatformImpl.cpp
• CLPlatformImpl.h
• CLProgramImpl.cpp
• CLProgramImpl.h
• CLSamplerImpl.cpp
• CLSamplerImpl.h
• CLtypes.h
• CompilerImpl.h
• ContextImpl.cpp
• ContextImpl.h
• DeviceImpl.cpp
• DeviceImpl.h
• DisplayImpl.cpp
• DisplayImpl.h
• EGLImplFactory.h
• EGLReusableSync.cpp
• EGLReusableSync.h
• EGLSyncImpl.cpp
• EGLSyncImpl.h
• FenceNVImpl.h
• Format.h
• FormatID_autogen.h
• Format_table_autogen.cpp
• FramebufferAttachmentObjectImpl.h
• FramebufferImpl.cpp
• FramebufferImpl.h
• FramebufferImpl_mock.h
• GLImplFactory.h
• ImageImpl.cpp
• ImageImpl.h
• ImageImpl_mock.h
• MemoryObjectImpl.h
• OverlayImpl.h
• ProgramImpl.cpp
• ProgramImpl.h
• ProgramImpl_mock.h
• ProgramPipelineImpl.cpp
• ProgramPipelineImpl.h
• QueryImpl.cpp
• QueryImpl.h
• README.md
• RenderTargetCache.h
• RenderbufferImpl.cpp
• RenderbufferImpl.h
• RenderbufferImpl_mock.h
• SamplerImpl.h
• SemaphoreImpl.h
• ShaderImpl.cpp
• ShaderImpl.h
• StreamProducerImpl.h
• SurfaceImpl.cpp
• SurfaceImpl.h
• SyncImpl.h
• TextureImpl.cpp
• TextureImpl.h
• TextureImpl_mock.h
• TransformFeedbackImpl.cpp
• TransformFeedbackImpl.h
• TransformFeedbackImpl_mock.h
• VertexArrayImpl.cpp
• VertexArrayImpl.h
• angle_format.py
• angle_format_data.json
• angle_format_map.json
• cl/
• copyvertex.h
• copyvertex.inc.h
• d3d/
• d3d_format.cpp
• d3d_format.h
• driver_utils.cpp
• driver_utils.h
• driver_utils_ios.mm
• driver_utils_mac.mm
• dxgi_format_data.json
• dxgi_format_map.h
• dxgi_format_map_autogen.cpp
• dxgi_support_data.json
• dxgi_support_table.h
• dxgi_support_table_autogen.cpp
• gen_angle_format_table.py
• gen_dxgi_format_table.py
• gen_dxgi_support_tables.py
• gen_load_functions_table.py
• gl/
• load_functions_data.json
• load_functions_table.h
• load_functions_table_autogen.cpp
• metal/
• null/
• renderer_utils.cpp
• renderer_utils.h
• serial_utils.h
• serial_utils_unittest.cpp
• vulkan/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags