Hash :
3857752d
Author :
Date :
2022-11-18T14:35:42
Tests: Fix parameter parsing with partial matches New parameter parsing code needs a small tweak to handle partial flag matches. For instance, a new flag being added would trigger as if an old one had been provided: new: --fixed-test-time-with-warmup old: --fixed-test-time And if equals notations were being used: --fixed-test-time-with-warmup=value the code before this CL will treat the entire thing as --fixed-test-time and attempt to consume the next argument as value Bug: angleproject:7755 Change-Id: I57eae2847053d664338d40b0191d5223ddd95852 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038494 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260
//
// Copyright 2019 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// system_utils: Defines common utility functions
#include "util/test_utils.h"
#include <EGL/egl.h>
#include <EGL/eglext.h>
#include <cstring>
#include <fstream>
#include <iostream>
namespace angle
{
namespace
{
void DeleteArg(int *argc, char **argv, int argIndex)
{
// Shift the remainder of the argv list left by one. Note that argv has (*argc + 1) elements,
// the last one always being NULL. The following loop moves the trailing NULL element as well.
for (int index = argIndex; index < *argc; ++index)
{
argv[index] = argv[index + 1];
}
(*argc)--;
}
const char *GetSingleArg(const char *flag,
int *argc,
char **argv,
int argIndex,
ArgHandling handling)
{
if (strstr(argv[argIndex], flag) == argv[argIndex])
{
const char *ptr = argv[argIndex] + strlen(flag);
if (*ptr == '=')
{
if (handling == ArgHandling::Delete)
{
DeleteArg(argc, argv, argIndex);
}
return ptr + 1;
}
if (*ptr == '\0' && argIndex < *argc - 1)
{
ptr = argv[argIndex + 1];
if (handling == ArgHandling::Delete)
{
DeleteArg(argc, argv, argIndex);
DeleteArg(argc, argv, argIndex);
}
return ptr;
}
}
return nullptr;
}
using DisplayTypeInfo = std::pair<const char *, EGLint>;
const DisplayTypeInfo kDisplayTypes[] = {
{"d3d9", EGL_PLATFORM_ANGLE_TYPE_D3D9_ANGLE},
{"d3d11", EGL_PLATFORM_ANGLE_TYPE_D3D11_ANGLE},
{"gl", EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE},
{"gles", EGL_PLATFORM_ANGLE_TYPE_OPENGLES_ANGLE},
{"metal", EGL_PLATFORM_ANGLE_TYPE_METAL_ANGLE},
{"null", EGL_PLATFORM_ANGLE_TYPE_NULL_ANGLE},
{"swiftshader", EGL_PLATFORM_ANGLE_TYPE_VULKAN_ANGLE},
{"vulkan", EGL_PLATFORM_ANGLE_TYPE_VULKAN_ANGLE},
};
} // anonymous namespace
bool GetFileSize(const char *filePath, uint32_t *sizeOut)
{
std::ifstream stream(filePath);
if (!stream)
{
return false;
}
stream.seekg(0, std::ios::end);
*sizeOut = static_cast<uint32_t>(stream.tellg());
return true;
}
bool ReadEntireFileToString(const char *filePath, std::string *contentsOut)
{
std::ifstream stream(filePath);
if (!stream)
{
return false;
}
stream.seekg(0, std::ios::end);
contentsOut->reserve(static_cast<unsigned int>(stream.tellg()));
stream.seekg(0, std::ios::beg);
contentsOut->assign((std::istreambuf_iterator<char>(stream)), std::istreambuf_iterator<char>());
return true;
}
// static
Process::~Process() = default;
ProcessHandle::ProcessHandle() : mProcess(nullptr) {}
ProcessHandle::ProcessHandle(Process *process) : mProcess(process) {}
ProcessHandle::ProcessHandle(const std::vector<const char *> &args,
ProcessOutputCapture captureOutput)
: mProcess(LaunchProcess(args, captureOutput))
{}
ProcessHandle::~ProcessHandle()
{
reset();
}
ProcessHandle::ProcessHandle(ProcessHandle &&other) : mProcess(other.mProcess)
{
other.mProcess = nullptr;
}
ProcessHandle &ProcessHandle::operator=(ProcessHandle &&rhs)
{
std::swap(mProcess, rhs.mProcess);
return *this;
}
void ProcessHandle::reset()
{
if (mProcess)
{
delete mProcess;
mProcess = nullptr;
}
}
bool ParseIntArgWithHandling(const char *flag,
int *argc,
char **argv,
int argIndex,
int *valueOut,
ArgHandling handling)
{
const char *value = GetSingleArg(flag, argc, argv, argIndex, handling);
if (!value)
{
return false;
}
char *end = nullptr;
const long longValue = strtol(value, &end, 10);
if (*end != '\0')
{
printf("Error parsing integer flag value.\n");
exit(EXIT_FAILURE);
}
if (longValue == LONG_MAX || longValue == LONG_MIN || static_cast<int>(longValue) != longValue)
{
printf("Overflow when parsing integer flag value.\n");
exit(EXIT_FAILURE);
}
*valueOut = static_cast<int>(longValue);
return handling == ArgHandling::Delete;
}
bool ParseIntArg(const char *flag, int *argc, char **argv, int argIndex, int *valueOut)
{
return ParseIntArgWithHandling(flag, argc, argv, argIndex, valueOut, ArgHandling::Delete);
}
bool ParseFlag(const char *flag, int *argc, char **argv, int argIndex, bool *flagOut)
{
if (strcmp(flag, argv[argIndex]) == 0)
{
*flagOut = true;
DeleteArg(argc, argv, argIndex);
return true;
}
return false;
}
bool ParseStringArg(const char *flag, int *argc, char **argv, int argIndex, std::string *valueOut)
{
const char *value = GetSingleArg(flag, argc, argv, argIndex, ArgHandling::Delete);
if (!value)
{
return false;
}
*valueOut = value;
return true;
}
bool ParseCStringArg(const char *flag, int *argc, char **argv, int argIndex, const char **valueOut)
{
const char *value = GetSingleArg(flag, argc, argv, argIndex, ArgHandling::Delete);
if (!value)
{
return false;
}
*valueOut = value;
return true;
}
void AddArg(int *argc, char **argv, const char *arg)
{
// This unsafe const_cast is necessary to work around gtest limitations.
argv[*argc] = const_cast<char *>(arg);
argv[*argc + 1] = nullptr;
(*argc)++;
}
uint32_t GetPlatformANGLETypeFromArg(const char *useANGLEArg, uint32_t defaultPlatformType)
{
if (!useANGLEArg)
{
return defaultPlatformType;
}
for (const DisplayTypeInfo &displayTypeInfo : kDisplayTypes)
{
if (strcmp(displayTypeInfo.first, useANGLEArg) == 0)
{
std::cout << "Using ANGLE back-end API: " << displayTypeInfo.first << std::endl;
return displayTypeInfo.second;
}
}
std::cout << "Unknown ANGLE back-end API: " << useANGLEArg << std::endl;
exit(EXIT_FAILURE);
}
uint32_t GetANGLEDeviceTypeFromArg(const char *useANGLEArg, uint32_t defaultDeviceType)
{
if (useANGLEArg && strcmp(useANGLEArg, "swiftshader") == 0)
{
return EGL_PLATFORM_ANGLE_DEVICE_TYPE_SWIFTSHADER_ANGLE;
}
else
{
return defaultDeviceType;
}
}
} // namespace angle