• Show log

    Commit

  • Hash : dd936c23
    Author : Spandan Das
    Date : 2024-01-16T20:27:36

    Android: Build angle libs with a shared copy of libz
    
    Soong creates two variants of angle libraries - a platform variant and
    an sdk variant (because it sets sdk_version in bp). This CL changes the
    link type of angle --> libz to a shared link dependency from a static
    link dependency
    
    This affects the variants in the following ways
    1. Platform variant: Links against (shared,platform) variant of libz
    ld diff https://diff.googleplex.com/#key=pw6D7KHophSB
    2. Sdk variant: Links against (shared,sdk) variant. This is really the
       ndk variant of libz.
    ld diff https://diff.googleplex.com/#key=g9ffVxxAesEk
    
    Both (1) and (2) have the incidental benefit that it decreases the size
    of the angle libraries since libz is no longer statically linked into
    angle libraires.
    
    In case of (2), we have an additional benefit of actually enforcing an
    api boundary between angle and libz. Before this CL, angle could access
    implementation of libz. After this CL, angle can only access the public
    apis of libz.
    
    Bug: b/281077552
    Test: presubmits on https://android-review.git.corp.google.com/c/platform/external/angle/+/2907477
    Test: Inspected ninja graph (ld diffs attached)
    Change-Id: I745abb836878a5b6e195fb9ddb359673308f9fac
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5201878
    Commit-Queue: Roman Lavrov <romanl@google.com>
    Auto-Submit: Spandan Das <spandandas@google.com>
    Reviewed-by: Roman Lavrov <romanl@google.com>
    Commit-Queue: Spandan Das <spandandas@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags