kc3-lang/angle/src/tests/test_utils

Diff

• Show log

  Commit

• Hash : 64fa1e80
  Author :
  Date : 2022-04-19T13:18:23
  

  Revert "vulkan: Call glFinish in VulkanHelper destructor"
  
  This reverts commit aefb2a99ebb598c7b3530056ef3d030b5c4f0115.
  
  Reason for revert: Still flakes:
  
  https://ci.chromium.org/ui/p/angle/builders/try/linux-test/4382/overview
  
  Original change's description:
  > vulkan: Call glFinish in VulkanHelper destructor
  >
  > In async queue mode, GL commands are submitted asynchronously to the
  > VkQueue on a separate thread. VulkanHelper destructor uses the VkQueue
  > when it calls vkDeviceWaitIdle(), and that's a data race when the queue
  > is being used to run GL commands on the other thread. Calling glFinish()
  > before any Vulkan commands ensures that the queue isn't being used on
  > another thread.
  >
  > Bug: angleproject:7204
  > Change-Id: I509bcf55edf430e39805a9d43c07a902942d33ca
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587366
  > Reviewed-by: Jamie Madill <jmadill@chromium.org>
  > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
  > Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
  
  Bug: angleproject:7204
  Change-Id: I60e6fc519b21d53619309247fdea32f23375f975
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594099
  Auto-Submit: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  

• Files

• ANGLETest.cpp
• ANGLETest.h
• ConstantFoldingTest.cpp
• ConstantFoldingTest.h
• MultiThreadSteps.h
• MultiviewTest.cpp
• MultiviewTest.h
• RenderDoc.cpp
• RenderDoc.h
• ShaderCompileTreeTest.cpp
• ShaderCompileTreeTest.h
• ShaderExtensionTest.h
• VulkanHelper.cpp
• VulkanHelper.h
• angle_test_configs.cpp
• angle_test_configs.h
• angle_test_instantiate.cpp
• angle_test_instantiate.h
• angle_test_instantiate_apple.h
• angle_test_instantiate_apple.mm
• angle_test_platform.cpp
• angle_test_platform.h
• compiler_test.cpp
• compiler_test.h
• draw_call_perf_utils.cpp
• draw_call_perf_utils.h
• gl_raii.h
• runner/
• system_info_util.cpp
• system_info_util.h
• third_party/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags